test(release): refresh release-validation harness for v0.20.0 behavior changes

The release-validation shell harness carries its own copies of behavior
assertions that duplicate the integration suite. Two of them went stale
this cycle from the same PRs that broke the integration tests (#1757):

- GH-AW compat (#1720): `apm pack --archive` now emits .zip by default;
  the archive check grepped only `build/*.tar.gz`. Accept either
  extension, testing each glob independently (a single `ls a b` exits
  non-zero when either pattern is unmatched, even if the other matches).
- Hero scenario 2 / AGENTS.md (#1742): copilot `apm compile` omits the
  empty AGENTS.md shell when installed instructions already live under
  `.github/instructions/`. The check insisted AGENTS.md exist; now accept
  AGENTS.md OR a populated `.github/instructions/`, mirroring the merged
  pytest fix in test_guardrailing_hero_e2e.py.

Same fixes applied to the Windows .ps1 (AGENTS.md only; it has no archive
check). Predicates validated locally against apm v0.20.0.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: danielmeppiel

scripts/test-release-validation.sh

@@ -286,14 +286,20 @@ test_hero_guardrailing() {
         return 1
     fi
 
-    if [[ ! -f "AGENTS.md" ]]; then
-        log_error "AGENTS.md not created by compile"
+    # Copilot compile suppresses empty AGENTS.md shells when installed
+    # instructions already live under .github/instructions/ (the guardrail
+    # surface Copilot reads directly). Validate that compiled guardrails
+    # landed there rather than insisting on an AGENTS.md shell.
+    if [[ -f "AGENTS.md" ]]; then
+        log_success "Compiled to AGENTS.md (guardrails active)"
+    elif ls .github/instructions/*.md 1>/dev/null 2>&1; then
+        log_success "Compiled guardrails to .github/instructions/ (Copilot reads them directly)"
+    else
+        log_error "compile produced no guardrail surface (neither AGENTS.md nor .github/instructions/)"
         cd ..
         return 1
     fi
 
-    log_success "Compiled to AGENTS.md (guardrails active)"
-    
     # Step 5: apm run design-review (from installed package)
     # Gated by APM_RUN_INFERENCE_TESTS — live inference is decoupled from
     # the release pipeline and runs in ci-runtime.yml.
@@ -399,8 +405,11 @@ APMYML
             exit 1
         fi
 
-        # Verify a bundle was produced
-        if ls build/*.tar.gz 1>/dev/null 2>&1; then
+        # Verify a bundle was produced. 'apm pack --archive' now emits .zip by
+        # default (legacy pipelines opt back in with --archive-format tar.gz),
+        # so accept either extension. Test each glob independently: a single
+        # `ls a b` exits non-zero when either pattern is unmatched.
+        if ls build/*.zip 1>/dev/null 2>&1 || ls build/*.tar.gz 1>/dev/null 2>&1; then
             echo "Bundle archive produced successfully"
         else
             echo "No bundle archive found in build/"

scripts/windows/test-release-validation.ps1

@@ -327,13 +327,19 @@ function Test-HeroGuardrailing {
             return $false
         }
 
-        if (-not (Test-Path "AGENTS.md")) {
-            Write-ErrorText "AGENTS.md not created by compile"
+        # Copilot compile suppresses empty AGENTS.md shells when installed
+        # instructions already live under .github/instructions/ (the guardrail
+        # surface Copilot reads directly). Validate that compiled guardrails
+        # landed there rather than insisting on an AGENTS.md shell.
+        if (Test-Path "AGENTS.md") {
+            Write-Success "Compiled to AGENTS.md (guardrails active)"
+        } elseif (Get-ChildItem -Path ".github/instructions" -Filter "*.md" -ErrorAction SilentlyContinue) {
+            Write-Success "Compiled guardrails to .github/instructions/ (Copilot reads them directly)"
+        } else {
+            Write-ErrorText "compile produced no guardrail surface (neither AGENTS.md nor .github/instructions/)"
             return $false
         }
 
-        Write-Success "Compiled to AGENTS.md (guardrails active)"
-
         # Step 5: apm run design-review (from installed package)
         Write-Host "Running: $script:BINARY_PATH run design-review (with 10s timeout)"
         Write-Host "--- Command Output Start ---"