Merge pull request #410 from Microsoft/fix/hide_progress_dialog_background

Fix hiding progress dialog on download/install failure

Author: dhei

sdk/mobile-center-distribute/src/main/java/com/microsoft/azure/mobile/distribute/Distribute.java

@@ -1306,8 +1306,17 @@ private void showDownloadProgress() {
      */
     private synchronized void hideProgressDialog() {
         if (mProgressDialog != null) {
-            mProgressDialog.hide();
+            final ProgressDialog progressDialog = mProgressDialog;
             mProgressDialog = null;
+
+            /* This can be called from background check download task. */
+            HandlerUtils.runOnUiThread(new Runnable() {
+
+                @Override
+                public void run() {
+                    progressDialog.hide();
+                }
+            });
             HandlerUtils.getMainHandler().removeCallbacksAndMessages(HANDLER_TOKEN_CHECK_PROGRESS);
         }
     }

sdk/mobile-center-distribute/src/test/java/com/microsoft/azure/mobile/distribute/DistributeMandatoryDownloadTest.java

@@ -291,10 +291,17 @@ public Void answer(InvocationOnMock invocation) throws Throwable {
         }).when(mContext).startActivity(installIntent);
         doAnswer(new Answer<Void>() {
 
+            boolean firstCall = true;
+
             @Override
             public Void answer(InvocationOnMock invocation) throws Throwable {
-                beforeStartingActivityLock.release();
-                disabledLock.acquireUninterruptibly();
+
+                /* First call is update progress dialog, second is hide. */
+                if (firstCall) {
+                    firstCall = false;
+                    beforeStartingActivityLock.release();
+                    disabledLock.acquireUninterruptibly();
+                }
                 (((Runnable) invocation.getArguments()[0])).run();
                 return null;
             }