Merge pull request #486 from Microsoft/fix/unknown_sources_android_o

Can't check unknown sources detection on Android 8 if target is below 26

Author: guperrot

sdk/mobile-center-distribute/src/main/java/com/microsoft/azure/mobile/distribute/InstallerUtils.java

@@ -1,6 +1,5 @@
 package com.microsoft.azure.mobile.distribute;
 
-import android.content.ContentResolver;
 import android.content.Context;
 import android.os.Build;
 import android.provider.Settings;
@@ -70,8 +69,15 @@ static synchronized boolean isInstalledFromAppStore(@NonNull String logTag, @Non
      */
     @SuppressWarnings("deprecation")
     static boolean isUnknownSourcesEnabled(@NonNull Context context) {
+
+        /*
+         * On Android 8 with applications targeting lower versions,
+         * it's impossible to check unknown sources enabled: using old APIs will always return true
+         * and using the new one will always return false,
+         * so in order to avoid a stuck dialog that can't be bypassed we will assume true.
+         */
         if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) {
-            return context.getPackageManager().canRequestPackageInstalls();
+            return context.getApplicationInfo().targetSdkVersion < Build.VERSION_CODES.O || context.getPackageManager().canRequestPackageInstalls();
         } else if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1 && Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
             return INSTALL_NON_MARKET_APPS_ENABLED.equals(Settings.Global.getString(context.getContentResolver(), Settings.Global.INSTALL_NON_MARKET_APPS));
         } else {

sdk/mobile-center-distribute/src/test/java/com/microsoft/azure/mobile/distribute/UnknownSourcesDetectionTest.java

@@ -3,6 +3,7 @@
 import android.annotation.SuppressLint;
 import android.content.ContentResolver;
 import android.content.Context;
+import android.content.pm.ApplicationInfo;
 import android.content.pm.PackageManager;
 import android.os.Build;
 import android.provider.Settings;
@@ -40,6 +41,9 @@ public class UnknownSourcesDetectionTest {
     @Mock
     private PackageManager mPackageManager;
 
+    @Mock
+    private ApplicationInfo mApplicationInfo;
+
     private static void mockApiLevel(int apiLevel) {
         Whitebox.setInternalState(Build.VERSION.class, "SDK_INT", apiLevel);
     }
@@ -49,6 +53,7 @@ public void setUp() {
         mockStatic(Settings.Global.class);
         mockStatic(Settings.Secure.class);
         when(mContext.getPackageManager()).thenReturn(mPackageManager);
+        when(mContext.getApplicationInfo()).thenReturn(mApplicationInfo);
     }
 
     @Test
@@ -71,12 +76,23 @@ public void unknownSourcesEnabledViaPackageManager() {
             assertFalse(InstallerUtils.isUnknownSourcesEnabled(mContext));
             verify(mPackageManager, never()).canRequestPackageInstalls();
         }
+
+        /* Test from Android 8 targeting that Android version. */
         for (int apiLevel = Build.VERSION_CODES.O; apiLevel <= BuildConfig.TARGET_SDK_VERSION; apiLevel++) {
             mockApiLevel(apiLevel);
+            Whitebox.setInternalState(mApplicationInfo, "targetSdkVersion", apiLevel);
             assertTrue(InstallerUtils.isUnknownSourcesEnabled(mContext));
             verify(mPackageManager).canRequestPackageInstalls();
             reset(mPackageManager);
         }
+
+        /* Test from Android 8 targeting older versions: always true. */
+        Whitebox.setInternalState(mApplicationInfo, "targetSdkVersion", Build.VERSION_CODES.N_MR1);
+        for (int apiLevel = Build.VERSION_CODES.O; apiLevel <= BuildConfig.TARGET_SDK_VERSION; apiLevel++) {
+            mockApiLevel(apiLevel);
+            assertTrue(InstallerUtils.isUnknownSourcesEnabled(mContext));
+            verify(mPackageManager, never()).canRequestPackageInstalls();
+        }
     }
 
     @Test
@@ -101,6 +117,7 @@ public void unknownSourcesEnabledViaSystemSecure() {
         }
         for (int apiLevel = Build.VERSION_CODES.O; apiLevel <= BuildConfig.TARGET_SDK_VERSION; apiLevel++) {
             mockApiLevel(apiLevel);
+            Whitebox.setInternalState(mApplicationInfo, "targetSdkVersion", apiLevel);
             assertFalse(InstallerUtils.isUnknownSourcesEnabled(mContext));
             verify(mPackageManager).canRequestPackageInstalls();
             reset(mPackageManager);
@@ -129,6 +146,7 @@ public void unknownSourcesEnabledViaSystemGlobal() {
         }
         for (int apiLevel = Build.VERSION_CODES.O; apiLevel <= BuildConfig.TARGET_SDK_VERSION; apiLevel++) {
             mockApiLevel(apiLevel);
+            Whitebox.setInternalState(mApplicationInfo, "targetSdkVersion", apiLevel);
             assertFalse(InstallerUtils.isUnknownSourcesEnabled(mContext));
             verify(mPackageManager).canRequestPackageInstalls();
             reset(mPackageManager);