Address PR review feedback

Fix the AppHost workflow indentation, validate preview registrations against the configured repository, make registry writes durable, harden cleanup deletes, and align the Preview AppHost to the repo's current Aspire package versions.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: IEvangelist

.github/workflows/apphost-build.yml

@@ -23,33 +23,33 @@ jobs:
             project_path: src/apphost/Aspire.Dev.Preview.AppHost
             artifact_name: preview-apphost-release
     steps:
-    - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
-
-    - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5.2.0
-      with:
-        global-json-file: global.json
-
-    - name: Restore
-      run: cd ${{ matrix.apphost.project_path }} && dotnet restore
-
-    - name: Build
-      run: cd ${{ matrix.apphost.project_path }} && dotnet build --no-restore --configuration Release
-
-    - name: Verify output
-      run: |
-        APPHOST_DLL=$(ls -1 ${{ matrix.apphost.project_path }}/bin/Release/*/${{ matrix.apphost.project_name }}.dll 2>/dev/null | head -n 1)
-        if [ -z "$APPHOST_DLL" ]; then
-          echo "AppHost build failed - output assembly not found"
-          ls -R ${{ matrix.apphost.project_path }}/bin/Release || true
-          exit 1
-        fi
-        echo "Found $APPHOST_DLL"
-
-    - name: Upload artifact
-      if: ${{ always() }}
-      uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
-      with:
-        name: ${{ matrix.apphost.artifact_name }}
-        path: ${{ matrix.apphost.project_path }}/bin/Release/*/
-        if-no-files-found: warn
-        retention-days: 7
+      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+
+      - uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777cf28262a3eb3db3ced7 # v5.2.0
+        with:
+          global-json-file: global.json
+
+      - name: Restore
+        run: cd ${{ matrix.apphost.project_path }} && dotnet restore
+
+      - name: Build
+        run: cd ${{ matrix.apphost.project_path }} && dotnet build --no-restore --configuration Release
+
+      - name: Verify output
+        run: |
+          APPHOST_DLL=$(ls -1 ${{ matrix.apphost.project_path }}/bin/Release/*/${{ matrix.apphost.project_name }}.dll 2>/dev/null | head -n 1)
+          if [ -z "$APPHOST_DLL" ]; then
+            echo "AppHost build failed - output assembly not found"
+            ls -R ${{ matrix.apphost.project_path }}/bin/Release || true
+            exit 1
+          fi
+          echo "Found $APPHOST_DLL"
+
+      - name: Upload artifact
+        if: ${{ always() }}
+        uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
+        with:
+          name: ${{ matrix.apphost.artifact_name }}
+          path: ${{ matrix.apphost.project_path }}/bin/Release/*/
+          if-no-files-found: warn
+          retention-days: 7

src/apphost/Aspire.Dev.Preview.AppHost/Aspire.Dev.Preview.AppHost.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Aspire.AppHost.Sdk/13.1.0">
+<Project Sdk="Aspire.AppHost.Sdk/13.2.0">
 
   <PropertyGroup>
     <OutputType>Exe</OutputType>
@@ -9,7 +9,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aspire.Hosting.Azure.AppService" Version="13.1.0-preview.1.25616.3" />
+    <PackageReference Include="Aspire.Hosting.Azure.AppService" Version="13.2.0" />
   </ItemGroup>
 
   <ItemGroup>

src/statichost/PreviewHost/Previews/PreviewCoordinator.cs

@@ -810,19 +810,51 @@ private static string ResolveActivationSourceDirectory(string extractedRoot)
         return nestedDirectory?.Directory ?? extractedRoot;
     }
 
-    private static void DeleteFileIfPresent(string? path)
+    private void DeleteFileIfPresent(string? path)
     {
-        if (!string.IsNullOrWhiteSpace(path) && File.Exists(path))
+        if (string.IsNullOrWhiteSpace(path))
         {
-            File.Delete(path);
+            return;
+        }
+
+        try
+        {
+            if (File.Exists(path))
+            {
+                File.Delete(path);
+            }
+        }
+        catch (IOException exception)
+        {
+            _logger.LogWarning(exception, "Failed to delete temporary preview file {Path}", path);
+        }
+        catch (UnauthorizedAccessException exception)
+        {
+            _logger.LogWarning(exception, "Failed to delete temporary preview file {Path}", path);
         }
     }
 
-    private static void DeleteDirectoryIfPresent(string? path)
+    private void DeleteDirectoryIfPresent(string? path)
     {
-        if (!string.IsNullOrWhiteSpace(path) && Directory.Exists(path))
+        if (string.IsNullOrWhiteSpace(path))
+        {
+            return;
+        }
+
+        try
+        {
+            if (Directory.Exists(path))
+            {
+                Directory.Delete(path, recursive: true);
+            }
+        }
+        catch (IOException exception)
+        {
+            _logger.LogWarning(exception, "Failed to delete temporary preview directory {Directory}", path);
+        }
+        catch (UnauthorizedAccessException exception)
         {
-            Directory.Delete(path, recursive: true);
+            _logger.LogWarning(exception, "Failed to delete temporary preview directory {Directory}", path);
         }
     }
 

src/statichost/PreviewHost/Previews/PreviewStateStore.cs

@@ -508,7 +508,19 @@ private async Task SaveLockedAsync(CancellationToken cancellationToken)
     {
         Directory.CreateDirectory(StateRoot);
         var json = JsonSerializer.Serialize(_records, JsonOptions);
-        await File.WriteAllTextAsync(_registryPath, json, cancellationToken);
+        var registryDirectory = Path.GetDirectoryName(_registryPath) ?? StateRoot;
+        Directory.CreateDirectory(registryDirectory);
+
+        var tempFilePath = Path.Combine(registryDirectory, $"{Path.GetFileName(_registryPath)}.{Path.GetRandomFileName()}.tmp");
+        try
+        {
+            await File.WriteAllTextAsync(tempFilePath, json, cancellationToken);
+            File.Move(tempFilePath, _registryPath, overwrite: true);
+        }
+        finally
+        {
+            DeleteFileIfPresent(tempFilePath);
+        }
     }
 
     private bool NormalizeLoadedRecord(PreviewRecord record)
@@ -650,4 +662,23 @@ private void DeleteDirectoryIfPresent(string path)
             _logger.LogWarning(exception, "Failed to delete preview directory {Directory}", path);
         }
     }
+
+    private void DeleteFileIfPresent(string path)
+    {
+        try
+        {
+            if (File.Exists(path))
+            {
+                File.Delete(path);
+            }
+        }
+        catch (IOException exception)
+        {
+            _logger.LogWarning(exception, "Failed to delete preview file {Path}", path);
+        }
+        catch (UnauthorizedAccessException exception)
+        {
+            _logger.LogWarning(exception, "Failed to delete preview file {Path}", path);
+        }
+    }
 }

src/statichost/PreviewHost/Program.cs

@@ -283,6 +283,11 @@
             return Results.ValidationProblem(validationErrors);
         }
 
+        if (!TryValidateRepository(request, options.Value, out var repositoryValidationErrors))
+        {
+            return Results.ValidationProblem(repositoryValidationErrors);
+        }
+
         var result = await stateStore.RegisterAsync(request, cancellationToken);
         return Results.Json(new
         {
@@ -331,6 +336,24 @@ static bool TryValidate(PreviewRegistrationRequest request, out Dictionary<strin
     return false;
 }
 
+static bool TryValidateRepository(PreviewRegistrationRequest request, PreviewHostOptions options, out Dictionary<string, string[]> validationErrors)
+{
+    if (string.Equals(request.RepositoryOwner, options.RepositoryOwner, StringComparison.OrdinalIgnoreCase)
+        && string.Equals(request.RepositoryName, options.RepositoryName, StringComparison.OrdinalIgnoreCase))
+    {
+        validationErrors = [];
+        return true;
+    }
+
+    var repositoryMessage = $"Preview registrations must target the configured repository '{options.RepositoryOwner}/{options.RepositoryName}'.";
+    validationErrors = new Dictionary<string, string[]>(StringComparer.Ordinal)
+    {
+        [nameof(PreviewRegistrationRequest.RepositoryOwner)] = [repositoryMessage],
+        [nameof(PreviewRegistrationRequest.RepositoryName)] = [repositoryMessage]
+    };
+    return false;
+}
+
 static bool HasValidBearerToken(HttpRequest request, string expectedToken)
 {
     if (string.IsNullOrWhiteSpace(expectedToken))