Fix Python starter TypeScript health check build (#16625)

* Fix Python starter health check template

Update the Python starter TypeScript AppHost to use the supported withHttpHealthCheck options object and align its root build script with AppHost-only type checking. Add E2E coverage that verifies the generated starter builds successfully.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use fail-fast helper for Python starter build test

Update the Python React template E2E build verification to use the existing fail-fast command helper so npm build failures are surfaced immediately.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Verify TypeScript templates build

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Add build script aliases to TypeScript AppHost scaffold

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use AppHost tsconfig for TypeScript AppHost lint

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use AppHost tsconfig name for Python starter

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: sebastienros

src/Aspire.Cli/Templating/Templates/py-starter/apphost.ts

@@ -17,7 +17,7 @@ const app = await builder
     .withReference(cache)
     .waitFor(cache)
 // {{/redis}}
-    .withHttpHealthCheck("/health");
+    .withHttpHealthCheck({ path: "/health" });
 
 // Run the Vite frontend after the API and inject the API URL for local proxying.
 const frontend = await builder

src/Aspire.Cli/Templating/Templates/py-starter/eslint.config.mjs

@@ -8,7 +8,8 @@ export default defineConfig({
   extends: [tseslint.configs.base],
   languageOptions: {
     parserOptions: {
-      projectService: true,
+      project: './tsconfig.apphost.json',
+      tsconfigRootDir: import.meta.dirname,
     },
   },
   rules: {

src/Aspire.Cli/Templating/Templates/py-starter/package.json

@@ -3,12 +3,16 @@
   "private": true,
   "type": "module",
   "scripts": {
-    "lint": "eslint apphost.ts",
-    "predev": "npm run lint",
-    "dev": "aspire run",
-    "prebuild": "npm run lint",
-    "build": "tsc",
-    "watch": "tsc --watch"
+    "aspire:lint": "eslint apphost.ts",
+    "aspire:start": "aspire run",
+    "aspire:build": "tsc -p tsconfig.apphost.json",
+    "aspire:dev": "tsc --watch -p tsconfig.apphost.json",
+    "lint": "npm run aspire:lint",
+    "predev": "npm run aspire:lint",
+    "dev": "npm run aspire:start",
+    "prebuild": "npm run aspire:lint",
+    "build": "npm run aspire:build",
+    "watch": "npm run aspire:dev"
   },
   "dependencies": {
     "vscode-jsonrpc": "^8.2.0"

src/Aspire.Cli/Templating/Templates/py-starter/tsconfig.apphost.json

@@ -0,0 +1,15 @@
+{
+  "compilerOptions": {
+    "target": "ES2022",
+    "module": "NodeNext",
+    "moduleResolution": "NodeNext",
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "skipLibCheck": true,
+    "outDir": "./dist/apphost",
+    "rootDir": ".",
+    "strict": true
+  },
+  "include": ["apphost.ts", ".modules/**/*.ts"],
+  "exclude": ["node_modules"]
+}

src/Aspire.Cli/Templating/Templates/py-starter/tsconfig.json

@@ -8,7 +8,8 @@ export default defineConfig({
   extends: [tseslint.configs.base],
   languageOptions: {
     parserOptions: {
-      projectService: true,
+      project: './tsconfig.apphost.json',
+      tsconfigRootDir: import.meta.dirname,
     },
   },
   rules: {

src/Aspire.Cli/Templating/Templates/ts-starter/eslint.config.mjs

@@ -102,7 +102,8 @@ public Dictionary<string, string> Scaffold(ScaffoldRequest request)
               extends: [tseslint.configs.base],
               languageOptions: {
                 parserOptions: {
-                  projectService: true,
+                  project: './tsconfig.apphost.json',
+                  tsconfigRootDir: import.meta.dirname,
                 },
               },
               rules: {
@@ -148,7 +149,8 @@ private static string CreatePackageJson(ScaffoldRequest request)
         var packageJson = new JsonObject();
         var packageJsonPath = Path.Combine(request.TargetPath, PackageJsonFileName);
 
-        if (!File.Exists(packageJsonPath))
+        var isGreenfield = !File.Exists(packageJsonPath);
+        if (isGreenfield)
         {
             // Greenfield: include root metadata so the scaffold output is a complete package.json.
             var packageName = request.ProjectName?.ToLowerInvariant() ?? "aspire-apphost";
@@ -171,6 +173,16 @@ private static string CreatePackageJson(ScaffoldRequest request)
         scripts["aspire:build"] = $"tsc -p {AppHostTsConfigFileName}";
         scripts["aspire:dev"] = $"tsc --watch -p {AppHostTsConfigFileName}";
 
+        if (isGreenfield)
+        {
+            scripts["lint"] = "npm run aspire:lint";
+            scripts["predev"] = "npm run aspire:lint";
+            scripts["dev"] = "npm run aspire:start";
+            scripts["prebuild"] = "npm run aspire:lint";
+            scripts["build"] = "npm run aspire:build";
+            scripts["watch"] = "npm run aspire:dev";
+        }
+
         EnsureDependency(packageJson, "dependencies", "vscode-jsonrpc", "^8.2.0");
         EnsureDependency(packageJson, "devDependencies", "@types/node", "^22.0.0");
         EnsureDependency(packageJson, "devDependencies", "eslint", "^10.0.3");

src/Aspire.Hosting.CodeGeneration.TypeScript/TypeScriptLanguageSupport.cs

@@ -46,7 +46,10 @@ public async Task CreateAndRunPythonReactProject()
         await auto.EnterAsync();
         await auto.WaitForSuccessPromptAsync(counter);
 
-        // Step 3: Start and stop the project
+        // Step 3: Verify the generated TypeScript AppHost builds successfully.
+        await auto.RunCommandFailFastAsync("npm run build", counter, TimeSpan.FromMinutes(2));
+
+        // Step 4: Start and stop the project
         await auto.AspireStartAsync(counter);
         await auto.AspireStopAsync(counter);
 

tests/Aspire.Cli.EndToEnd.Tests/PythonReactTemplateTests.cs

@@ -44,6 +44,8 @@ public async Task CreateAndRunTypeScriptEmptyAppHostProject()
         await auto.EnterAsync();
         await auto.WaitForSuccessPromptAsync(counter);
 
+        await auto.RunCommandFailFastAsync("npm run build", counter, TimeSpan.FromMinutes(2));
+
         await auto.AspireStartAsync(counter);
         await auto.AspireStopAsync(counter);
 

tests/Aspire.Cli.EndToEnd.Tests/TypeScriptEmptyAppHostTemplateTests.cs

@@ -57,6 +57,8 @@ public async Task CreateAndRunTypeScriptStarterProject()
         await auto.EnterAsync();
         await auto.WaitForSuccessPromptAsync(counter);
 
+        await auto.RunCommandFailFastAsync("npm run build", counter, TimeSpan.FromMinutes(2));
+
         await auto.AspireStartAsync(counter);
         await auto.AspireStopAsync(counter);