Skip to content

[release/13.1] Make HTTPS developer certificate opt-in for Redis#14331

Open
github-actions[bot] wants to merge 3 commits into
release/13.1from
backport/pr-14306-to-release/13.1
Open

[release/13.1] Make HTTPS developer certificate opt-in for Redis#14331
github-actions[bot] wants to merge 3 commits into
release/13.1from
backport/pr-14306-to-release/13.1

Conversation

@github-actions

@github-actions github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor

Backport of #14306 to release/13.1

/cc @danegsta @copilot

Customer Impact

Testing

Risk

Regression?

Copilot AI and others added 3 commits February 4, 2026 05:28
… string timing issues

Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
Co-authored-by: danegsta <50252651+danegsta@users.noreply.github.com>
@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown
Contributor Author

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 14331

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 14331"

@IEvangelist

IEvangelist commented May 20, 2026

Copy link
Copy Markdown
Member

PR testing report

PR: #14331 - [release/13.1] Make HTTPS developer certificate opt-in for Redis
Base branch: release/13.1
Head commit: 59644330838b72b2674f5d43579d46f496bdb511
Result: Blocked - PR dogfood CLI artifact was unavailable

CLI version verification

The PR dogfood installer was invoked, but the expected Windows CLI artifact could not be downloaded from the workflow run referenced by the dogfood instructions. Because the PR CLI could not be installed, the CLI version could not be verified against the PR head commit and no scenarios were executed.

text Starting download and installation for PR #14331 Using workflow run https://github.com/microsoft/aspire/actions/runs/21659791485 Downloading CLI from GitHub - cli-native-archives-win-x64 ... INSTALL_FAILED: Error: Failed to download artifact 'cli-native-archives-win-x64' from run: 21659791485 . If the workflow is still running then the artifact named 'cli-native-archives-win-x64' may not be available yet. Check at https://github.com/microsoft/aspire/actions/runs/21659791485#artifacts

Changes analyzed

This PR changes Redis hosting behavior to opt out of HTTPS developer certificate setup by default:

  • src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs

Planned scenarios

These scenarios were selected based on the changed file, but were not executed because CLI installation failed first:

  1. Verify the installed PR dogfood Aspire CLI reports the PR head commit.
  2. Create a temp Aspire app with Redis and verify generated connection behavior no longer depends on HTTPS developer certificate setup by default.
  3. Verify an explicit HTTPS certificate opt-in path still works if available in the release branch API.

Overall: Not verified. Please rerun after the PR dogfood workflow publishes the expected cli-native-archives-win-x64 artifact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants