You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: contribution-guidelines-engineering.md
+14-1Lines changed: 14 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -28,7 +28,20 @@ This post provides some contribution guidelines for CSS/Scss in Atlas.
28
28
29
29
## When updating existing Scss
30
30
31
-
- try using [`npm link`](https://docs.npmjs.com/cli/v7/commands/npm-link) to view the impact on existing systems that import Atlas.
31
+
Try using [`npm link`](https://docs.npmjs.com/cli/v7/commands/npm-link) to view the impact on existing systems that import Atlas.
32
+
33
+
1. Checkout Atlas branch. Ex: xyz/feature-name
34
+
1.`cd ./css; npm link` This creates a symlink between your local repo and atlas-css npm package on your machine installed globally.
35
+
1. Checkout a branch in a downstream repo. Ex. xyz/feature-name-atlas
36
+
1.`cd ./package/using-atlas-css/; npm link @microsoft/atlas-css`. This will create a reference to the global package we just symlinked. Note that `/package/using-atlas-css/` is a fictional name for illustration only.
37
+
1. However! one more step is necessary I found ... go in and delete /package/using-atlas-css/node_modules/@microsoft/atlas-css folder.
38
+
1. If the above isn't working, you'll see a CSS build error related to the new usage of the layout css module.
39
+
1. After that, you should be good to run your start/build commands and visit an a page to test local atlas.
40
+
1. Depending on how your downstream repo is set up, you may need to retrigger builds/watchers or bust cache by making changes to css files if you're developing in tandem.
41
+
42
+
Maybe also do this:
43
+
44
+
1. Also tried removing package-lock and reinstalling,
0 commit comments