Redundant Debug Logging for ExecSync

[pbcahill]

Environment

azure-pipelines-task-lib version: 4.17.2

Issue Description

Whenever using the execSync function, and have system.debug enabled for the pipeline run, every piece of the command being output as a separate debug line twice:

That is the result from using execSync to run a curl command:

Expected behaviour

I would expect whatever command is being executed to be debug logged on a single line. Also none of the debug lines should be duplicated.

Would also be nice to have an option for execSync to not debug log the command at all. The existing silent option only masks the regular console output.

Actual behaviour

Each piece or argument of the command is output on a new debug line and duplicated. No way to alter this behavior or mask.

Logs

[ivanduplenskikh]

@pbcahill, appreciate the alert. I'll review the matter and respond promptly.

[ivanduplenskikh]

@pbcahill, I successfully replicated the problem using a custom script task that make a request to a URL via the curl utility.
The core of this problem lies is how CmdLine/Bash/Powershell tasks are designed.
They utilize a tool wrapper which add listener for debug output. Then they subsequently invoke call exec method, which does the same action.

CmdLineV2:
tool listener
exec listener

BashV3:
tool listener
exec listener

PowershellV2:
tool listener
exec listener

Both these wrappers add listeners
tool
exec

Additionally, I'd like to point out that the 'silently' property does not impact the debug output.

[KonstantinTyukalov]

@pbcahill thanks for pointing this out! It's fixed in newest patch, 4.17.3
I'm closing this bug, please let me know if you have any further questions.

[pbcahill]

Thank you @KonstantinTyukalov and @ivanduplenskikh for the very prompt responses and resolutions! I have tested the new version in my extensions and the duplicate debug log lines are no more.