Skip to content

Commit 0f049a9

Browse files
PhilipsonJosephPhilipsonJoseph
authored
20791 [REGRESSION]: HelmDeploy@1 and HelmDeploy@0 stopped working with environment (#20805)
1 parent 53d4935 commit 0f049a9

File tree

20 files changed

+44
-44
lines changed

20 files changed

+44
-44
lines changed

‎Tasks/HelmDeployV0/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎Tasks/HelmDeployV0/task.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],

‎Tasks/HelmDeployV0/task.loc.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],

‎Tasks/HelmDeployV1/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎Tasks/HelmDeployV1/task.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],

‎Tasks/HelmDeployV1/task.loc.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],

‎_generated/HelmDeployV0.versionmap.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Default|0.250.0
2-
Node20_229_3|0.250.1
1+
Default|0.252.0
2+
Node20_229_3|0.252.1

‎_generated/HelmDeployV0/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎_generated/HelmDeployV0/task.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],
@@ -561,8 +561,8 @@
561561
"KubeloginFailed": "Kubelogin authentication failed. Exception: %s"
562562
},
563563
"_buildConfigMapping": {
564-
"Default": "0.250.0",
564+
"Default": "0.252.0",
565565
"LocalPackages": "0.249.4",
566-
"Node20_229_3": "0.250.1"
566+
"Node20_229_3": "0.252.1"
567567
}
568568
}

‎_generated/HelmDeployV0/task.loc.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],
@@ -561,8 +561,8 @@
561561
"KubeloginFailed": "ms-resource:loc.messages.KubeloginFailed"
562562
},
563563
"_buildConfigMapping": {
564-
"Default": "0.250.0",
564+
"Default": "0.252.0",
565565
"LocalPackages": "0.249.4",
566-
"Node20_229_3": "0.250.1"
566+
"Node20_229_3": "0.252.1"
567567
}
568568
}

‎_generated/HelmDeployV0_Node20/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎_generated/HelmDeployV0_Node20/task.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 1
1818
},
1919
"demands": [],
@@ -573,8 +573,8 @@
573573
"KubeloginFailed": "Kubelogin authentication failed. Exception: %s"
574574
},
575575
"_buildConfigMapping": {
576-
"Default": "0.250.0",
576+
"Default": "0.252.0",
577577
"LocalPackages": "0.249.4",
578-
"Node20_229_3": "0.250.1"
578+
"Node20_229_3": "0.252.1"
579579
}
580580
}

‎_generated/HelmDeployV0_Node20/task.loc.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 0,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 1
1818
},
1919
"demands": [],
@@ -573,8 +573,8 @@
573573
"KubeloginFailed": "ms-resource:loc.messages.KubeloginFailed"
574574
},
575575
"_buildConfigMapping": {
576-
"Default": "0.250.0",
576+
"Default": "0.252.0",
577577
"LocalPackages": "0.249.4",
578-
"Node20_229_3": "0.250.1"
578+
"Node20_229_3": "0.252.1"
579579
}
580580
}

‎_generated/HelmDeployV1.versionmap.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Default|1.250.0
2-
Node20_229_3|1.250.1
1+
Default|1.252.0
2+
Node20_229_3|1.252.1

‎_generated/HelmDeployV1/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎_generated/HelmDeployV1/task.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],
@@ -561,8 +561,8 @@
561561
"KubeloginFailed": "Kubelogin authentication failed. Exception: %s"
562562
},
563563
"_buildConfigMapping": {
564-
"Default": "1.250.0",
564+
"Default": "1.252.0",
565565
"LocalPackages": "1.249.4",
566-
"Node20_229_3": "1.250.1"
566+
"Node20_229_3": "1.252.1"
567567
}
568568
}

‎_generated/HelmDeployV1/task.loc.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 0
1818
},
1919
"demands": [],
@@ -561,8 +561,8 @@
561561
"KubeloginFailed": "ms-resource:loc.messages.KubeloginFailed"
562562
},
563563
"_buildConfigMapping": {
564-
"Default": "1.250.0",
564+
"Default": "1.252.0",
565565
"LocalPackages": "1.249.4",
566-
"Node20_229_3": "1.250.1"
566+
"Node20_229_3": "1.252.1"
567567
}
568568
}

‎_generated/HelmDeployV1_Node20/src/helm.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ function isKubConfigLogoutRequired(command: string): boolean {
5252
// get kubeconfig file path
5353
async function getKubeConfigFile(): Promise<string> {
5454
const connectionType = tl.getInput("connectionType", true)
55+
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint");
5556
let result
56-
if (connectionType === "Azure Resource Manager") {
57+
if (connectionType === "Azure Resource Manager" && azureSubscriptionEndpoint) {
5758
const clusterName : string = tl.getInput("kubernetesCluster", true);
58-
const azureSubscriptionEndpoint : string = tl.getInput("azureSubscriptionEndpoint", true);
5959
const resourceGroup : string = tl.getInput("azureResourceGroup", true);
6060
const useClusterAdmin: boolean = tl.getBoolInput('useClusterAdmin');
6161
result = await getClusterType().getKubeConfig(azureSubscriptionEndpoint, resourceGroup, clusterName, useClusterAdmin)

‎_generated/HelmDeployV1_Node20/task.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 1
1818
},
1919
"demands": [],
@@ -573,8 +573,8 @@
573573
"KubeloginFailed": "Kubelogin authentication failed. Exception: %s"
574574
},
575575
"_buildConfigMapping": {
576-
"Default": "1.250.0",
576+
"Default": "1.252.0",
577577
"LocalPackages": "1.249.4",
578-
"Node20_229_3": "1.250.1"
578+
"Node20_229_3": "1.252.1"
579579
}
580580
}

‎_generated/HelmDeployV1_Node20/task.loc.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"author": "Microsoft Corporation",
1414
"version": {
1515
"Major": 1,
16-
"Minor": 250,
16+
"Minor": 252,
1717
"Patch": 1
1818
},
1919
"demands": [],
@@ -573,8 +573,8 @@
573573
"KubeloginFailed": "ms-resource:loc.messages.KubeloginFailed"
574574
},
575575
"_buildConfigMapping": {
576-
"Default": "1.250.0",
576+
"Default": "1.252.0",
577577
"LocalPackages": "1.249.4",
578-
"Node20_229_3": "1.250.1"
578+
"Node20_229_3": "1.252.1"
579579
}
580580
}

0 commit comments

Comments
 (0)