[Question]: The output of AzureFileCopy@5 task was changed, cx would like to know which version did this change

[jejass]

Task name

AzureFileCopy

Task version

5

Environment type (Please select at least one enviroment where you face this issue)

• Self-Hosted
• Microsoft Hosted
• VMSS Pool
• Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

No response

Operation system

Windows

Question

we have a yaml file use AzureFileCopy@5 task. then use the task's output StorageContainerUri and StorageContainerSasToken to next ARM template deploy task. In the ARM template, the output StorageContainerUri and StorageContainerSasToken will be used to construct url to access blobs (StorageContainerUri+StorageContainerSasToken). 

In the latest running, the ARM template task failed to access to blob due to shortage of '?' either in StorageContainerUri or StorageContainerSasToken. The constructed url is like below.

https://xx.blob.core.windows.net/xx/xx.jsonsv=2023-08-03&se=2024-01-08T07%3A13%3A55Z&sr=c&sp=rwdl&sig=***Sanitized Azure Storage Account Shared Access Signature

The correct one should be like below.
https://xx.blob.core.windows.net/xx/xx.json?sv=2023-08-03&se=2024-01-08T07%3A13%3A55Z&sr=c&sp=rwdl&sig=***Sanitized Azure Storage Account Shared Access Signature

The last successful run happened on 15th Nov, 2023 and it used below task version.

Task         : Azure file copy
Description  : Copy files to Azure Blob Storage or virtual machines
Version      : 5.230.0
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-file-copy

The failed run used below task version
Task         : Azure file copy
Description  : Copy files to Azure Blob Storage or virtual machines
Version      : 5.231.2
Author       : Microsoft Corporation
Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/deploy/azure-file-copy

It looks like the '?' mark was removed somewhere between this 2 version.

Please help to check which version did this change and whether the output StorageContainerSasToken without '?' mark is a permanent change.

[jejass]

I found that the task is using New-AzureStorageContainerSASToken to generate token. then https://www.powershellgallery.com/packages/Az.Storage/6.0.0, the '?' was removed from 6.0.0.

please kindly help to check if that is the cause and confirm which Az.Storage version that current task is using.

[Simon-Gregory-LG]

Just adding that this problem has just started happening (on Friday 22 March 2024) with the AzureFileCopy@4 task. The ? prefix is missing from the StorageContainerSasToken output parameter and this is breaking all ARM templates.

Can anybody confirm that this is a bug that will be fixed?

I can understand behaviour changing between versions, but something like this shouldn't just change for an existing version. I imagine this issue will have a very wide impact, as this task is usually used as the step before ARM Template execution to obtain the blob Sas Token - all of our ARM deployments are now completely broken.

[sloscialo]

Just adding that this problem has just started happening (on Friday 22 March 2024) with the AzureFileCopy@4 task. The ? prefix is missing from the StorageContainerSasToken output parameter and this is breaking all ARM templates.

Can anybody confirm that this is a bug that will be fixed?

I can understand behaviour changing between versions, but something like this shouldn't just change for an existing version. I imagine this issue will have a very wide impact, as this task is usually used as the step before ARM Template execution to obtain the blob Sas Token - all of our ARM deployments are now completely broken.

Yep, just been hit with this. All our pipelines are now broken.

[Simon-Gregory-LG]

I have also raised this as an issue in the Visual Studio Developer Community support page as recommended by the documentation.

[sloscialo]

Adding

${{ if startsWith(variables['AzureFileCopy.StorageContainerSasToken'], '?') }}:
  SasToken: $(AzureFileCopy.StorageContainerSasToken)
${{ else }}:
  SasToken: "?$(AzureFileCopy.StorageContainerSasToken)"

seems like a bit of a hack, but we can't trust the values coming from the AzureFileCopy task anymore.

EDIT:
I actually had to add the following task since variable manipulation couldn't happen where I wanted it to. So not a pure Yaml solution:

- task: PowerShell@2
  name: AzureFileCopyFix
  inputs: 
    targetType: 'inline'
    script: |
      $sasToken = "$(AzureFileCopy.StorageContainerSasToken)"
      if ($sasToken.StartsWith("?")) {
        Write-Host "##vso[task.setvariable variable=StorageContainerSasToken;isOutput=true]$sasToken"
      } else {
        Write-Host "##vso[task.setvariable variable=StorageContainerSasToken;isOutput=true]?$sasToken"
      }

Then I had to use $(AzureFileCopyFix.StorageContainerSasToken) wherever I needed the token.