Skip to content

Options should merge recursively #1007

Open
@ecraig12345

Description

getOptions and getCombinedPackageOptions should be recursively merging object properties instead of overwriting them (arrays should still be overwritten).

Code from a previous attempt before realizing the issue applied to getOptions too: https://github.com/microsoft/beachball/tree/ecraig/object-merge

I'm marking this as a breaking change because it's entirely possible that some repos have configs that either expect or manually work around the non-recursive merging behavior, so it's safest to only change this with an explicit call-out in a major release.

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions