Skip to content

Commit 40edcbf

Browse files
robinvdvleutenStevenic
authored andcommitted
Return error response on invalid json (#3673)
1 parent 63452f8 commit 40edcbf

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

Node/core/src/bots/ChatConnector.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,15 @@ export class ChatConnector implements IConnector, IBotStorage {
132132
requestData += chunk
133133
});
134134
req.on('end', () => {
135-
req.body = JSON.parse(requestData);
135+
try {
136+
req.body = JSON.parse(requestData);
137+
} catch (err) {
138+
logger.error('ChatConnector: receive - invalid request data received.');
139+
res.send(400);
140+
res.end();
141+
return;
142+
}
143+
136144
this.verifyBotFramework(req, res, next || defaultNext);
137145
});
138146
}

0 commit comments

Comments
 (0)