Updated passing of the localizerSettings info to the default localizer.

Author: Stevenic

Node/core/src/DefaultLocalizer.ts

@@ -44,10 +44,7 @@ export class DefaultLocalizer implements ILocalizer {
     private static filesParsedMap: any = {};
     private static map: any = {};
 
-    constructor() {        
-    }
-
-    initialize(settings: ILocalizerSettings = {}) {
+    constructor(settings: IDefaultLocalizerSettings = {}) {        
         if (settings.botLocalePath) {
             this.botLocalePath = settings.botLocalePath.toLowerCase();
             if (this.botLocalePath.charAt(this.botLocalePath.length - 1) != '/') {

Node/core/src/Session.ts

@@ -51,7 +51,7 @@ export interface ISessionOptions {
     dialogId: string;
     dialogArgs?: any;
     localizer?: ILocalizer;
-    localizerSettings?: ILocalizerSettings;
+    localizerSettings?: IDefaultLocalizerSettings;
     autoBatchDelay?: number;
     dialogErrorMessage?: string|string[]|IMessage|IIsMessage;
     actions?: actions.ActionSet;
@@ -77,11 +77,10 @@ export class Session extends events.EventEmitter implements ISession {
         this.library = options.library;
 
         if (!options.localizer) {
-            this.localizer = new dfLoc.DefaultLocalizer();           
+            this.localizer = new dfLoc.DefaultLocalizer(options.localizerSettings);           
         } else {
             this.localizer = options.localizer;
         }
-        this.localizer.initialize(options.localizerSettings);
 
         if (typeof this.options.autoBatchDelay !== 'number') {
             this.options.autoBatchDelay = 250;  // 250ms delay

Node/core/src/botbuilder.d.ts

@@ -310,7 +310,8 @@ export interface IIsFact {
     toFact(): IFact;
 }
 
-interface ILocalizerSettings {
+/** Settings used to initialize an ILocalizer implementation. */
+interface IDefaultLocalizerSettings {
     /** The path to the parent of the bot's locale directory  */
     botLocalePath?: string;
 
@@ -320,12 +321,6 @@ interface ILocalizerSettings {
 
 /** Plugin for localizing messages sent to the user by a bot. */
 export interface ILocalizer {
-    /**
-     * Intitializes the localizer.
-     * @param localizerSettings (Optional) settings to supply to the localizer.
-     */
-    initialize(localizerSettings?: ILocalizerSettings): void;
-    
     /**
      * Loads the localied table for the supplied locale, and call's the supplied callback once the load is complete.
      * @param locale The locale to load.
@@ -741,9 +736,12 @@ export interface IUniversalBotSettings {
     /** (Optional) arguments to pass to the initial dialog for a conversation. */
     defaultDialogArgs?: any;
 
-    /** (Optional) localizer used to localize the bots responses to the user. */
+    /** (Optional) cutstom localizer used to localize the bots responses to the user. */
     localizer?: ILocalizer;
 
+    /** (Optional) settings used to configure the frameworks built in default localizer. */
+    localizerSettings?: IDefaultLocalizerSettings;
+
     /** (Optional) function used to map the user ID for an incoming message to another user ID.  This can be used to implement user account linking. */
     lookupUser?: (address: IAddress, done: (err: Error, user: IIdentity) => void) => void;
 

Node/core/src/bots/UniversalBot.ts

@@ -48,7 +48,7 @@ export interface IUniversalBotSettings {
     defaultDialogId?: string;
     defaultDialogArgs?: any;
     localizer?: ILocalizer;
-    localizerSettings?: ILocalizerSettings;    
+    localizerSettings?: IDefaultLocalizerSettings;    
     lookupUser?: ILookupUser;
     processLimit?: number;
     autoBatchDelay?: number;

Node/core/src/interfaces.d.ts

@@ -163,15 +163,14 @@ interface ILocationV2 {
 }
 
 interface ILocalizer {
-    initialize(localizerSettings?: ILocalizerSettings): void;
     load(locale: string, callback?: ErrorCallback): void;     
     defaultLocale(locale?: string): string   
     gettext(locale: string, msgid: string, namespace?: string): string;
     trygettext(locale: string, msgid: string, namespace?: string): string;
     ngettext(locale: string, msgid: string, msgid_plural: string, count: number, namespace?: string): string;
 }
 
-interface ILocalizerSettings {
+interface IDefaultLocalizerSettings {
     botLocalePath?: string;
     defaultLocale?: string;
 }