Skip to content

Commit b14bdb3

Browse files
committed
Merge branch 'master' of https://github.com/Microsoft/BotBuilder
2 parents e6719bc + eaa8592 commit b14bdb3

File tree

3 files changed

+17
-1
lines changed

3 files changed

+17
-1
lines changed

CSharp/Library/FormFlow/FormDialog.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,9 @@ async Task IDialog<T>.StartAsync(IDialogContext context)
251251
&& step.Field.IsNullable)
252252
{
253253
var val = step.Field.GetValue(_state);
254-
if (step.Field.ValidateAsync(_state, val).Result.IsValid)
254+
255+
var validationResult = await step.Field.ValidateAsync(_state, val);
256+
if (validationResult.IsValid)
255257
{
256258
bool ok = true;
257259
double min, max;

CSharp/Tests/Microsoft.Bot.Builder.Tests/PromptTests.cs

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -119,12 +119,24 @@ public async Task PromptSuccess_Confirm_Yes()
119119
await PromptSuccessAsync((context, resume) => PromptDialog.Confirm(context, resume, PromptText), "yes", true);
120120
}
121121

122+
[TestMethod]
123+
public async Task PromptSuccess_Confirm_Yes_CaseInsensitive()
124+
{
125+
await PromptSuccessAsync((context, resume) => PromptDialog.Confirm(context, resume, PromptText), "Yes", true);
126+
}
127+
122128
[TestMethod]
123129
public async Task PromptSuccess_Confirm_No()
124130
{
125131
await PromptSuccessAsync((context, resume) => PromptDialog.Confirm(context, resume, PromptText), "no", false);
126132
}
127133

134+
[TestMethod]
135+
public async Task PromptSuccess_Confirm_No_CaseInsensitive()
136+
{
137+
await PromptSuccessAsync((context, resume) => PromptDialog.Confirm(context, resume, PromptText), "No", false);
138+
}
139+
128140
[TestMethod]
129141
public async Task PromptSuccess_Number_Long()
130142
{

README.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,3 +9,5 @@ The Microsoft Bot Framework provides just what you need to build and connect int
99
Bots (or conversation agents) are rapidly becoming an integral part of one’s digital experience – they are as vital a way for users to interact with a service or application as is a web site or a mobile experience. Developers writing bots all face the same problems: bots require basic I/O; they must have language and dialog skills; and they must connect to users – preferably in any conversation experience and language the user chooses. The Bot Framework provides tools to easily solve these problems and more for developers e.g., automatic translation to more than 30 languages, user and conversation state management, debugging tools, an embeddable web chat control and a way for users to discover, try, and add bots to the conversation experiences they love.
1010

1111
**[Review the documentation](http://docs.botframework.com)** to get started with the Bot Builder SDK!
12+
13+
Join the conversation on Gitter : https://gitter.im/Microsoft/BotBuilder

0 commit comments

Comments
 (0)