Skip to content

Commit 5795d16

Browse files
aaronbellaaronbell
authored
Fix the typo metrics and hhea, set line gap to 0 (#261)
This change modifies the font vertical metrics for better consistency cross-platform. Block drawing characters adjusted to account for new metrics. - Font metrics updated following the method used by Google Fonts[1] - Block drawing characters also modified to account for the changed metrics and ensure overlaps in vertical lines. - Other Glyphs specific code removed from the UFO. Updated font reviewed in various coding environments, and hinting verified as not impacted. [1]: https://github.com/googlefonts/gf-docs/tree/master/Spec#cjk-vertical-metrics
1 parent 4bd34ed commit 5795d16

File tree

177 files changed

+1650
-1757
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

177 files changed

+1650
-1757
lines changed

‎FONTLOG.txt

+2
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ ChangeLog
3333
04-29-2020 (Aaronn Bell) April bug fixes
3434
- Many small bug fixes from the last few months
3535

36+
05-05-2020 Font vertical metrics locked
37+
3638
Acknowledgements
3739
-----------------------------------
3840

‎build.py

+11
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,17 @@ def build_font_instance(generator, instance_descriptor, *steps):
5454

5555
instance.info.openTypeOS2Panose = [2, 11, 6, 9, 2, 0, 0, 2, 0, 4]
5656

57+
instance.info.openTypeOS2TypoAscender = 1900
58+
instance.info.openTypeOS2TypoDescender = -480
59+
instance.info.openTypeOS2TypoLineGap = 0
60+
61+
instance.info.openTypeHheaAscender = instance.info.openTypeOS2TypoAscender
62+
instance.info.openTypeHheaDescender = instance.info.openTypeOS2TypoDescender
63+
instance.info.openTypeHheaLineGap = instance.info.openTypeOS2TypoLineGap
64+
65+
instance.info.openTypeOS2WinAscent = 2226
66+
instance.info.openTypeOS2WinDescent = 770
67+
5768
if format == "ttf":
5869
instance.info.openTypeGaspRangeRecords =[
5970
{

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleD_ownA_ndH_orizontal.glif

+16-16
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,26 @@
44
<unicode hex="2566"/>
55
<outline>
66
<contour>
7-
<point x="706" y="-750" type="line"/>
8-
<point x="918" y="-750" type="line"/>
9-
<point x="918" y="211" type="line"/>
10-
<point x="1306" y="211" type="line"/>
11-
<point x="1306" y="423" type="line"/>
12-
<point x="706" y="423" type="line"/>
7+
<point x="706" y="-1070" type="line"/>
8+
<point x="918" y="-1070" type="line"/>
9+
<point x="918" y="212" type="line"/>
10+
<point x="1306" y="212" type="line"/>
11+
<point x="1306" y="424" type="line"/>
12+
<point x="706" y="424" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="282" y="-750" type="line"/>
16-
<point x="494" y="-750" type="line"/>
17-
<point x="494" y="423" type="line"/>
18-
<point x="-106" y="423" type="line"/>
19-
<point x="-106" y="211" type="line"/>
20-
<point x="282" y="211" type="line"/>
15+
<point x="282" y="-1070" type="line"/>
16+
<point x="494" y="-1070" type="line"/>
17+
<point x="494" y="424" type="line"/>
18+
<point x="-106" y="424" type="line"/>
19+
<point x="-106" y="212" type="line"/>
20+
<point x="282" y="212" type="line"/>
2121
</contour>
2222
<contour>
23-
<point x="-106" y="635" type="line"/>
24-
<point x="1306" y="635" type="line"/>
25-
<point x="1306" y="847" type="line"/>
26-
<point x="-106" y="847" type="line"/>
23+
<point x="-106" y="636" type="line"/>
24+
<point x="1306" y="636" type="line"/>
25+
<point x="1306" y="848" type="line"/>
26+
<point x="-106" y="848" type="line"/>
2727
</contour>
2828
</outline>
2929
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleD_ownA_ndL_eft.glif

+12-12
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
<unicode hex="2557"/>
55
<outline>
66
<contour>
7-
<point x="706" y="-750" type="line"/>
8-
<point x="918" y="-750" type="line"/>
9-
<point x="918" y="847" type="line"/>
10-
<point x="-106" y="847" type="line"/>
11-
<point x="-106" y="635" type="line"/>
12-
<point x="706" y="635" type="line"/>
7+
<point x="706" y="-1070" type="line"/>
8+
<point x="918" y="-1070" type="line"/>
9+
<point x="918" y="848" type="line"/>
10+
<point x="-106" y="848" type="line"/>
11+
<point x="-106" y="636" type="line"/>
12+
<point x="706" y="636" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="282" y="-750" type="line"/>
16-
<point x="494" y="-750" type="line"/>
17-
<point x="494" y="423" type="line"/>
18-
<point x="-106" y="423" type="line"/>
19-
<point x="-106" y="211" type="line"/>
20-
<point x="282" y="211" type="line"/>
15+
<point x="282" y="-1070" type="line"/>
16+
<point x="494" y="-1070" type="line"/>
17+
<point x="494" y="424" type="line"/>
18+
<point x="-106" y="424" type="line"/>
19+
<point x="-106" y="212" type="line"/>
20+
<point x="282" y="212" type="line"/>
2121
</contour>
2222
</outline>
2323
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleD_ownA_ndR_ight.glif

+12-12
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
<unicode hex="2554"/>
55
<outline>
66
<contour>
7-
<point x="282" y="-750" type="line"/>
8-
<point x="494" y="-750" type="line"/>
9-
<point x="494" y="635" type="line"/>
10-
<point x="1306" y="635" type="line"/>
11-
<point x="1306" y="847" type="line"/>
12-
<point x="282" y="847" type="line"/>
7+
<point x="282" y="-1070" type="line"/>
8+
<point x="494" y="-1070" type="line"/>
9+
<point x="494" y="636" type="line"/>
10+
<point x="1306" y="636" type="line"/>
11+
<point x="1306" y="848" type="line"/>
12+
<point x="282" y="848" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="706" y="-750" type="line"/>
16-
<point x="918" y="-750" type="line"/>
17-
<point x="918" y="211" type="line"/>
18-
<point x="1306" y="211" type="line"/>
19-
<point x="1306" y="423" type="line"/>
20-
<point x="706" y="423" type="line"/>
15+
<point x="706" y="-1070" type="line"/>
16+
<point x="918" y="-1070" type="line"/>
17+
<point x="918" y="212" type="line"/>
18+
<point x="1306" y="212" type="line"/>
19+
<point x="1306" y="424" type="line"/>
20+
<point x="706" y="424" type="line"/>
2121
</contour>
2222
</outline>
2323
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleH_orizontal.glif

+8-8
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
<unicode hex="2550"/>
55
<outline>
66
<contour>
7-
<point x="-106" y="635" type="line"/>
8-
<point x="1306" y="635" type="line"/>
9-
<point x="1306" y="847" type="line"/>
10-
<point x="-106" y="847" type="line"/>
7+
<point x="-106" y="636" type="line"/>
8+
<point x="1306" y="636" type="line"/>
9+
<point x="1306" y="848" type="line"/>
10+
<point x="-106" y="848" type="line"/>
1111
</contour>
1212
<contour>
13-
<point x="-106" y="211" type="line"/>
14-
<point x="1306" y="211" type="line"/>
15-
<point x="1306" y="423" type="line"/>
16-
<point x="-106" y="423" type="line"/>
13+
<point x="-106" y="212" type="line"/>
14+
<point x="1306" y="212" type="line"/>
15+
<point x="1306" y="424" type="line"/>
16+
<point x="-106" y="424" type="line"/>
1717
</contour>
1818
</outline>
1919
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleU_pA_ndH_orizontal.glif

+16-16
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,26 @@
44
<unicode hex="2569"/>
55
<outline>
66
<contour>
7-
<point x="706" y="635" type="line"/>
8-
<point x="1306" y="635" type="line"/>
9-
<point x="1306" y="847" type="line"/>
10-
<point x="918" y="847" type="line"/>
11-
<point x="918" y="1808" type="line"/>
12-
<point x="706" y="1808" type="line"/>
7+
<point x="706" y="636" type="line"/>
8+
<point x="1306" y="636" type="line"/>
9+
<point x="1306" y="848" type="line"/>
10+
<point x="918" y="848" type="line"/>
11+
<point x="918" y="2130" type="line"/>
12+
<point x="706" y="2130" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="-106" y="211" type="line"/>
16-
<point x="1306" y="211" type="line"/>
17-
<point x="1306" y="423" type="line"/>
18-
<point x="-106" y="423" type="line"/>
15+
<point x="-106" y="212" type="line"/>
16+
<point x="1306" y="212" type="line"/>
17+
<point x="1306" y="424" type="line"/>
18+
<point x="-106" y="424" type="line"/>
1919
</contour>
2020
<contour>
21-
<point x="-106" y="635" type="line"/>
22-
<point x="494" y="635" type="line"/>
23-
<point x="494" y="1808" type="line"/>
24-
<point x="282" y="1808" type="line"/>
25-
<point x="282" y="847" type="line"/>
26-
<point x="-106" y="847" type="line"/>
21+
<point x="-106" y="636" type="line"/>
22+
<point x="494" y="636" type="line"/>
23+
<point x="494" y="2130" type="line"/>
24+
<point x="282" y="2130" type="line"/>
25+
<point x="282" y="848" type="line"/>
26+
<point x="-106" y="848" type="line"/>
2727
</contour>
2828
</outline>
2929
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleU_pA_ndL_eft.glif

+12-12
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
<unicode hex="255D"/>
55
<outline>
66
<contour>
7-
<point x="-106" y="211" type="line"/>
8-
<point x="918" y="211" type="line"/>
9-
<point x="918" y="1808" type="line"/>
10-
<point x="706" y="1808" type="line"/>
11-
<point x="706" y="423" type="line"/>
12-
<point x="-106" y="423" type="line"/>
7+
<point x="-106" y="212" type="line"/>
8+
<point x="918" y="212" type="line"/>
9+
<point x="918" y="2130" type="line"/>
10+
<point x="706" y="2130" type="line"/>
11+
<point x="706" y="424" type="line"/>
12+
<point x="-106" y="424" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="-106" y="635" type="line"/>
16-
<point x="494" y="635" type="line"/>
17-
<point x="494" y="1808" type="line"/>
18-
<point x="282" y="1808" type="line"/>
19-
<point x="282" y="847" type="line"/>
20-
<point x="-106" y="847" type="line"/>
15+
<point x="-106" y="636" type="line"/>
16+
<point x="494" y="636" type="line"/>
17+
<point x="494" y="2130" type="line"/>
18+
<point x="282" y="2130" type="line"/>
19+
<point x="282" y="848" type="line"/>
20+
<point x="-106" y="848" type="line"/>
2121
</contour>
2222
</outline>
2323
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleU_pA_ndR_ight.glif

+12-12
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,20 @@
44
<unicode hex="255A"/>
55
<outline>
66
<contour>
7-
<point x="282" y="211" type="line"/>
8-
<point x="1306" y="211" type="line"/>
9-
<point x="1306" y="423" type="line"/>
10-
<point x="494" y="423" type="line"/>
11-
<point x="494" y="1808" type="line"/>
12-
<point x="282" y="1808" type="line"/>
7+
<point x="282" y="212" type="line"/>
8+
<point x="1306" y="212" type="line"/>
9+
<point x="1306" y="424" type="line"/>
10+
<point x="494" y="424" type="line"/>
11+
<point x="494" y="2130" type="line"/>
12+
<point x="282" y="2130" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="706" y="635" type="line"/>
16-
<point x="1306" y="635" type="line"/>
17-
<point x="1306" y="847" type="line"/>
18-
<point x="918" y="847" type="line"/>
19-
<point x="918" y="1808" type="line"/>
20-
<point x="706" y="1808" type="line"/>
15+
<point x="706" y="636" type="line"/>
16+
<point x="1306" y="636" type="line"/>
17+
<point x="1306" y="848" type="line"/>
18+
<point x="918" y="848" type="line"/>
19+
<point x="918" y="2130" type="line"/>
20+
<point x="706" y="2130" type="line"/>
2121
</contour>
2222
</outline>
2323
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleV_ertical.glif

+8-8
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,16 @@
44
<unicode hex="2551"/>
55
<outline>
66
<contour>
7-
<point x="706" y="-750" type="line"/>
8-
<point x="918" y="-750" type="line"/>
9-
<point x="918" y="1808" type="line"/>
10-
<point x="706" y="1808" type="line"/>
7+
<point x="706" y="-1070" type="line"/>
8+
<point x="918" y="-1070" type="line"/>
9+
<point x="918" y="2130" type="line"/>
10+
<point x="706" y="2130" type="line"/>
1111
</contour>
1212
<contour>
13-
<point x="282" y="-750" type="line"/>
14-
<point x="494" y="-750" type="line"/>
15-
<point x="494" y="1808" type="line"/>
16-
<point x="282" y="1808" type="line"/>
13+
<point x="282" y="-1070" type="line"/>
14+
<point x="494" y="-1070" type="line"/>
15+
<point x="494" y="2130" type="line"/>
16+
<point x="282" y="2130" type="line"/>
1717
</contour>
1818
</outline>
1919
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleV_erticalA_ndH_orizontal.glif

+24-24
Original file line numberDiff line numberDiff line change
@@ -4,36 +4,36 @@
44
<unicode hex="256C"/>
55
<outline>
66
<contour>
7-
<point x="706" y="635" type="line"/>
8-
<point x="1306" y="635" type="line"/>
9-
<point x="1306" y="847" type="line"/>
10-
<point x="918" y="847" type="line"/>
11-
<point x="918" y="1808" type="line"/>
12-
<point x="706" y="1808" type="line"/>
7+
<point x="706" y="636" type="line"/>
8+
<point x="1306" y="636" type="line"/>
9+
<point x="1306" y="848" type="line"/>
10+
<point x="918" y="848" type="line"/>
11+
<point x="918" y="2130" type="line"/>
12+
<point x="706" y="2130" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="282" y="-750" type="line"/>
16-
<point x="494" y="-750" type="line"/>
17-
<point x="494" y="423" type="line"/>
18-
<point x="-106" y="423" type="line"/>
19-
<point x="-106" y="211" type="line"/>
20-
<point x="282" y="211" type="line"/>
15+
<point x="282" y="-1070" type="line"/>
16+
<point x="494" y="-1070" type="line"/>
17+
<point x="494" y="424" type="line"/>
18+
<point x="-106" y="424" type="line"/>
19+
<point x="-106" y="212" type="line"/>
20+
<point x="282" y="212" type="line"/>
2121
</contour>
2222
<contour>
23-
<point x="706" y="-750" type="line"/>
24-
<point x="918" y="-750" type="line"/>
25-
<point x="918" y="211" type="line"/>
26-
<point x="1306" y="211" type="line"/>
27-
<point x="1306" y="423" type="line"/>
28-
<point x="706" y="423" type="line"/>
23+
<point x="706" y="-1070" type="line"/>
24+
<point x="918" y="-1070" type="line"/>
25+
<point x="918" y="212" type="line"/>
26+
<point x="1306" y="212" type="line"/>
27+
<point x="1306" y="424" type="line"/>
28+
<point x="706" y="424" type="line"/>
2929
</contour>
3030
<contour>
31-
<point x="-106" y="635" type="line"/>
32-
<point x="494" y="635" type="line"/>
33-
<point x="494" y="1808" type="line"/>
34-
<point x="282" y="1808" type="line"/>
35-
<point x="282" y="847" type="line"/>
36-
<point x="-106" y="847" type="line"/>
31+
<point x="-106" y="636" type="line"/>
32+
<point x="494" y="636" type="line"/>
33+
<point x="494" y="2130" type="line"/>
34+
<point x="282" y="2130" type="line"/>
35+
<point x="282" y="848" type="line"/>
36+
<point x="-106" y="848" type="line"/>
3737
</contour>
3838
</outline>
3939
</glyph>

‎sources/CascadiaCode-Regular.ufo/glyphs/boxD_oubleV_erticalA_ndL_eft.glif

+16-16
Original file line numberDiff line numberDiff line change
@@ -4,26 +4,26 @@
44
<unicode hex="2563"/>
55
<outline>
66
<contour>
7-
<point x="-106" y="635" type="line"/>
8-
<point x="494" y="635" type="line"/>
9-
<point x="494" y="1808" type="line"/>
10-
<point x="282" y="1808" type="line"/>
11-
<point x="282" y="847" type="line"/>
12-
<point x="-106" y="847" type="line"/>
7+
<point x="-106" y="636" type="line"/>
8+
<point x="494" y="636" type="line"/>
9+
<point x="494" y="2130" type="line"/>
10+
<point x="282" y="2130" type="line"/>
11+
<point x="282" y="848" type="line"/>
12+
<point x="-106" y="848" type="line"/>
1313
</contour>
1414
<contour>
15-
<point x="282" y="-750" type="line"/>
16-
<point x="494" y="-750" type="line"/>
17-
<point x="494" y="423" type="line"/>
18-
<point x="-106" y="423" type="line"/>
19-
<point x="-106" y="211" type="line"/>
20-
<point x="282" y="211" type="line"/>
15+
<point x="282" y="-1070" type="line"/>
16+
<point x="494" y="-1070" type="line"/>
17+
<point x="494" y="424" type="line"/>
18+
<point x="-106" y="424" type="line"/>
19+
<point x="-106" y="212" type="line"/>
20+
<point x="282" y="212" type="line"/>
2121
</contour>
2222
<contour>
23-
<point x="706" y="-750" type="line"/>
24-
<point x="918" y="-750" type="line"/>
25-
<point x="918" y="1808" type="line"/>
26-
<point x="706" y="1808" type="line"/>
23+
<point x="706" y="-1070" type="line"/>
24+
<point x="918" y="-1070" type="line"/>
25+
<point x="918" y="2130" type="line"/>
26+
<point x="706" y="2130" type="line"/>
2727
</contour>
2828
</outline>
2929
</glyph>

0 commit comments

Comments
 (0)