Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path rebasing on linux #1375

Merged
merged 2 commits into from
Mar 20, 2025
Merged

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Mar 20, 2025

The assets file always included a trailing separator, whereas the output of GetDirectoryName did not. This was causing rebasing to fail to find a matching replacement path.

Most of this change is just improving some comments. The fix is to switch from pathUtilityService.NormalizePath to NormalizeDirectory which also trims trailing separators.

The assets file always included a trailing separator, whereas the output of GetDirectoryName did not.  This was causing rebasing to fail to find a matching replacement path.
@ericstj ericstj requested a review from grvillic March 20, 2025 20:21
@ericstj ericstj requested a review from a team as a code owner March 20, 2025 20:21
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.6%. Comparing base (6f2cda9) to head (f97eb56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ection.Detectors/dotnet/DotNetComponentDetector.cs 87.5% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1375   +/-   ##
=====================================
  Coverage   89.6%   89.6%           
=====================================
  Files        402     402           
  Lines      31712   31717    +5     
  Branches    1956    1957    +1     
=====================================
+ Hits       28442   28447    +5     
  Misses      2853    2853           
  Partials     417     417           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@grvillic grvillic enabled auto-merge (squash) March 20, 2025 21:12
@grvillic grvillic merged commit 02bf0dd into microsoft:main Mar 20, 2025
21 of 22 checks passed
Copy link

github-actions bot commented Mar 20, 2025

👋 Hi! It looks like you modified some files in the Detectors folder.
You may need to bump the detector versions if any of the following scenarios apply:

  • The detector detects more or fewer components than before
  • The detector generates different parent/child graph relationships than before
  • The detector generates different devDependencies values than before

If none of the above scenarios apply, feel free to ignore this comment 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants