workspace Folder

[FlorianPydde]

When notebook or src folder in a new container, should we also change the workspaceFolder in the devcontainer.json config when setting up the project?

Currently it's set to: "workspaceFolder": "/workspaces/dstoolkit-devcontainers)/notebooks"

[fujikosu]

@FlorianPydde Yes that part needs to be updated. You can check this section of README.md regarding how you need to change it. https://github.com/microsoft/dstoolkit-devcontainers#how-to-create-a-new-directory-under-src-with-a-new-environment

I just merged new readme.md and new devcontainers version that has no dependency on docker-compose anymore with this #13 so you might have missed the update to README.md there.

[FlorianPydde]

Fair enough. Since I was starting some EDA I was only looking at the notebook folder not the src one. Should we always copy the example folder in src as starting point ?

[fujikosu]

If you want to use it only for EDA, you can stick with notebooks directory. If you want to start writing something for more serious experimentation or production code, I'd suggest to use to src.
That topic is covered in this section of readme so I'd suggest you to take a look at this section first.
https://github.com/microsoft/dstoolkit-devcontainers#notebooks-directory-vs-src-directory

[FlorianPydde]

Yes, that's what I tried to do, i.e. simply use the notebook folder. But that's when I saw that devcontainer.json "workspaceFolder" key had to be updated, and this is not mentioned in the documentation.

[fujikosu]

You don't need to update workspaceFolder key when you use notebooks directory.

the latest main got this below

    "workspaceFolder": "/workspaces/dstoolkit-devcontainers/notebooks",

and this should work out of the box. Build succeeded on my local and succeeded on David's local too during his PR review.

1. What specific issue are you getting?
2. Are you using the latest main? If not, I'd suggest you to pull in the latest main to your local and run the command DevContainers: Rebuild Container Without Cache