Skip to content

Commit 547e52d

Browse files
committed
Harden Azurite startup handling
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61acbc5e-7c07-42a7-8e38-31329c4befce
1 parent 1f3121d commit 547e52d

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

noxfile.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,10 @@
33

44
"""Nox sessions that mirror the repository's GitHub Actions validation.
55
6-
Run ``nox -s ci`` to run every CI-equivalent check. Use a focused session while
7-
developing (for example, ``nox -s lint`` or ``nox -s core_tests-3.10``).
8-
The test sessions provision their required emulators when possible.
6+
Run ``nox -s ci`` for a representative local validation sweep. Use a focused
7+
session while developing (for example, ``nox -s lint`` or
8+
``nox -s core_tests-3.10``). The test sessions provision their required
9+
emulators when possible.
910
1011
Usage:
1112
@@ -121,7 +122,7 @@ def _start_azurite(
121122
session: nox.Session,
122123
ports: Sequence[int],
123124
arguments: Sequence[str],
124-
) -> subprocess.Popen[str] | None:
125+
) -> subprocess.Popen[bytes] | None:
125126
"""Start Azurite unless another local instance already owns its ports."""
126127
open_ports = [port for port in ports if _is_port_open(port)]
127128
if len(open_ports) == len(ports):
@@ -161,13 +162,14 @@ def _start_azurite(
161162
session.log("Started Azurite for this session.")
162163
return process
163164

164-
process.terminate()
165+
if process.poll() is None:
166+
process.terminate()
165167
process.wait()
166168
session.error("Azurite did not become ready within 30 seconds.")
167169
return None
168170

169171

170-
def _stop_process(process: subprocess.Popen[str] | None) -> None:
172+
def _stop_process(process: subprocess.Popen[bytes] | None) -> None:
171173
"""Stop a service process that this Nox session started."""
172174
if process is not None and process.poll() is None:
173175
process.terminate()

0 commit comments

Comments
 (0)