Address v1 status review feedback

Expose failed orchestration messages through the compatibility output property, reuse that projection in JSON output, clarify the shim documentation, and strengthen delegation assertions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: ff9faf2d-e79a-4309-8a67-5d455e4dd7bd

Author: andystaples

azure-functions-durable/azure/durable_functions/client.py

@@ -266,8 +266,9 @@ async def get_status(
 
         The ``show_history`` and ``show_history_output`` flags have no
         equivalent in durabletask and are ignored. Payloads are fetched to
-        preserve the v1 output and custom-status fields; ``show_input`` controls
-        whether the compatibility wrapper exposes the input.
+        preserve the v1 output, custom-status, and failure-detail fields;
+        ``show_input`` controls whether the compatibility wrapper exposes the
+        input.
         """
         state = await self.get_orchestration_state(instance_id, fetch_payloads=True)
         return DurableOrchestrationStatus.from_orchestration_state(

azure-functions-durable/azure/durable_functions/internal/compat/durable_orchestration_status.py

@@ -116,10 +116,14 @@ def input_(self) -> Any:
 
     @property
     def output(self) -> Any:
-        """Get the (deserialized) output of the orchestration instance."""
+        """Get the output or failure message of the orchestration instance."""
         if self._state is None:
             return None
-        return self._raw_payload(self._state.serialized_output)
+        output = self._raw_payload(self._state.serialized_output)
+        if output is not None:
+            return output
+        failure = self._state.failure_details
+        return failure.message if failure is not None else None
 
     @property
     def runtime_status(self) -> Optional[OrchestrationRuntimeStatus]:
@@ -163,19 +167,9 @@ def to_json(self) -> dict[str, Any]:
             result["createdTime"] = self._format_datetime(self.created_time)
         if self.last_updated_time is not None:
             result["lastUpdatedTime"] = self._format_datetime(self.last_updated_time)
-        output = self._raw_payload(
-            self._state.serialized_output if self._state is not None else None)
+        output = self.output
         if output is not None:
             result["output"] = output
-        elif self._state is not None:
-            # A failed orchestration carries its error in ``failure_details``
-            # rather than ``serialized_output``; surface it under ``output``
-            # (matching v1, where the failure message was returned through the
-            # status output) so the error is not dropped from the payload.
-            failure = getattr(self._state, "failure_details", None)
-            failure_message = getattr(failure, "message", None) if failure is not None else None
-            if failure_message:
-                result["output"] = failure_message
         input_ = self.input_
         if input_ is not None:
             result["input"] = input_

tests/azure-functions-durable/test_client_compat.py

@@ -198,6 +198,7 @@ async def test_get_status_all_delegates():
                           new=AsyncMock(return_value=[])) as mock:
             with pytest.warns(DeprecationWarning):
                 await client.get_status_all()
+        mock.assert_awaited_once()
         query = mock.await_args.args[0]
         assert query.fetch_inputs_and_outputs is True
     finally:
@@ -316,6 +317,7 @@ async def test_get_status_by_maps_statuses():
             with pytest.warns(DeprecationWarning):
                 await client.get_status_by(
                     runtime_status=[df.OrchestrationRuntimeStatus.Running])
+        mock.assert_awaited_once()
         query = mock.await_args.args[0]
         assert query.runtime_status == [OrchestrationStatus.RUNNING]
         assert query.fetch_inputs_and_outputs is True
@@ -582,6 +584,7 @@ async def test_get_status_failed_preserves_failure_output():
                           new=AsyncMock(return_value=state)):
             with pytest.warns(DeprecationWarning):
                 status = await client.get_status("abc")
+        assert status.output == "boom"
         status_json = status.to_json()
         assert status_json["runtimeStatus"] == "Failed"
         assert status_json["output"] == "boom"