Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize performance of invoking map helper functions #3699

Open
saxena-anurag opened this issue Jul 9, 2024 · 1 comment
Open

optimize performance of invoking map helper functions #3699

saxena-anurag opened this issue Jul 9, 2024 · 1 comment
Assignees
Labels
P2 triaged Discussed in a triage meeting
Milestone

Comments

@saxena-anurag
Copy link
Contributor

Currently all the map related helper functions (lookup, update, delete, etc.) are invoked via ebpf_map_metadata_tables (which contains function pointers for each map type).

This design helps keep the code clean but prohibits any inlining (hence any performance improvements) of these functions.

This issue it to change the design / de-virtualize map related helper functions that will allow these functions to be possibly inlined for better performance.

@dahavey dahavey added the triaged Discussed in a triage meeting label Jul 15, 2024
@dahavey dahavey changed the title map API calls should not be invoked via function tables optimize performance of invoking map helper functions Jul 15, 2024
@dahavey dahavey added this to the 2407 milestone Jul 15, 2024
@dahavey dahavey added the P1 label Jul 15, 2024
@shankarseal shankarseal added P2 and removed P1 labels Jul 25, 2024
@shankarseal
Copy link
Collaborator

decreasing priority as we have made some changes to improve performance already around map lookup. For the next set of innovations, we await SPGO data.

@shankarseal shankarseal modified the milestones: 2407, 2408 Jul 25, 2024
@shankarseal shankarseal modified the milestones: 2408, 2409 Aug 2, 2024
@shankarseal shankarseal modified the milestones: 2409, 2410 Sep 9, 2024
@shankarseal shankarseal modified the milestones: 2410, 2411 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

3 participants