Refactor null checks and modernize code style

Replaced manual null checks with ArgumentNullException.ThrowIfNull for clarity and consistency. Updated unit tests to use object initializers. Simplified dictionary initialization with collection expressions and improved code style with var usage. Removed unnecessary comments, whitespace, and the <NoWarn> property from the project file. No significant documentation changes.

Author: AClerbois

examples/Tools/FluentUI.Demo.DocApiGen.Tests/Models/AllMode/ComponentInfoTests.cs

@@ -34,10 +34,11 @@ public void Constructor_ShouldInitializeWithDefaults()
     public void Name_ShouldBeSettable()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.Name = "FluentButton";
+        var component = new ComponentInfo
+        {
+            // Act
+            Name = "FluentButton"
+        };
 
         // Assert
         Assert.Equal("FluentButton", component.Name);
@@ -47,10 +48,11 @@ public void Name_ShouldBeSettable()
     public void FullName_ShouldBeSettable()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.FullName = "Microsoft.FluentUI.AspNetCore.Components.FluentButton";
+        var component = new ComponentInfo
+        {
+            // Act
+            FullName = "Microsoft.FluentUI.AspNetCore.Components.FluentButton"
+        };
 
         // Assert
         Assert.Equal("Microsoft.FluentUI.AspNetCore.Components.FluentButton", component.FullName);
@@ -60,10 +62,11 @@ public void FullName_ShouldBeSettable()
     public void Summary_ShouldBeSettable()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.Summary = "A button component";
+        var component = new ComponentInfo
+        {
+            // Act
+            Summary = "A button component"
+        };
 
         // Assert
         Assert.Equal("A button component", component.Summary);
@@ -73,10 +76,11 @@ public void Summary_ShouldBeSettable()
     public void Category_ShouldBeSettable()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.Category = "Forms";
+        var component = new ComponentInfo
+        {
+            // Act
+            Category = "Forms"
+        };
 
         // Assert
         Assert.Equal("Forms", component.Category);
@@ -86,10 +90,11 @@ public void Category_ShouldBeSettable()
     public void IsGeneric_ShouldBeSettable()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.IsGeneric = true;
+        var component = new ComponentInfo
+        {
+            // Act
+            IsGeneric = true
+        };
 
         // Assert
         Assert.True(component.IsGeneric);
@@ -112,10 +117,11 @@ public void BaseClass_ShouldBeSettableToNull()
     public void BaseClass_ShouldBeSettableToValue()
     {
         // Arrange
-        var component = new ComponentInfo();
-
-        // Act
-        component.BaseClass = "FluentComponentBase";
+        var component = new ComponentInfo
+        {
+            // Act
+            BaseClass = "FluentComponentBase"
+        };
 
         // Assert
         Assert.Equal("FluentComponentBase", component.BaseClass);

examples/Tools/FluentUI.Demo.DocApiGen/FluentUI.Demo.DocApiGen.csproj

@@ -6,8 +6,6 @@
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
-    <!-- Suppress code analysis rules for null checks -->
-    <NoWarn>$(NoWarn);CA1510;IDE0005;IDE0007;IDE0011;CS1591</NoWarn>
   </PropertyGroup>
 
 <!-- Code Analysis -->

examples/Tools/FluentUI.Demo.DocApiGen/Formatters/CSharpOutputFormatter.cs

@@ -20,10 +20,7 @@ public class CSharpOutputFormatter : IOutputFormatter
     /// <inheritdoc/>
     public string Format(object data)
     {
-        if (data == null)
-        {
-            throw new ArgumentNullException(nameof(data));
-        }
+        ArgumentNullException.ThrowIfNull(data);
 
         if (data is not SummaryDocumentationData summaryData)
         {
@@ -84,7 +81,7 @@ private static string GenerateCSharpCode(SummaryDocumentationData data)
             var key = EscapeString(entry.Key);
             var summary = EscapeString(entry.Value.Summary);
             var signature = EscapeString(entry.Value.Signature);
-            
+
 #pragma warning disable CA1305 // Specify IFormatProvider
             sb.AppendLine($"        {{ \"{key}\", (\"{summary}\", \"{signature}\") }},");
 #pragma warning restore CA1305 // Specify IFormatProvider

examples/Tools/FluentUI.Demo.DocApiGen/Formatters/JsonOutputFormatter.cs

@@ -36,10 +36,7 @@ public JsonOutputFormatter(bool indented = true, bool useCompactFormat = true)
     /// <inheritdoc/>
     public string Format(object data)
     {
-        if (data == null)
-        {
-            throw new ArgumentNullException(nameof(data));
-        }
+        ArgumentNullException.ThrowIfNull(data);
 
         // Si c'est un SummaryDocumentationData et qu'on veut le format compact (Summary mode standard)
         if (_useCompactFormat && data is SummaryDocumentationData summaryData)
@@ -82,9 +79,11 @@ private static string FormatSummary(SummaryDocumentationData data)
             // Format de la clé: "Namespace.TypeName.__summary__" ou "Namespace.TypeName.MemberName"
             var fullKey = kvp.Key;
             var lastDotIndex = fullKey.LastIndexOf('.');
-            
+
             if (lastDotIndex == -1)
+            {
                 continue;
+            }
 
             var beforeLastDot = fullKey[..lastDotIndex];
             var memberName = fullKey[(lastDotIndex + 1)..];
@@ -95,7 +94,7 @@ private static string FormatSummary(SummaryDocumentationData data)
 
             if (!componentsByType.TryGetValue(typeName, out var members))
             {
-                members = new Dictionary<string, string>();
+                members = [];
                 componentsByType[typeName] = members;
             }
 
@@ -109,14 +108,14 @@ private static string FormatSummary(SummaryDocumentationData data)
             sb.AppendLine(CultureInfo.InvariantCulture, $"  \"{EscapeJson(typeEntry.Key)}\": {{");
 
             var membersList = typeEntry.Value.OrderBy(x => x.Key).ToList();
-            for (int i = 0; i < membersList.Count; i++)
+            for (var i = 0; i < membersList.Count; i++)
             {
                 var member = membersList[i];
                 var isLast = i == membersList.Count - 1;
 
                 var escapedValue = EscapeJson(member.Value);
                 sb.Append(CultureInfo.InvariantCulture, $"    \"{EscapeJson(member.Key)}\": \"{escapedValue}\"");
-                
+
                 if (!isLast)
                 {
                     sb.AppendLine(",");

examples/Tools/FluentUI.Demo.DocApiGen/Generators/AllDocumentationGenerator.cs

@@ -36,10 +36,7 @@ public AllDocumentationGenerator(Assembly assembly, FileInfo xmlDocumentation)
     /// <inheritdoc/>
     public override string Generate(IOutputFormatter formatter)
     {
-        if (formatter == null)
-        {
-            throw new ArgumentNullException(nameof(formatter));
-        }
+        ArgumentNullException.ThrowIfNull(formatter);
 
         if (formatter.FormatName != "json")
         {

examples/Tools/FluentUI.Demo.DocApiGen/Generators/DocumentationGeneratorBase.cs

@@ -52,10 +52,7 @@ public virtual void SaveToFile(string filePath, IOutputFormatter formatter)
             throw new ArgumentException("File path cannot be null or empty.", nameof(filePath));
         }
 
-        if (formatter == null)
-        {
-            throw new ArgumentNullException(nameof(formatter));
-        }
+        ArgumentNullException.ThrowIfNull(formatter);
 
         var output = Generate(formatter);
 

examples/Tools/FluentUI.Demo.DocApiGen/Generators/DocumentationGeneratorFactory.cs

@@ -26,15 +26,9 @@ public static IDocumentationGenerator Create(
         Assembly assembly,
         FileInfo xmlDocumentation)
     {
-        if (assembly == null)
-        {
-            throw new ArgumentNullException(nameof(assembly));
-        }
+        ArgumentNullException.ThrowIfNull(assembly);
 
-        if (xmlDocumentation == null)
-        {
-            throw new ArgumentNullException(nameof(xmlDocumentation));
-        }
+        ArgumentNullException.ThrowIfNull(xmlDocumentation);
 
         return mode switch
         {

examples/Tools/FluentUI.Demo.DocApiGen/Generators/SummaryDocumentationGenerator.cs

@@ -35,10 +35,7 @@ public SummaryDocumentationGenerator(Assembly assembly, FileInfo xmlDocumentatio
     /// <inheritdoc/>
     public override string Generate(IOutputFormatter formatter)
     {
-        if (formatter == null)
-        {
-            throw new ArgumentNullException(nameof(formatter));
-        }
+        ArgumentNullException.ThrowIfNull(formatter);
 
         var data = BuildDocumentationData();
         return formatter.Format(data);
@@ -124,13 +121,13 @@ private SummaryDocumentationData BuildDocumentationData()
     private (string Version, string Date) GetAssemblyInfo()
     {
         var version = "Unknown";
-        
+
         var versionAttribute = Assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>();
         if (versionAttribute != null)
         {
             var versionString = versionAttribute.InformationalVersion;
             var plusIndex = versionString.IndexOf('+');
-            
+
             if (plusIndex >= 0 && plusIndex + 9 < versionString.Length)
             {
                 version = versionString[..(plusIndex + 9)];
@@ -142,7 +139,7 @@ private SummaryDocumentationData BuildDocumentationData()
         }
 
         var date = DateTime.UtcNow.ToString("yyyy-MM-dd HH:mm", CultureInfo.InvariantCulture);
-        
+
         return (version, date);
     }
 }

examples/Tools/FluentUI.Demo.DocApiGen/ReadMe.md

@@ -57,5 +57,3 @@ The tool supports different JSON formats depending on the generation mode:
    - CamelCase property names
    - Full type names with namespaces
    - Includes properties, methods, events, and enums
-
-See [GENERATION_MODES.md](GENERATION_MODES.md) for detailed documentation about generation modes and formats.