Skip to content

Commit 47113bd

Browse files
authored
Release updates + remove unnecessary yarn resolutions (#4195)
1 parent afd1fd1 commit 47113bd

7 files changed

Lines changed: 113 additions & 56893 deletions

File tree

.ado/azure-pipelines.publish.yml

Lines changed: 30 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -18,22 +18,29 @@ parameters:
1818
variables:
1919
- group: 'FluentUI React Native Secrets'
2020
- group: InfoSec-SecurityResults
21-
- name: tags
22-
value: production,externalfacing
23-
# Use the private registry mirror due to network restrictions (this is added to .npmrc in a step below)
24-
- name: REGISTRY_URL
25-
value: https://pkgs.dev.azure.com/office/_packaging/Office/npm/registry/
26-
- name: YARN_NPM_REGISTRY_SERVER
27-
value: $(REGISTRY_URL)
28-
- name: YARN_NPM_ALWAYS_AUTH
29-
value: 1
30-
# Enable yarn-plugin-npmrc
31-
- name: YARN_NPMRC_AUTH_ENABLED
32-
value: 1
33-
- name: packagesArtifactName
34-
value: packed-tarballs
35-
- name: releaseToolArtifactName
36-
value: release-api-tool
21+
- group: ogx-oss-release
22+
- template: .ado/templates/readonly-variables.yml
23+
parameters:
24+
variables:
25+
tags: production,externalfacing
26+
27+
# Use the private registry mirror due to network restrictions (this is added to .npmrc in a step below)
28+
REGISTRY_URL: https://pkgs.dev.azure.com/office/_packaging/Office/npm/registry/
29+
YARN_NPM_REGISTRY_SERVER: $(REGISTRY_URL)
30+
YARN_NPM_ALWAYS_AUTH: 1
31+
# Enable yarn-plugin-npmrc
32+
YARN_NPMRC_AUTH_ENABLED: 1
33+
34+
packagesArtifactName: packed-tarballs
35+
releaseToolArtifactName: release-api-tool
36+
37+
# Map in variable group values as readonly (with this syntax, they'll be empty strings if unset)
38+
esrpStagingAzureSubscription: $[variables.grp_esrpStagingAzureSubscription]
39+
esrpStagingStorageAccount: $[variables.grp_esrpStagingStorageAccount]
40+
esrpReleaseAzureSubscription: $[variables.grp_esrpReleaseAzureSubscription]
41+
esrpReleaseClientId: $[variables.grp_esrpReleaseClientId]
42+
esrpReleaseKeyVaultName: $[variables.grp_esrpReleaseKeyVaultName]
43+
esrpReleaseTenantId: $[variables.grp_esrpReleaseTenantId]
3744

3845
resources:
3946
repositories:
@@ -116,7 +123,7 @@ extends:
116123
117124
- script: |
118125
mkdir -p '$(releaseToolArtifactPath)'
119-
cp scripts/esrp-npm-release-temp/index.mjs '$(releaseToolArtifactPath)'
126+
cp node_modules/@microsoft/esrp-npm-release/index.mjs '$(releaseToolArtifactPath)'
120127
displayName: 'Copy ESRP release tool'
121128
122129
- stage: Publish
@@ -157,7 +164,7 @@ extends:
157164
- task: AzureCLI@2
158165
displayName: 'Get credentials for staging blob storage'
159166
inputs:
160-
azureSubscription: ogx-esrp-infra-bot
167+
azureSubscription: $(esrpStagingAzureSubscription)
161168
scriptType: bash
162169
scriptLocation: inlineScript
163170
addSpnToEnvironment: true
@@ -169,8 +176,8 @@ extends:
169176
- task: AzureKeyVault@2
170177
displayName: 'Get ESRP certificates from Key Vault'
171178
inputs:
172-
azureSubscription: ESRP-JSHost3
173-
KeyVaultName: OGX-JSHost-KV
179+
azureSubscription: $(esrpReleaseAzureSubscription)
180+
KeyVaultName: $(esrpReleaseKeyVaultName)
174181
SecretsFilter: OGX-JSHost-Auth4,OGX-JSHost-Sign3
175182

176183
- script: node '$(releaseToolArtifactPath)/index.mjs'
@@ -180,14 +187,13 @@ extends:
180187
PACKED_PACKAGES_PATH: $(packagesArtifactPath)
181188
ESRP_PRODUCT_NAME: fluentui-react-native
182189
ESRP_NPM_TAG: latest
183-
# TODO should be somebody else
184-
ESRP_USER: elcraig@microsoft.com
185-
ESRP_APPROVERS: dannyvv@microsoft.com
190+
ESRP_USER: sanajmi@microsoft.com
191+
ESRP_APPROVERS: jasonmo@microsoft.com
186192
ESRP_TENANT_ID: cdc5aeea-15c5-4db6-b079-fcadd2505dc2
187193
ESRP_CLIENT_ID: 0a35e01f-eadf-420a-a2bf-def002ba898d
188194
ESRP_AUTH_CERT: $(OGX-JSHost-Auth4)
189195
ESRP_REQUEST_SIGNING_CERT: $(OGX-JSHost-Sign3)
190-
STAGING_STORAGE_ACCOUNT_NAME: ogxesrptempstorage
196+
STAGING_STORAGE_ACCOUNT_NAME: $(esrpStagingStorageAccount)
191197
STAGING_CLIENT_ID: $(STAGING_CLIENT_ID)
192198
STAGING_TENANT_ID: $(STAGING_TENANT_ID)
193199
STAGING_ID_TOKEN: $(STAGING_ID_TOKEN)
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# This template is a helper to declare many readonly variables in a readable manner.
2+
parameters:
3+
- name: variables
4+
type: object
5+
default: {}
6+
7+
variables:
8+
- ${{ each variable in parameters.variables }}:
9+
- name: ${{ variable.key }}
10+
value: ${{ variable.value }}
11+
readonly: true

.oxfmtrc.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
"**/lib-commonjs/**",
1212
"**/dist/**",
1313
"packages/native/Callout/windows/Callout/codegen/**",
14-
"**/esrp-npm-release-temp/**",
1514
"**/CHANGELOG.*",
1615
"**/CODE_OF_CONDUCT.md",
1716
"**/SECURITY.md",

.yarnrc.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -341,4 +341,6 @@ plugins:
341341
path: .yarn/plugins/@yarnpkg/plugin-npmrc.cjs
342342
spec: "https://raw.githubusercontent.com/microsoft/beachball/yarn-plugin-npmrc_v0.5.1/yarn-plugins/npmrc/dist/plugin.js"
343343

344+
preferReuse: true
345+
344346
yarnPath: .yarn/releases/yarn-4.18.0.cjs

package.json

Lines changed: 9 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
"@babel/runtime": "catalog:",
4545
"@changesets/changelog-github": "^0.5.0",
4646
"@changesets/cli": "^2.30.0",
47+
"@microsoft/esrp-npm-release": "^0.1.2",
4748
"@rnx-kit/align-deps": "catalog:",
4849
"@rnx-kit/lint-lockfile": "catalog:",
4950
"@yarnpkg/types": "^4.0.1",
@@ -62,27 +63,15 @@
6263
"@fluentui/react-native-icons/@types/react-native": "ignore:",
6364
"@react-native-windows/cli": "patch:@react-native-windows/cli@npm%3A0.81.8#~/.yarn/patches/@react-native-windows-cli-npm-0.81.8-9ffb7042e8.patch",
6465
"@types/react": "19.1.17",
65-
"@xmldom/xmldom@npm:^0.8.8": "0.8.13",
66-
"@xmldom/xmldom@npm:^0.9.5": "0.9.10",
67-
"@xmldom/xmldom@npm:^0.x": "0.9.10",
68-
"axios": "^1.18.1",
69-
"esbuild@npm:~0.25.0": "0.25.12",
66+
"axios@npm:1.13.3": "^1.18.1",
67+
"esbuild@npm:~0.25.0": "^0.28.0",
7068
"expect-webdriverio": "patch:expect-webdriverio@npm%3A5.6.1#~/.yarn/patches/expect-webdriverio-npm-5.6.1-69666d39e9.patch",
71-
"form-data": "4.0.6",
72-
"lodash": "4.18.1",
73-
"path-to-regexp": "8.4.2",
74-
"picomatch@npm:^2.0.4": "2.3.2",
75-
"picomatch@npm:^2.2.1": "2.3.2",
76-
"picomatch@npm:^2.2.3": "2.3.2",
77-
"picomatch@npm:^2.3.1": "2.3.2",
78-
"shell-quote": "1.9.0",
79-
"tmp": "0.2.7",
80-
"undici@npm:^6.21.3": "6.27.0",
81-
"unicorn-magic": "^0.4.0",
82-
"ws@npm:8.19.0": "8.21.0",
83-
"ws@npm:^6.2.3": "6.2.4",
84-
"ws@npm:^7": "7.5.11",
85-
"ws@npm:^7.5.10": "7.5.11"
69+
"form-data@npm:4.0.5": "^4.0.6",
70+
"lodash": "^4.18.1",
71+
"path-to-regexp@npm:8.3.0": "^8.4.2",
72+
"shell-quote": "^1.9.0",
73+
"unicorn-magic@npm:^0.3.0": "^0.4.0",
74+
"ws@npm:8.19.0": "^8.21.0"
8675
},
8776
"engines": {
8877
"node": ">=22.12"

0 commit comments

Comments
 (0)