Commit fca4306
authored
fix unit 15 README.md final example code bug
Final example in unit 15 appears to have a bug. The python code retrieves relevant chunks and appends to history[], then finally appends the user query to history[], but then only sends the last entry of history[] (the user query) to the LLM. This means the RAG steps do not benefit the LLM query. I'm not sure the intent of the history[-1] line, but I am certain the intent is not what the code currently does. I made a reasonable assumption that the code would be closer or equal to the author's intent if the full history[] were joined and sent to the LLM.1 parent 33b7cd4 commit fca4306
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
208 | 208 | | |
209 | 209 | | |
210 | 210 | | |
211 | | - | |
| 211 | + | |
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
| |||
0 commit comments