Skip to content

Commit 2b0b5d6

Browse files
committed
Update comments on LinAlgMatrixOperationShape for clarity
1 parent 12131d1 commit 2b0b5d6

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

proposals/0035-linalg-matrix.md

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1797,9 +1797,11 @@ struct PSVLinAlgRuntimeInfo0 {
17971797
};
17981798
17991799
struct PSVLinAlgMatrixOperationShape0 {
1800-
uint32_t M; // Rows in matrix A
1801-
uint32_t N; // Columns in matrix B
1802-
uint32_t K; // Columns in matrix A / Rows in matrix B / Unused (0)
1800+
// For each dimension, Unused == 0
1801+
// For MatrixConstruction, Unused dim depends on matrix Use.
1802+
uint32_t M; // Rows in matrix A / Accumulator
1803+
uint32_t N; // Columns in matrix B / Accumulator
1804+
uint32_t K; // Columns in matrix A / Rows in matrix B
18031805
};
18041806
18051807
struct PSVLinAlgMatrixShapeArrayReference {
@@ -2054,9 +2056,10 @@ RDAT_ENUM_END()
20542056
20552057
RDAT_STRUCT_TABLE(LinAlgMatrixOperationShape,
20562058
LinAlgMatrixOperationShapeTable)
2057-
// Unused dimensions stored as 0.
2058-
RDAT_VALUE(uint32_t, M) // Rows in matrix A
2059-
RDAT_VALUE(uint32_t, N) // Columns in matrix B
2059+
// For each dimension, Unused == 0
2060+
// For MatrixConstruction, Unused dim depends on matrix Use.
2061+
RDAT_VALUE(uint32_t, M) // Rows in matrix A / Accumulator
2062+
RDAT_VALUE(uint32_t, N) // Columns in matrix B / Accumulator
20602063
RDAT_VALUE(uint32_t, K) // Columns in matrix A / Rows in matrix B
20612064
RDAT_STRUCT_END()
20622065

0 commit comments

Comments
 (0)