Skip to content

Commit cf5866e

Browse files
authored
Apply suggestions from code review
Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com>
1 parent 9711beb commit cf5866e

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

packages/test-utilities/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@lage-run/test-utilities",
33
"version": "0.1.0",
4-
"description": "Test utilities",
4+
"description": "Internal test utilities for lage",
55
"private": true,
66
"repository": {
77
"url": "https://github.com/microsoft/lage"

packages/test-utilities/src/removeTempDir.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,11 @@ import * as fs from "fs";
99
* removal methods directly.
1010
*
1111
* @returns Whether deleting the directory succeeded.
12+
* If `dir` was undefined or empty, it's a no-op and returns true.
1213
*/
13-
export function removeTempDir(dir: string): boolean {
14+
export function removeTempDir(dir: string | undefined): boolean {
1415
try {
15-
fs.rmSync(dir, { recursive: true, force: true });
16+
dir && fs.rmSync(dir, { recursive: true, force: true });
1617
return true;
1718
} catch {
1819
return false;

0 commit comments

Comments
 (0)