unreachable code in OutlookMsgConverter class

[amaziahub]

Hi all,

Went over the project code and encountered the following block of code under the accepts function that is unreachable:

...

        try:
            if olefile and not olefile.isOleFile(file_stream):
                return False
        finally:
            file_stream.seek(cur_pos)

        # Brue force, check if it's an Outlook file
        try:
            if olefile is not None: -> `unreachable`
                msg = olefile.OleFileIO(file_stream)
                toc = "\n".join([str(stream) for stream in msg.listdir()])
                return (
                    "__properties_version1.0" in toc
                    and "__recip_version1.0_#00000000" in toc
                )
        except Exception as e:
            pass
        finally:
            file_stream.seek(cur_pos)
            

the reason the block is unreachable is because the If this condition is true — olefile is defined and the file is not an OLE file — it will return False immediately.

Would love to hear thoughts