Skip to content

Commit f8bbf68

Browse files
author
Shreya Sangwa
committed
Fix managed cleanroom review findings
1 parent 2b9027e commit f8bbf68

6 files changed

Lines changed: 46 additions & 867 deletions

File tree

tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architechture.md renamed to tools/Azure.Mcp.Tools.ManagedCleanroom/docs/architecture.md

File renamed without changes.

‎tools/Azure.Mcp.Tools.ManagedCleanroom/src/Azure.Mcp.Tools.ManagedCleanroom.csproj‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,9 @@
77
<ProjectReference Include="..\..\..\core\Azure.Mcp.Core\src\Azure.Mcp.Core.csproj" />
88
</ItemGroup>
99
<ItemGroup>
10-
<PackageReference Include="Azure.Cleanroom.Analytics.Frontend.Client" VersionOverride="1.0.0-beta.1" />
1110
<PackageReference Include="Azure.Core" />
1211
<PackageReference Include="Azure.Identity" />
13-
<PackageReference Include="Azure.ResourceManager.CleanRoom" />
12+
<PackageReference Include="Azure.ResourceManager.Resources" />
1413
<PackageReference Include="Microsoft.Extensions.DependencyInjection" />
1514
<PackageReference Include="ModelContextProtocol" />
1615
<PackageReference Include="System.CommandLine" />

‎tools/Azure.Mcp.Tools.ManagedCleanroom/src/Options/Collaborations/CollaborationsListOptions.cs‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,13 @@ namespace Azure.Mcp.Tools.ManagedCleanroom.Options.Collaborations;
88

99
public class CollaborationsListOptions
1010
{
11-
[Option("The Azure Cleanroom Analytics Frontend service endpoint URL (e.g., 'https://my-cleanroom.cloudapp.azure.net').")]
11+
[Option(ManagedCleanroomOptionDescriptions.Endpoint)]
1212
public required string Endpoint { get; set; }
1313

1414
[Option("When true, returns only active collaborations (email-only lookup). When omitted, returns all collaborations.")]
1515
public bool? ActiveOnly { get; set; }
1616

17-
[Option("When true, skips TLS certificate validation for the cleanroom endpoint. Use only for dev/test endpoints with self-signed certificates.")]
17+
[Option(ManagedCleanroomOptionDescriptions.AllowUntrustedCert)]
1818
public bool AllowUntrustedCert { get; set; }
1919

2020
[Option(OptionDescriptions.Tenant)]

‎tools/Azure.Mcp.Tools.ManagedCleanroom/src/Services/IManagedCleanroomService.cs‎

Lines changed: 0 additions & 186 deletions
Original file line numberDiff line numberDiff line change
@@ -15,176 +15,6 @@ Task<JsonElement> ListCollaborationsAsync(
1515
string? tenant = null,
1616
CancellationToken cancellationToken = default);
1717

18-
Task<JsonElement> GetCollaborationAsync(
19-
string endpoint,
20-
string collaborationId,
21-
bool? includeDeleted = null,
22-
bool allowUntrustedCert = false,
23-
string? tenant = null,
24-
CancellationToken cancellationToken = default);
25-
26-
Task<JsonElement> GetAnalyticsAsync(
27-
string endpoint,
28-
string collaborationId,
29-
bool allowUntrustedCert = false,
30-
string? tenant = null,
31-
CancellationToken cancellationToken = default);
32-
33-
Task<JsonElement> GetAnalyticsSkrPolicyAsync(
34-
string endpoint,
35-
string collaborationId,
36-
string kid,
37-
bool allowUntrustedCert = false,
38-
string? tenant = null,
39-
CancellationToken cancellationToken = default);
40-
41-
Task<JsonElement> ListInvitationsAsync(
42-
string endpoint,
43-
string collaborationId,
44-
bool? pendingOnly = null,
45-
bool allowUntrustedCert = false,
46-
string? tenant = null,
47-
CancellationToken cancellationToken = default);
48-
49-
Task<JsonElement> AcceptInvitationAsync(
50-
string endpoint,
51-
string collaborationId,
52-
string invitationId,
53-
bool allowUntrustedCert = false,
54-
string? tenant = null,
55-
CancellationToken cancellationToken = default);
56-
57-
Task<JsonElement> GetOidcIssuerInfoAsync(
58-
string endpoint,
59-
string collaborationId,
60-
bool allowUntrustedCert = false,
61-
string? tenant = null,
62-
CancellationToken cancellationToken = default);
63-
64-
Task<JsonElement> SetOidcIssuerUrlAsync(
65-
string endpoint,
66-
string collaborationId,
67-
string issuerUrl,
68-
bool allowUntrustedCert = false,
69-
string? tenant = null,
70-
CancellationToken cancellationToken = default);
71-
72-
Task<JsonElement> PublishDatasetAsync(
73-
string endpoint,
74-
string collaborationId,
75-
string documentId,
76-
bool allowUntrustedCert = false,
77-
string? tenant = null,
78-
CancellationToken cancellationToken = default);
79-
80-
Task<JsonElement> GetDatasetAsync(
81-
string endpoint,
82-
string collaborationId,
83-
string documentId,
84-
bool allowUntrustedCert = false,
85-
string? tenant = null,
86-
CancellationToken cancellationToken = default);
87-
88-
Task<JsonElement> ListDatasetsAsync(
89-
string endpoint,
90-
string collaborationId,
91-
bool allowUntrustedCert = false,
92-
string? tenant = null,
93-
CancellationToken cancellationToken = default);
94-
95-
Task<JsonElement> PublishQueryAsync(
96-
string endpoint,
97-
string collaborationId,
98-
string documentId,
99-
bool allowUntrustedCert = false,
100-
string? tenant = null,
101-
CancellationToken cancellationToken = default);
102-
103-
Task<JsonElement> GetQueryAsync(
104-
string endpoint,
105-
string collaborationId,
106-
string documentId,
107-
bool allowUntrustedCert = false,
108-
string? tenant = null,
109-
CancellationToken cancellationToken = default);
110-
111-
Task<JsonElement> ListQueriesAsync(
112-
string endpoint,
113-
string collaborationId,
114-
bool allowUntrustedCert = false,
115-
string? tenant = null,
116-
CancellationToken cancellationToken = default);
117-
118-
Task<JsonElement> VoteOnQueryAsync(
119-
string endpoint,
120-
string collaborationId,
121-
string documentId,
122-
string vote,
123-
bool allowUntrustedCert = false,
124-
string? tenant = null,
125-
CancellationToken cancellationToken = default);
126-
127-
Task<JsonElement> RunQueryAsync(
128-
string endpoint,
129-
string collaborationId,
130-
string documentId,
131-
bool allowUntrustedCert = false,
132-
string? tenant = null,
133-
CancellationToken cancellationToken = default);
134-
135-
Task<JsonElement> GetQueryRunsAsync(
136-
string endpoint,
137-
string collaborationId,
138-
string documentId,
139-
bool allowUntrustedCert = false,
140-
string? tenant = null,
141-
CancellationToken cancellationToken = default);
142-
143-
Task<JsonElement> ListAuditEventsAsync(
144-
string endpoint,
145-
string collaborationId,
146-
string? scope = null,
147-
string? fromSeqno = null,
148-
string? toSeqno = null,
149-
bool allowUntrustedCert = false,
150-
string? tenant = null,
151-
CancellationToken cancellationToken = default);
152-
153-
Task<JsonElement> PutConsentAsync(
154-
string endpoint,
155-
string collaborationId,
156-
string documentId,
157-
bool allowUntrustedCert = false,
158-
string? tenant = null,
159-
CancellationToken cancellationToken = default);
160-
161-
Task<JsonElement> GetOidcKeysAsync(
162-
string endpoint,
163-
string collaborationId,
164-
bool allowUntrustedCert = false,
165-
string? tenant = null,
166-
CancellationToken cancellationToken = default);
167-
168-
Task<JsonElement> AddCollaboratorAsync(
169-
string name,
170-
string resourceGroup,
171-
string subscription,
172-
string collaboratorUserIdentifier,
173-
string? collaboratorObjectId = null,
174-
string? collaboratorTenantId = null,
175-
string? tenant = null,
176-
RetryPolicyOptions? retryPolicy = null,
177-
CancellationToken cancellationToken = default);
178-
179-
Task<JsonElement> EnableWorkloadAsync(
180-
string name,
181-
string resourceGroup,
182-
string subscription,
183-
string workloadType,
184-
string? tenant = null,
185-
RetryPolicyOptions? retryPolicy = null,
186-
CancellationToken cancellationToken = default);
187-
18818
Task<CollaborationCreateResult> CreateCollaborationArmResourceAsync(
18919
string name,
19020
string resourceGroup,
@@ -195,22 +25,6 @@ Task<CollaborationCreateResult> CreateCollaborationArmResourceAsync(
19525
string? tenant = null,
19626
RetryPolicyOptions? retryPolicy = null,
19727
CancellationToken cancellationToken = default);
198-
199-
Task<JsonElement> GetCollaborationArmResourceAsync(
200-
string name,
201-
string resourceGroup,
202-
string subscription,
203-
string? tenant = null,
204-
RetryPolicyOptions? retryPolicy = null,
205-
CancellationToken cancellationToken = default);
206-
207-
Task<JsonElement> GetCollaborationReadonlyKubeconfigAsync(
208-
string name,
209-
string resourceGroup,
210-
string subscription,
211-
string? tenant = null,
212-
RetryPolicyOptions? retryPolicy = null,
213-
CancellationToken cancellationToken = default);
21428
}
21529

21630
/// <summary>Result returned by <see cref="IManagedCleanroomService.CreateCollaborationArmResourceAsync"/>.</summary>

0 commit comments

Comments
 (0)