Commit 1aa6e02
Switch to AnyCPU for libraries, migrate to slnx (#187)
* Switch to AnyCPU platform with RuntimeIdentifier for native assets
Replace the Platform-based architecture selection (x64/ARM64) with
RuntimeIdentifier-based selection. All projects now default to AnyCPU;
the correct native Windows App SDK DLLs are resolved via RuntimeIdentifier
(win-x64/win-arm64) set automatically in Directory.Build.targets based on
machine architecture.
Changes:
- Directory.Build.props: Remove Platform override that forced AnyCPU to
x64/ARM64
- Directory.Build.targets: Add RuntimeIdentifier default for Windows TFM
projects (net8.0+) when Platform is AnyCPU
- All ~100 .csproj files: Remove <Platforms>x64;ARM64</Platforms>
- Reactor.Cli: Update MirrorBinForSelfhost to resolve arch from
RuntimeIdentifier (keeps bin/x64 and bin/arm64 layout)
- Solution file: Update Any CPU/x86 project mappings to use Any CPU
(instead of remapping to x64)
- release.yml: Remove -p:Platform=x64 from build/pack (keep --runtime
for publish)
- coverage.yml: Replace hardcoded bin/x64 path with dynamic file lookup
- Update AGENTS.md, CONTRIBUTING.md, README.md, PR template, devtools
skill doc
The release workflow still produces RID-specific CLI binaries (win-x64 +
win-arm64) for the skill kit. The NuGet package is now architecture-neutral.
Fixes #185
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Refine: libraries AnyCPU, apps keep x64/ARM64; migrate to slnx
Revise the AnyCPU approach based on feedback:
- Libraries (Reactor, Reactor.Interop.WinForms) explicitly set
Platform=AnyCPU and Platforms=AnyCPU — they produce architecture-
neutral IL.
- Application/test projects keep the existing x64/ARM64 platform
selection via Directory.Build.props (defaults to machine arch).
- WindowsAppSDKSelfContained apps need a concrete architecture for
native asset resolution; this is supplied by Platform (x64/ARM64).
Also migrates from Reactor.sln to Reactor.slnx:
- Cleaner XML format, no per-project platform mapping boilerplate
- Solution platforms reduced to x64 and ARM64 (removed Any CPU/x86)
- Library projects have no platform mappings (always AnyCPU)
Remove Directory.Build.targets RuntimeIdentifier logic — no longer
needed since apps use Platform directly for native assets.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Simplify: per-project Platforms, no shared Platform logic
Each project declares its own platform requirements:
- Application/test/sample projects: <Platforms>x64;ARM64</Platforms>
(need concrete arch for WindowsAppSDKSelfContained native assets)
- Library projects (Reactor, Reactor.Interop.WinForms): no Platforms
(MSBuild defaults to AnyCPU; IL is always architecture-neutral)
- Analyzers/generators (netstandard2.0): inherently AnyCPU
Directory.Build.props no longer contains Platform fallback logic.
When building a single app project directly, pass -p:Platform=x64
(or ARM64). Solution builds get Platform from the .slnx config.
CI workflows now pass explicit -p:Platform=x64 for standalone
project builds.
Fix SelfTests: pure MSTest runner, no Windows App SDK dependency —
set WindowsAppSDKSelfContained=false and remove Platforms.
Fix .sln → .slnx migration: update FindHostExe() repo-root lookups
in SelfTestBatch, TestSession, WinFormsTestSession, and CompileCommand
to search for Reactor.slnx instead of Reactor.sln.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Remove Platforms from WPF projects (no Windows App SDK dependency)
StressPerf.Wpf and CmdPerf.Wpf target net10.0-windows (no WinAppSDK),
so they don't need WindowsAppSDKSelfContained and can be AnyCPU.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix slnx: remove x64/ARM64 platform mappings from AnyCPU projects
PerfBench.Shared, StressPerf.Shared, StressPerf.Wpf, CmdPerf.Wpf,
Chat.UI, and Reactor.SelfTests no longer declare x64/ARM64 Platforms,
so their slnx entries must not map to those configurations.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent a475145 commit 1aa6e02
29 files changed
Lines changed: 387 additions & 1550 deletions
File tree
- .github
- workflows
- samples
- ReactorGallery
- apps/chat/Chat.UI
- skills
- src
- Reactor.Cli
- Docs
- Reactor.Interop.WinForms
- Reactor
- tests
- Reactor.AppTests
- Infrastructure
- Reactor.SelfTests
- cmd_perf
- CmdPerf.Wpf
- stress_perf
- StressPerf.Wpf
- tools/reviewer
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
| 25 | + | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | | - | |
| 93 | + | |
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
| |||
106 | 106 | | |
107 | 107 | | |
108 | 108 | | |
109 | | - | |
| 109 | + | |
110 | 110 | | |
111 | 111 | | |
112 | | - | |
| 112 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
66 | 66 | | |
67 | 67 | | |
68 | 68 | | |
69 | | - | |
| 69 | + | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
83 | 88 | | |
84 | | - | |
| 89 | + | |
85 | 90 | | |
86 | 91 | | |
87 | 92 | | |
88 | 93 | | |
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
92 | | - | |
| 97 | + | |
93 | 98 | | |
94 | 99 | | |
95 | 100 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
| 94 | + | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
| 97 | + | |
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
104 | | - | |
105 | 104 | | |
106 | 105 | | |
107 | 106 | | |
| |||
121 | 120 | | |
122 | 121 | | |
123 | 122 | | |
124 | | - | |
125 | 123 | | |
126 | 124 | | |
127 | 125 | | |
| |||
131 | 129 | | |
132 | 130 | | |
133 | 131 | | |
134 | | - | |
135 | 132 | | |
136 | 133 | | |
137 | 134 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
| 8 | + | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
51 | | - | |
| 50 | + | |
| 51 | + | |
52 | 52 | | |
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
59 | 66 | | |
60 | 67 | | |
61 | 68 | | |
| |||
201 | 208 | | |
202 | 209 | | |
203 | 210 | | |
204 | | - | |
| 211 | + | |
205 | 212 | | |
206 | 213 | | |
207 | 214 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | 13 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
190 | 190 | | |
191 | 191 | | |
192 | 192 | | |
193 | | - | |
194 | | - | |
| 193 | + | |
| 194 | + | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
| 197 | + | |
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
| |||
0 commit comments