Commit 36517ed
spec(047): Phase 3-final Batch E — Panel per-child attached props + WrapGrid
Wires Grid/Canvas/FlexPanel descriptors to use Batch A's additive
Panel<>.PerChildAttached callback. Each panel descriptor declares a
captured-free set lambda that reads the child element's attached-prop
hint (GridAttached / CanvasAttached / FlexAttached) and writes the
corresponding WinUI attached DP. Mirrors what the legacy MountXxx arms
do after each child mounts; closes the "descriptor-mounted children
stack at row 0 / column 0" known gap from PR #435 batch 8.
WrapGridDescriptor (new) — closes the Phase 3 batch 8 escape-hatch
("WrapGrid escape-hatched (needs per-child attached-prop hook)").
Mirrors MountWrapGrid: Orientation always written; MaximumRowsOrColumns
/ ItemWidth / ItemHeight via .OneWayConditional; per-child WrapGridAttached
(RowSpan / ColumnSpan) via PerChildAttached. Registered in the perf
DescriptorVariantFactory alongside the other panel descriptors.
FlexPanelDescriptor delegates to Reconciler.ApplyFlexAttached (promoted
from private to internal) so descriptor and legacy paths share the
"always apply — reset to defaults when no hint" semantics that protect
against stale Yoga config on pool-rented controls. CanvasDescriptor
delegates to Reconciler.ApplyCanvasPosition (already internal) so the
anchor-state ConditionalWeakTable + SizeChanged wiring is shared.
Each descriptor's PerChildAttached callback resets the relevant WinUI
attached DPs via ClearValue when the child has no hint, so a reordered
child whose attached prop drops between renders is not stuck with the
prior placement.
Documented gaps:
- RelativePanelDescriptor carved to Phase 4: the per-child callback
fires sequentially during the mount loop, so name references like
RightOf="foo" can't resolve against siblings that haven't been
mounted yet. Needs either a post-loop second-pass shape on Panel<>
or a dedicated NamedRelativePanel strategy. Doc updated in-place.
Self-test V1 ON/OFF Desc_ filter: 494/494 pass on both paths
(includes 4 new fixtures: Desc_Grid_AttachedRowColumn,
Desc_Canvas_AttachedLeftTop, Desc_FlexPanel_AttachedFlexProps,
Desc_WrapGrid_MountUpdate).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 34955db commit 36517ed
9 files changed
Lines changed: 515 additions & 33 deletions
File tree
- src/Reactor/Core
- V1Protocol/Descriptor/Descriptors
- tests
- Reactor.AppTests.Host/SelfTest
- Fixtures
- perf_bench/PerfBench.ControlModel/Variants
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3775 | 3775 | | |
3776 | 3776 | | |
3777 | 3777 | | |
3778 | | - | |
| 3778 | + | |
3779 | 3779 | | |
3780 | 3780 | | |
3781 | 3781 | | |
| |||
Lines changed: 23 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
22 | 23 | | |
23 | 24 | | |
24 | 25 | | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
30 | 45 | | |
31 | 46 | | |
32 | 47 | | |
| |||
Lines changed: 13 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
24 | | - | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
25 | 26 | | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
33 | 38 | | |
34 | 39 | | |
35 | 40 | | |
| |||
Lines changed: 32 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | 34 | | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
38 | 62 | | |
39 | 63 | | |
40 | 64 | | |
| |||
Lines changed: 14 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
23 | | - | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
24 | 30 | | |
25 | 31 | | |
26 | 32 | | |
| |||
Lines changed: 73 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
0 commit comments