Remove obsolete TextField factory (#390)

* Remove obsolete TextField factory

Remove the deprecated TextField factory alias so TextBox is the only text-input DSL factory. Update analyzer, localization scanner, docs, samples, gallery labels, and tests to use TextBox naming.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address TextBox naming feedback

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: codemonkeychris

CHANGELOG.md

@@ -29,18 +29,12 @@ to land under these conventions; subsequent specs follow this shape.
 
 ### Changed
 
-- **`TextField` → `TextBox` rename.** The record type
-  `TextFieldElement` is renamed to `TextBoxElement` for parity with
-  WinUI's `Microsoft.UI.Xaml.Controls.TextBox`. The `TextField(...)`
-  factory remains as a non-erroring `[Obsolete]` forwarding alias for
-  one release; call sites should migrate to `TextBox(...)`. The
-  alias will be removed in a future release.
+- **`TextBox` is now the only text-input factory.** The deprecated
+  `TextField(...)` forwarding alias has been removed after the
+  `TextFieldElement` → `TextBoxElement` rename. Use `TextBox(...)`.
 
 ### Deprecated
 
-- **`Factories.TextField(...)`** — use `Factories.TextBox(...)` instead.
-  Emits `CS0618` warning; will be removed in a future release.
-
 - **Spec 045 Phase 2 — §2.29 ready for human review gate.**
   Every Phase-2 implementation item in
   `docs/specs/tasks/045-docking-windows-implementation.md` is now

samples/CommandingDemo/App.cs

@@ -58,7 +58,7 @@ public override Element Render()
 
         // Tracks a one-shot selection we want to apply after a programmatic
         // text mutation (Cut/Paste/SelectAll). Cleared back to null as soon
-        // as the TextField consumes it, so normal user clicks don't trigger
+        // as the TextBox consumes it, so normal user clicks don't trigger
         // a programmatic selection write.
         var (pendingSelection, setPendingSelection) = UseState<(int Start, int Length)?>(null);
 
@@ -131,7 +131,7 @@ public override Element Render()
                 SelectionLength = pendingSelection?.Length,
             }).Margin(horizontal: 16, vertical: 8),
 
-            // Clear the pending selection once the TextField has had a chance
+            // Clear the pending selection once the TextBox has had a chance
             // to apply it. Runs after render; no-op when nothing pending.
             PendingSelectionConsumer(pendingSelection, setPendingSelection),
 

samples/Reactor.TestApp/Demos/InputGesturesDemo.cs

@@ -247,7 +247,7 @@ public override Element Render()
         var (name, setName) = UseState("");
         var (inputRef, requestFocus) = this.UseElementFocus();
 
-        // Deliberately NOT auto-focusing on mount in this gallery: a TextField
+        // Deliberately NOT auto-focusing on mount in this gallery: a TextBox
         // deep inside a ScrollView that takes focus pulls the viewport down via
         // WinUI's BringIntoView — and it re-triggers every time the window
         // regains foreground. Real apps that auto-focus a first input (login

…ControlPages/BasicInput/TextFieldPage.cs …y/ControlPages/BasicInput/TextBoxPage.cssamples/ReactorGallery/ControlPages/BasicInput/TextFieldPage.cs renamed to samples/ReactorGallery/ControlPages/BasicInput/TextBoxPage.cs samples/ReactorGallery/ControlPages/BasicInput/TextFieldPage.cs renamed to samples/ReactorGallery/ControlPages/BasicInput/TextBoxPage.cs

@@ -7,7 +7,7 @@
 
 namespace WinUIGalleryReactor.ControlPages.BasicInput;
 
-class TextFieldPage: Component
+class TextBoxPage: Component
 {
     public override Element Render()
     {
@@ -19,17 +19,17 @@ public override Element Render()
         var (urlText, setUrlText) = UseState("");
 
         return ScrollView(VStack(16,
-            PageHeader("TextField", "A single-line or multi-line plain text input field."),
+            PageHeader("TextBox", "A single-line or multi-line plain text input field."),
 
-            SampleCard("Basic TextField",
+            SampleCard("Basic TextBox",
                 VStack(8,
                     TextBox(text, v => setText(v), "Type here..."),
                     TextBlock($"Characters: {text.Length}").Foreground(Theme.SecondaryText)),
                 sourceCode: @"
 TextBox(text, v => setText(v), ""Type here..."")
 "),
 
-            SampleCard("Multiline TextField",
+            SampleCard("Multiline TextBox",
                 TextBox(multiline, v => setMultiline(v), "Enter multiple lines...")
                     .Set(tb => { tb.AcceptsReturn = true; tb.TextWrapping = TextWrapping.Wrap; })
                     .Height(120),
@@ -39,7 +39,7 @@ public override Element Render()
     .Height(120)
 "),
 
-            SampleCard("TextField with Header",
+            SampleCard("TextBox with Header",
                 TextBox(headerText, v => setHeaderText(v), "user@example.com").Header("Email"),
                 sourceCode: @"
 TextBox(headerText, v => setHeaderText(v), ""user@example.com"").Header(""Email"")

samples/ReactorGallery/ControlPages/DesignGuidance/SpacingPage.cs

@@ -75,7 +75,7 @@ static Element SpacingScaleSection()
     static Element MarginVsPaddingSection() =>
         SampleCard("Margin vs Padding",
             VStack(16,
-                TextBlock("Margin adds space outside an element; Padding adds space inside. In Reactor, .Padding() only works on Border and Control elements (Button, TextField, etc.). Layout panels like VStack and HStack only support .Margin() — wrap content in a Border if you need inner padding on a stack.")
+                TextBlock("Margin adds space outside an element; Padding adds space inside. In Reactor, .Padding() only works on Border and Control elements (Button, TextBox, etc.). Layout panels like VStack and HStack only support .Margin() — wrap content in a Border if you need inner padding on a stack.")
                     .Foreground(Theme.SecondaryText)
                     .FontSize(13)
                     .Set(tb => tb.TextWrapping = TextWrapping.Wrap)
@@ -140,7 +140,7 @@ static Element MarginVsPaddingSection() =>
                 VStack(2,
                     CompatRow("Border",    true,  true),
                     CompatRow("Button",    true,  true),
-                    CompatRow("TextField", true,  true),
+                    CompatRow("TextBox",   true,  true),
                     CompatRow("Text",      true,  false),
                     CompatRow("VStack",    true,  false),
                     CompatRow("HStack",    true,  false),
@@ -153,7 +153,7 @@ static Element MarginVsPaddingSection() =>
 VStack(children).Margin(16)
 Border(child).Margin(12)
 
-// Padding — only on Border and Control (Button, TextField, etc.)
+// Padding — only on Border and Control (Button, TextBox, etc.)
 Border(child).Padding(16)    // ✓ works
 Button(""Go"").Padding(12)    // ✓ works
 

samples/ReactorGallery/ControlRegistry.cs

@@ -27,7 +27,7 @@ public static class ControlRegistry
         new("RepeatButton", "A button that raises click events repeatedly while pressed.", "Basic Input", "\uE73A", "repeat-button", "RepeatButton.png"),
         new("Slider", "A control that lets the user select from a range of values by moving a thumb.", "Basic Input", "\uE73A", "slider", "Slider.png"),
         new("SplitButton", "A button with two parts: a primary action and a flyout menu.", "Basic Input", "\uE73A", "split-button", "SplitButton.png"),
-        new("TextField", "A single-line or multi-line plain text input field.", "Basic Input", "\uE73A", "text-field", "TextBox.png"),
+        new("TextBox", "A single-line or multi-line plain text input field.", "Basic Input", "\uE73A", "text-box", "TextBox.png"),
         new("ToggleButton", "A button that can be toggled between two states.", "Basic Input", "\uE73A", "toggle-button", "ToggleButton.png"),
         new("ToggleSwitch", "A switch that toggles between two mutually exclusive states.", "Basic Input", "\uE73A", "toggle-switch", "ToggleSwitch.png"),
 

samples/ReactorGallery/PageRouter.cs

@@ -25,7 +25,7 @@ static class PageRouter
         "repeat-button" => Component<ControlPages.BasicInput.RepeatButtonPage>(),
         "slider" => Component<ControlPages.BasicInput.SliderPage>(),
         "split-button" => Component<ControlPages.BasicInput.SplitButtonPage>(),
-        "text-field" => Component<ControlPages.BasicInput.TextFieldPage>(),
+        "text-box" => Component<ControlPages.BasicInput.TextBoxPage>(),
         "toggle-button" => Component<ControlPages.BasicInput.ToggleButtonPage>(),
         "toggle-switch" => Component<ControlPages.BasicInput.ToggleSwitchPage>(),
 

samples/apps/demo-script-tool/App/DemoScriptShell.cs

@@ -77,7 +77,7 @@ public override Element Render()
         // file watcher fires for a write WE just made, the disk hash equals
         // this value and we suppress the reload — otherwise our own debounced
         // save round-trips through the watcher, replaces the model with a new
-        // instance, re-syncs every TextField's local buffer, and resets the
+        // instance, re-syncs every TextBox's local buffer, and resets the
         // user's caret to position 0 mid-keystroke.
         var lastSyncedHashRef = UseRef<string?>(null);
         var announce = UseAnnounce();

samples/apps/dock-showcase/App.cs

@@ -329,16 +329,16 @@ private static DockNode BuildInitialLayout()
 
     // ── Editable pane content factories ────────────────────────────────
     //
-    // Each docked pane gets a TextField (or AcceptsReturn=multiline) so
+    // Each docked pane gets a TextBox (or AcceptsReturn=multiline) so
     // we can observe keyboard focus / input routing through the docking
     // host. Spec 045 §2.10 + §2.14 invariants we're stressing here:
-    //   • Clicking a TextField inside a pane gives it keyboard focus.
-    //   • Typing into the focused TextField does NOT trigger chord
+    //   • Clicking a TextBox inside a pane gives it keyboard focus.
+    //   • Typing into the focused TextBox does NOT trigger chord
     //     accelerators (Ctrl+Tab / Ctrl+W must reach the editor when it
     //     owns focus, not the host's KeyboardAccelerator surface).
-    //   • Tab inside a TextField should advance focus within the pane,
+    //   • Tab inside a TextBox should advance focus within the pane,
     //     not skip to the next docked group.
-    //   • A drag of the pane preserves the TextField's current value
+    //   • A drag of the pane preserves the TextBox's current value
     //     (controlled-input pattern through the §2.30 shape-only
     //     override + Memo-component state slot).
     //
@@ -349,10 +349,10 @@ private static Element EditorPane(string banner, string initial) =>
         Memo(ctx =>
         {
             var (text, setText) = ctx.UseState(initial);
-            // INTENTIONALLY MINIMAL: a single-line controlled TextField,
+            // INTENTIONALLY MINIMAL: a single-line controlled TextBox,
             // no .Set, no AcceptsReturn, no typography modifiers. This
             // isolates whether the focus-loss-on-keystroke bug is in
-            // the controlled-TextField/Memo-state base case or in one
+            // the controlled-TextBox/Memo-state base case or in one
             // of the optional modifiers / multi-line config.
             return VStack(6,
                 TextBlock(banner).SemiBold(),

src/Reactor.Analyzers/AccessibilityAnalyzers.cs

@@ -170,7 +170,7 @@ private static bool HasModifierInChain(SyntaxNode node, params string[] modifier
 
 /// <summary>
 /// REACTOR_A11Y_003: Form fields need a label for screen readers.
-/// Detects <c>TextField(...)</c>, <c>NumberBox(...)</c>, <c>PasswordBox(...)</c>,
+/// Detects <c>TextBox(...)</c>, <c>NumberBox(...)</c>, <c>PasswordBox(...)</c>,
 /// and <c>AutoSuggestBox(...)</c> factory calls without a <c>header:</c> named argument,
 /// <c>.AutomationName()</c>, or <c>.LabeledBy()</c> in the fluent chain.
 /// </summary>
@@ -197,7 +197,7 @@ public sealed class FormFieldLabelAnalyzer : DiagnosticAnalyzer
         description: Description);
 
     private static readonly ImmutableHashSet<string> FormFieldMethods =
-        ImmutableHashSet.Create("TextBox", "TextField", "NumberBox", "PasswordBox", "AutoSuggestBox");
+        ImmutableHashSet.Create("TextBox", "NumberBox", "PasswordBox", "AutoSuggestBox");
 
     public override ImmutableArray<DiagnosticDescriptor> SupportedDiagnostics =>
         ImmutableArray.Create(Rule);