Commit 5d4e81b
refactor: rename TextField -> TextBox for WinUI parity (#387)
* refactor: rename TextField -> TextBox for WinUI parity
Renames the record TextFieldElement to TextBoxElement and introduces
TextBox(...) as the canonical DSL factory. TextField(...) remains as a
[Obsolete(error: false)] forwarding alias and will be removed in a
follow-up PR. Updates analyzers, the loc scanner, samples, tests, doc
templates, and the regenerated docs/guide output. MaskedTextField is
intentionally deferred.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: align textbox-config snippet id with new naming
The bulk markdown rename used PowerShell's case-insensitive -replace,
which mangled the lowercase snippet id forms/textfield-config into
forms/TextBox-config in the template but left the App.cs snippet
marker untouched. Align both ends to lowercase forms/textbox-config
and rename the class to TextBoxConfigDemo.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* review: clear stale Header/Description, scan header positional, tidy test
- Reconciler.Update: clear TextBox.Header/Description via ClearValue when
the new element transitions them to null. Previously the value stayed
stuck on the control across re-renders.
- LocalizableStringScanner: also extract the positional header argument
(TextBox/TextField index 3); previously only the placeholder at
index 2 was scanned, so positional header strings silently lost
localization coverage.
- UseFocusTests: drop the unused `var el =` assignment flagged by
github-code-quality; the chained call still runs and registers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(test): adjust analyzer span for TextBox length
The FormFieldLabelAnalyzer test pinned the diagnostic span to columns
9..25 (16 chars, the length of TextField(value)). After the
TextField → TextBox rename, the call site is TextBox(value) — 14
chars — so the diagnostic now ends at column 23. Update the expected
span accordingly.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 28630aa commit 5d4e81b
204 files changed
Lines changed: 726 additions & 700 deletions
File tree
- docs
- _pipeline
- apps
- accessibility
- advanced
- collections
- commanding
- components
- controls
- dev-tooling
- dialogs-and-flyouts
- effects
- forms
- getting-started
- hooks
- input-and-gestures
- layout
- persistence
- readme
- recipe-command-palette
- recipe-login
- recipe-multi-step-form
- recipe-search-with-suggestions
- rules-of-reactor
- todo-app
- windows
- winforms-interop
- xaml-developers
- templates
- recipes
- guide
- recipes
- plugins/reactor/skills
- reactor-commanding
- reactor-design
- reactor-dsl/references
- reactor-forms
- reactor-getting-started
- reactor-input
- reactor-recipes/references
- samples
- CommandingDemo
- Reactor.TestApp/Demos
- ReactorCharting.Gallery/Samples
- ReactorGallery/ControlPages
- BasicInput
- DesignGuidance
- Media
- ReactorHostControlDemo
- TodoApp
- WinFormsInterop
- apps
- a11y-showcase
- chat/Chat.UI
- demo-script-tool/App/Components
- dock-showcase
- minesweeper/Components/Dialogs
- regedit
- Components/Dialogs
- validation-showcase
- skills
- design-docs
- recipes
- src
- Reactor.Analyzers
- Reactor.Cli/Loc
- Reactor
- Controls
- DataGrid
- Editors
- MaskedTextBox
- PropertyGrid
- Validation
- Core
- Elements
- Hooks
- tests
- Reactor.AppTests.Host
- Fixtures
- SelfTest/Fixtures
- Reactor.Tests
- AnalyzerTests
- Controls
- Elements
- Localization
- Reactor.WinFormsTests.Host
- perf_bench
- PerfBench.InteractivePool/InteractivePool.Reactor
- PerfBench.Priorities/Priorities.Reactor
- tools/Templates/templates/WinUIApp-CSharp
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
32 | 44 | | |
33 | 45 | | |
34 | 46 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
394 | 394 | | |
395 | 395 | | |
396 | 396 | | |
397 | | - | |
| 397 | + | |
398 | 398 | | |
399 | 399 | | |
400 | 400 | | |
| |||
544 | 544 | | |
545 | 545 | | |
546 | 546 | | |
547 | | - | |
| 547 | + | |
548 | 548 | | |
549 | 549 | | |
550 | 550 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
78 | | - | |
| 78 | + | |
79 | 79 | | |
80 | | - | |
| 80 | + | |
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| |||
110 | 110 | | |
111 | 111 | | |
112 | 112 | | |
113 | | - | |
| 113 | + | |
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
| 162 | + | |
163 | 163 | | |
164 | 164 | | |
165 | 165 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
141 | 141 | | |
142 | 142 | | |
143 | 143 | | |
144 | | - | |
| 144 | + | |
145 | 145 | | |
146 | 146 | | |
147 | 147 | | |
| |||
167 | 167 | | |
168 | 168 | | |
169 | 169 | | |
170 | | - | |
| 170 | + | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
| |||
196 | 196 | | |
197 | 197 | | |
198 | 198 | | |
199 | | - | |
| 199 | + | |
200 | 200 | | |
201 | 201 | | |
202 | 202 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| |||
219 | 219 | | |
220 | 220 | | |
221 | 221 | | |
222 | | - | |
| 222 | + | |
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | 119 | | |
120 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | | - | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | | - | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| |||
68 | 68 | | |
69 | 69 | | |
70 | 70 | | |
71 | | - | |
| 71 | + | |
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
82 | 82 | | |
83 | 83 | | |
84 | 84 | | |
85 | | - | |
| 85 | + | |
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| |||
0 commit comments