Skip to content

Commit b9b7452

Browse files
refactor: normalize ShowAddButton to IsAddButtonVisible
Rename ShowAddButton() -> IsAddButtonVisible() to align with WinUI's Is* naming convention for boolean properties. Keep IsTabStop() as-is (already matches WinUI naming). Old ShowAddButton kept as [Obsolete] shim for backward compat. Fixes #268 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 09c9dd9 commit b9b7452

4 files changed

Lines changed: 20 additions & 4 deletions

File tree

plugins/reactor/skills/reactor-dsl/references/reactor.api.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,8 @@ T.WithKey<T>(string key) → T
447447
T.WithToolTip<T>(Element tooltip) → T
448448
T.WithTransitions<T>(Transition[] transitions) → T
449449
T.XYFocusKeyboardNavigation<T>(XYFocusKeyboardNavigationMode mode) → T
450+
TabViewElement.IsAddButtonVisible(bool visible = true) → TabViewElement
450451
TabViewElement.Set(Action<TabView> configure) → TabViewElement
451-
TabViewElement.ShowAddButton(bool visible = true) → TabViewElement
452452
TeachingTipElement.Set(Action<TeachingTip> configure) → TeachingTipElement
453453
TemplatedFlipViewElement<T>.Set<T>(Action<FlipView> configure) → TemplatedFlipViewElement<T>
454454
TemplatedGridViewElement<T>.Set<T>(Action<GridView> configure) → TemplatedGridViewElement<T>

skills/reactor.api.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,8 @@ T.WithKey<T>(string key) → T
447447
T.WithToolTip<T>(Element tooltip) → T
448448
T.WithTransitions<T>(Transition[] transitions) → T
449449
T.XYFocusKeyboardNavigation<T>(XYFocusKeyboardNavigationMode mode) → T
450+
TabViewElement.IsAddButtonVisible(bool visible = true) → TabViewElement
450451
TabViewElement.Set(Action<TabView> configure) → TabViewElement
451-
TabViewElement.ShowAddButton(bool visible = true) → TabViewElement
452452
TeachingTipElement.Set(Action<TeachingTip> configure) → TeachingTipElement
453453
TemplatedFlipViewElement<T>.Set<T>(Action<FlipView> configure) → TemplatedFlipViewElement<T>
454454
TemplatedGridViewElement<T>.Set<T>(Action<GridView> configure) → TemplatedGridViewElement<T>

src/Reactor/Elements/ElementExtensions.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -865,9 +865,17 @@ public static GridViewElement SelectionMode(this GridViewElement el, ListViewSel
865865

866866
// ── TabView sugar ───────────────────────────────────────────────
867867

868-
public static TabViewElement ShowAddButton(this TabViewElement el, bool visible = true) =>
868+
/// <summary>
869+
/// Controls visibility of the "add tab" button in a TabView.
870+
/// </summary>
871+
public static TabViewElement IsAddButtonVisible(this TabViewElement el, bool visible = true) =>
869872
el with { IsAddTabButtonVisible = visible };
870873

874+
/// <inheritdoc cref="IsAddButtonVisible"/>
875+
[Obsolete("Use IsAddButtonVisible() — imperative 'Show*' naming is deprecated (see #268).")]
876+
public static TabViewElement ShowAddButton(this TabViewElement el, bool visible = true) =>
877+
el.IsAddButtonVisible(visible);
878+
871879
// ── Key ─────────────────────────────────────────────────────────
872880

873881
public static T WithKey<T>(this T el, string key) where T : Element =>

tests/Reactor.Tests/ElementExtensionsCoverageTests.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,15 @@ public void ListView_GridView_SelectionMode()
378378
}
379379

380380
[Fact]
381-
public void TabView_ShowAddButton_Sugar()
381+
public void TabView_IsAddButtonVisible_Sugar()
382+
{
383+
var el = TabView([]).IsAddButtonVisible(false);
384+
Assert.False(el.IsAddTabButtonVisible);
385+
}
386+
387+
[Fact]
388+
[Obsolete("Tests the deprecated ShowAddButton shim")]
389+
public void TabView_ShowAddButton_Sugar_Obsolete_Shim()
382390
{
383391
var el = TabView([]).ShowAddButton(false);
384392
Assert.False(el.IsAddTabButtonVisible);

0 commit comments

Comments
 (0)