Skip to content

docs(skill): list all Theme tokens, warn about hallucinated ones#287

Merged
codemonkeychris merged 2 commits into
mainfrom
fix/skill-theme-tokens
May 15, 2026
Merged

docs(skill): list all Theme tokens, warn about hallucinated ones#287
codemonkeychris merged 2 commits into
mainfrom
fix/skill-theme-tokens

Conversation

@sundaramramaswamy
Copy link
Copy Markdown
Collaborator

@sundaramramaswamy sundaramramaswamy commented May 14, 2026

Agents hallucinate Theme.Error, Theme.Success, Theme.ErrorText in 3/7 benchmark runs. These don't exist.

Changes:

  • Removed redundant condensed token table from getting-started (reactor-design already has the full reference with WinUI resource keys)
  • Added the nonexistent-token warning (Theme.Error etc.) to reactor-design's token reference section
  • Kept the warning + corrected examples in getting-started as a critical gotcha
  • Updated getting-started intro to point at reactor-design for the full token list

Fixes #277

Agents consistently hallucinate Theme.Error, Theme.Success, and
Theme.ErrorText which don't exist. Add complete token table with
categories and explicit warning about non-existent tokens.

Fixes #277

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@codemonkeychris codemonkeychris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this should be in the design skill rather than the getting started.

Keep the nonexistent-token warning in getting-started as a
critical gotcha, but move the full token table to the design
skill where it belongs alongside the existing token reference.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@sundaramramaswamy sundaramramaswamy force-pushed the fix/skill-theme-tokens branch from 224fd6e to 26eb6c0 Compare May 15, 2026 07:00
@sundaramramaswamy
Copy link
Copy Markdown
Collaborator Author

Addressed — moved the full token table out of getting-started. Only the nonexistent-token warning (Theme.Error/Theme.Success don't exist) remains as a critical gotcha. The warning callout was also added to the reactor-design skill's token reference section.

@codemonkeychris codemonkeychris merged commit 182b09d into main May 15, 2026
8 checks passed
@codemonkeychris codemonkeychris deleted the fix/skill-theme-tokens branch May 15, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skill: List actual Theme tokens (agents hallucinate Theme.Error/Success)

2 participants