docs(skill): add Canvas recipe, document name collision workaround#292
Merged
Conversation
The Canvas() factory shadows Canvas.SetLeft(). Document the correct Reactor pattern: use .Canvas(left, top) fluent modifier instead. Add complete Canvas recipe with positioning examples. Fixes #282 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
codemonkeychris
requested changes
May 14, 2026
Collaborator
codemonkeychris
left a comment
codemonkeychris
left a comment
There was a problem hiding this comment.
this shouldn't be in "getting started"... we have a model for separate recipes
Create canvas-positioning.cs recipe in reactor-recipes and remove inline Canvas section from getting-started SKILL.md. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
Addressed — moved the Canvas recipe out of getting-started into a new |
codemonkeychris
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Canvas()factory fromusing static FactoriesshadowsMicrosoft.UI.Xaml.Controls.Canvas, makingCanvas.SetLeft()inaccessible. Paint-app scored 13/100 (0/10 requirements) because of this.The correct Reactor pattern is
.Canvas(left, top)fluent modifier — no need for the static WinUI methods. Added complete Canvas recipe documenting this.Changes:
Canvas.SetLeft().Canvas(left, top),.CenterAt(x, y), shapesFixes #282