Skip to content

Commit 059fe6a

Browse files
author
reunion-maestro-bot
committed
Syncing content from committish f50080fe8b45d7b8688736637407250b0904d209
1 parent fe9f7d2 commit 059fe6a

2 files changed

Lines changed: 34 additions & 14 deletions

File tree

src/dxaml/xcp/dxaml/lib/Selector_Partial.cpp

Lines changed: 22 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@
1919
#include "PropertyPathParser.h"
2020
#include "PropertyPath.h"
2121
#include "Callback.h"
22+
#include "FrameworkUdk/Containment.h"
23+
24+
// Bug 61499680: [1.8 Servicing] ListView/Selector: E_BOUNDS crash in OnGettingFocus after bulk item refresh
25+
26+
#define WINAPPSDK_CHANGEID_61499680 61499680, WinAppSDK_1_8_7
2227

2328
using namespace xaml_data;
2429
using namespace DirectUI;
@@ -2406,9 +2411,24 @@ _Check_return_
24062411
shouldFocus = TRUE;
24072412
}
24082413

2409-
if (shouldFocus)
2414+
if (WinAppSdk::Containment::IsChangeEnabled<WINAPPSDK_CHANGEID_61499680>())
24102415
{
2411-
SetFocusedIndex(index);
2416+
if (shouldFocus || GetFocusedIndex() >= static_cast<INT>(nCount))
2417+
{
2418+
// Always update m_focusedIndex when we have focus. Also correct it when the Selector
2419+
// doesn't currently have focus (e.g. the focused container was recycled during an item
2420+
// removal) but m_focusedIndex is stale and points beyond the valid item range.
2421+
// In that case, if current focused index goes out of range, we should set the focused
2422+
// index to value asked by caller. Note that we have already verified that index is valid above.
2423+
SetFocusedIndex(index);
2424+
}
2425+
}
2426+
else
2427+
{
2428+
if (shouldFocus)
2429+
{
2430+
SetFocusedIndex(index);
2431+
}
24122432
}
24132433

24142434
if (GetFocusedIndex() == -1)

src/eng/Version.Details.xml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,39 +2,39 @@
22
<!-- Copyright (c) Microsoft Corporation. Licensed under the MIT License. See LICENSE in the project root for license information. -->
33
<Dependencies>
44
<ProductDependencies>
5-
<Dependency Name="Microsoft.WindowsAppSDK.Foundation.TransportPackage" Version="1.8.0-20260222.0.release">
5+
<Dependency Name="Microsoft.WindowsAppSDK.Foundation.TransportPackage" Version="1.8.0-20260415.0.release">
66
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDK</Uri>
7-
<Sha>9caca5e8b525dd734122d751e06d60dbf3268e22</Sha>
7+
<Sha>68a9959e7211bf10533958229c89594f4160ba4c</Sha>
88
</Dependency>
9-
<Dependency Name="Microsoft.ProjectReunion.InteractiveExperiences.TransportPackage" Version="1.8.0-stable-27108.1029.260124-1700.1">
9+
<Dependency Name="Microsoft.ProjectReunion.InteractiveExperiences.TransportPackage" Version="1.8.0-stable-27108.1043.260414-0920.1">
1010
<Uri>https://dev.azure.com/microsoft/LiftedIXP/_git/DCPP</Uri>
11-
<Sha>b68a9103d8543e623d349cb98d65c054375fcd0c</Sha>
11+
<Sha>a007e3a86ec33bad02efd987d6a4617e36c78c59</Sha>
1212
</Dependency>
13-
<Dependency Name="Microsoft.Internal.InteractiveExperiences" Version="1.8.0-stable-27108.1029.260124-1700.1">
13+
<Dependency Name="Microsoft.Internal.InteractiveExperiences" Version="1.8.0-stable-27108.1043.260414-0920.1">
1414
<Uri>https://dev.azure.com/microsoft/LiftedIXP/_git/DCPP</Uri>
15-
<Sha>b68a9103d8543e623d349cb98d65c054375fcd0c</Sha>
15+
<Sha>a007e3a86ec33bad02efd987d6a4617e36c78c59</Sha>
1616
</Dependency>
1717
<!-- Microsoft-WinUI-SDK subdirectory in WindowsAppSDKClosed (MSBuild and Visual Studio extensions for building, deploying, and debugging packaged applications.) -->
1818
<Dependency Name="Microsoft.Build.Msix" Version="1.7.0-release.20241114.0">
1919
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDKClosed</Uri>
2020
<Sha>bebdf37da96fd9d4c4a6588a8000ceee880cd373</Sha>
2121
</Dependency>
2222
<!-- Closed source binary (ex PTLS and WinUIEdit) -->
23-
<Dependency Name="Microsoft.Internal.WinUIDetails" Version="1.810.0-stable.20260126.0">
23+
<Dependency Name="Microsoft.Internal.WinUIDetails" Version="1.810.0-stable.20260325.0">
2424
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDKClosed</Uri>
25-
<Sha>e1c507a3c1688a9f36e5a66bf0715f17f552fc9b</Sha>
25+
<Sha>72fb44e58aaee8b88124a6cfea181e71c632808e</Sha>
2626
</Dependency>
2727
<Dependency Name="Microsoft.WindowsAppSDK.Base" Version="1.8.251216001">
2828
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDKAggregator</Uri>
2929
<Sha>66cd2dc7827ad19d84cd68743af8570d9aca1c93</Sha>
3030
</Dependency>
31-
<Dependency Name="Microsoft.WindowsAppSDK.Foundation" Version="1.8.260222000">
31+
<Dependency Name="Microsoft.WindowsAppSDK.Foundation" Version="1.8.260415000">
3232
<Uri>https://dev.azure.com/microsoft/ProjectReunion/_git/WindowsAppSDK</Uri>
33-
<Sha>9caca5e8b525dd734122d751e06d60dbf3268e22</Sha>
33+
<Sha>68a9959e7211bf10533958229c89594f4160ba4c</Sha>
3434
</Dependency>
35-
<Dependency Name="Microsoft.WindowsAppSDK.InteractiveExperiences" Version="1.8.260125001">
35+
<Dependency Name="Microsoft.WindowsAppSDK.InteractiveExperiences" Version="1.8.260415001">
3636
<Uri>https://dev.azure.com/microsoft/LiftedIXP/_git/DCPP</Uri>
37-
<Sha>b68a9103d8543e623d349cb98d65c054375fcd0c</Sha>
37+
<Sha>a007e3a86ec33bad02efd987d6a4617e36c78c59</Sha>
3838
</Dependency>
3939
</ProductDependencies>
4040
<ToolsetDependencies>

0 commit comments

Comments
 (0)