Skip to content

Commit 1e32e17

Browse files
Copilotchhwang
andcommitted
Address code review comments
- Remove duplicate static getMPIRank() and getMPISize() functions - Add full namespace qualification to GTEST_SKIP macro Co-authored-by: chhwang <8018170+chhwang@users.noreply.github.com>
1 parent e227fdc commit 1e32e17

2 files changed

Lines changed: 1 addition & 5 deletions

File tree

test/framework.cc

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,6 @@ static void finalizeMPI() {
3737
g_mpi_initialized = false;
3838
}
3939

40-
static int getMPIRank() { return g_mpi_rank; }
41-
42-
static int getMPISize() { return g_mpi_size; }
43-
4440
static bool isMainProcess() { return g_mpi_rank == 0; }
4541

4642
// Public utility functions for test output

test/framework.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -397,7 +397,7 @@ class SkipHelper {
397397
std::ostringstream message_;
398398
};
399399

400-
#define GTEST_SKIP() ::SkipHelper(__FILE__, __LINE__)
400+
#define GTEST_SKIP() ::mscclpp::test::SkipHelper(__FILE__, __LINE__)
401401

402402
// Create a namespace alias for compatibility with GTest code
403403
namespace testing = ::mscclpp::test;

0 commit comments

Comments
 (0)