Skip to content

Commit 3962574

Browse files
authored
Address installation issue in some env (#750)
This pull request updates the way the `nlohmann/json` library is fetched and upgrades it to a newer version in both the main build and test configuration files. Addressed installation issue in some env
1 parent e2acf7f commit 3962574

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,11 @@ if(MSCCLPP_USE_IB)
169169
endif()
170170
find_package(NUMA REQUIRED)
171171
find_package(Threads REQUIRED)
172-
173172
include(FetchContent)
174-
FetchContent_Declare(json URL https://github.com/nlohmann/json/releases/download/v3.11.3/json.tar.xz)
173+
FetchContent_Declare(json
174+
GIT_REPOSITORY https://github.com/nlohmann/json.git
175+
GIT_TAG v3.12.0
176+
)
175177
FetchContent_MakeAvailable(json)
176178

177179
if("${INSTALL_PREFIX}" STREQUAL "")

test/mscclpp-test/CMakeLists.txt

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
# Copyright (c) Microsoft Corporation.
22
# Licensed under the MIT license.
33

4-
FetchContent_Declare(json URL https://github.com/nlohmann/json/releases/download/v3.11.2/json.tar.xz)
4+
FetchContent_Declare(json
5+
GIT_REPOSITORY https://github.com/nlohmann/json.git
6+
GIT_TAG v3.12.0
7+
)
58
FetchContent_MakeAvailable(json)
69

710
function(add_mscclpp_test_executable name sources)

0 commit comments

Comments
 (0)