Address code review feedback

- Move PerfTestResult struct definition outside vector declaration
- Move getCurrentTimestamp to anonymous namespace
- Add documentation for GTEST_SKIP macro explaining RAII pattern

Co-authored-by: chhwang <8018170+chhwang@users.noreply.github.com>

Author: Copilot

test/framework.hpp

@@ -373,6 +373,11 @@ void reportSuccess();
   } while (0)
 
 // Helper class for GTEST_SKIP functionality
+// This class uses RAII (Resource Acquisition Is Initialization) pattern:
+// - The constructor records file and line information
+// - The stream operator (<<) allows appending a skip message
+// - The destructor throws an exception to skip the test
+// This enables usage like: GTEST_SKIP() << "Reason for skipping";
 class SkipHelper {
  public:
   explicit SkipHelper(const char* file, int line) : file_(file), line_(line) {}
@@ -397,6 +402,8 @@ class SkipHelper {
   std::ostringstream message_;
 };
 
+// Test skip macro - throws exception to skip test execution
+// Usage: GTEST_SKIP() << "Optional skip message";
 #define GTEST_SKIP() ::mscclpp::test::SkipHelper(__FILE__, __LINE__)
 
 // Create a namespace alias for compatibility with GTest code

test/perf/framework.cc

@@ -11,24 +11,29 @@
 namespace mscclpp {
 namespace test {
 
-// Global state for performance test results
-static std::vector < struct PerfTestResult {
+// Performance test result structure
+struct PerfTestResult {
   std::string test_name;
   std::string test_category;
   std::map<std::string, std::string> test_params;
   nlohmann::ordered_json metrics;
   int num_processes;
   int process_rank;
   std::string timestamp;
-} > g_perf_results;
+};
+
+// Global state for performance test results
+static std::vector<PerfTestResult> g_perf_results;
 
-static std::string getCurrentTimestamp() {
+namespace {
+std::string getCurrentTimestamp() {
   auto now = std::chrono::system_clock::now();
   auto time_t = std::chrono::system_clock::to_time_t(now);
   std::stringstream ss;
   ss << std::put_time(std::gmtime(&time_t), "%Y-%m-%dT%H:%M:%S");
   return ss.str();
 }
+}  // namespace
 
 void recordResult(const std::string& test_name, const std::string& test_category, const nlohmann::ordered_json& metrics,
                   const std::map<std::string, std::string>& test_params) {