Address review comments: doc comments, typo, remove Reserved field

- Correct QUIC_WORKER_STATISTICS field comments to match implementation
- Fix typo 'that as not' -> 'that has not'
- Remove the Reserved padding field and reorder QUIC_WORKER_STATISTICS so the
  64-bit fields precede IdealProcessor (no manual padding needed)
- Zero output stats so any trailing padding bytes are deterministic
- Regenerate Rust FFI bindings for the new layout

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: guhetier

src/inc/msquic.h

@@ -376,10 +376,9 @@ typedef struct QUIC_XDP_MAP_CONFIG {
 // Per-worker statistics.
 //
 typedef struct QUIC_WORKER_STATISTICS {
+    uint64_t CumulativeActiveTimeUs;     // total time the worker spent active (not idle)
+    uint64_t CumulativeWallTimeUs;       // wall time since the worker thread started
     uint16_t IdealProcessor;             // CPU the partition is affinitized to
-    uint8_t Reserved[6];                 // Padding for alignment
-    uint64_t CumulativeActiveTimeUs;     // total time IsActive == TRUE
-    uint64_t CumulativeWallTimeUs;       // wall time since worker was created
 
     // -- append-only beyond this point --
 } QUIC_WORKER_STATISTICS;

src/platform/platform_worker.c

@@ -890,8 +890,9 @@ CxPlatWorkerPoolGetStatistics(
     const uint64_t Now = CxPlatTimeUs64();
 
     //
-    // Note: The active time that as not been accumulated yet is ignored.
+    // Note: The active time that has not been accumulated yet is ignored.
     //
+    CxPlatZeroMemory(Stats, WorkerCount * sizeof(QUIC_WORKER_STATISTICS));
     for (uint32_t i = 0; i < WorkerCount; i++) {
         CXPLAT_WORKER* Worker = &WorkerPool->Workers[i];
         Stats[i].IdealProcessor = Worker->IdealProcessor;

src/rs/ffi/linux_bindings.rs

@@ -521,24 +521,21 @@ const _: () = {
 #[repr(C)]
 #[derive(Debug, Copy, Clone)]
 pub struct QUIC_WORKER_STATISTICS {
-    pub IdealProcessor: u16,
-    pub Reserved: [u8; 6usize],
     pub CumulativeActiveTimeUs: u64,
     pub CumulativeWallTimeUs: u64,
+    pub IdealProcessor: u16,
 }
 #[allow(clippy::unnecessary_operation, clippy::identity_op)]
 const _: () = {
     ["Size of QUIC_WORKER_STATISTICS"][::std::mem::size_of::<QUIC_WORKER_STATISTICS>() - 24usize];
     ["Alignment of QUIC_WORKER_STATISTICS"]
         [::std::mem::align_of::<QUIC_WORKER_STATISTICS>() - 8usize];
-    ["Offset of field: QUIC_WORKER_STATISTICS::IdealProcessor"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, IdealProcessor) - 0usize];
-    ["Offset of field: QUIC_WORKER_STATISTICS::Reserved"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, Reserved) - 2usize];
     ["Offset of field: QUIC_WORKER_STATISTICS::CumulativeActiveTimeUs"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeActiveTimeUs) - 8usize];
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeActiveTimeUs) - 0usize];
     ["Offset of field: QUIC_WORKER_STATISTICS::CumulativeWallTimeUs"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeWallTimeUs) - 16usize];
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeWallTimeUs) - 8usize];
+    ["Offset of field: QUIC_WORKER_STATISTICS::IdealProcessor"]
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, IdealProcessor) - 16usize];
 };
 #[repr(C)]
 #[derive(Debug, Copy, Clone)]

src/rs/ffi/win_bindings.rs

@@ -519,24 +519,21 @@ const _: () = {
 #[repr(C)]
 #[derive(Debug, Copy, Clone)]
 pub struct QUIC_WORKER_STATISTICS {
-    pub IdealProcessor: u16,
-    pub Reserved: [u8; 6usize],
     pub CumulativeActiveTimeUs: u64,
     pub CumulativeWallTimeUs: u64,
+    pub IdealProcessor: u16,
 }
 #[allow(clippy::unnecessary_operation, clippy::identity_op)]
 const _: () = {
     ["Size of QUIC_WORKER_STATISTICS"][::std::mem::size_of::<QUIC_WORKER_STATISTICS>() - 24usize];
     ["Alignment of QUIC_WORKER_STATISTICS"]
         [::std::mem::align_of::<QUIC_WORKER_STATISTICS>() - 8usize];
-    ["Offset of field: QUIC_WORKER_STATISTICS::IdealProcessor"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, IdealProcessor) - 0usize];
-    ["Offset of field: QUIC_WORKER_STATISTICS::Reserved"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, Reserved) - 2usize];
     ["Offset of field: QUIC_WORKER_STATISTICS::CumulativeActiveTimeUs"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeActiveTimeUs) - 8usize];
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeActiveTimeUs) - 0usize];
     ["Offset of field: QUIC_WORKER_STATISTICS::CumulativeWallTimeUs"]
-        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeWallTimeUs) - 16usize];
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, CumulativeWallTimeUs) - 8usize];
+    ["Offset of field: QUIC_WORKER_STATISTICS::IdealProcessor"]
+        [::std::mem::offset_of!(QUIC_WORKER_STATISTICS, IdealProcessor) - 16usize];
 };
 #[repr(C)]
 #[derive(Debug, Copy, Clone)]