Skip to content

Commit 2bf46bc

Browse files
authored
Refactor tvpTypeName and SQL statement escaping
Updated tvpTypeName to use RandomUtil for identifier generation and ensured proper escaping in SQL statements.
1 parent e3bf056 commit 2bf46bc

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/java/com/microsoft/sqlserver/jdbc/callablestatement/CallableStatementTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public class CallableStatementTest extends AbstractTest {
107107
.escapeIdentifier(RandomUtil.getIdentifier("streamGetterSetterProc"));
108108
private static String tvpProcName = AbstractSQLGenerator
109109
.escapeIdentifier(RandomUtil.getIdentifier("TVPProc"));
110-
private static String tvpTypeName = "TVPType";
110+
private static String tvpTypeName = RandomUtil.getIdentifier("TVPType");
111111

112112
/**
113113
* Setup before test
@@ -1135,8 +1135,8 @@ public void testCallableStatementParameterNameAPIs() throws Exception {
11351135
}
11361136
try (Statement stmt = connection.createStatement()) {
11371137
// Create a TVP type and procedure if not exists
1138-
stmt.execute("CREATE TYPE " + tvpTypeName + " AS TABLE (id INT)");
1139-
stmt.execute("CREATE PROCEDURE " + tvpProcName + " @tvp " + tvpTypeName + " READONLY, @val XML = NULL OUTPUT AS SELECT 1");
1138+
stmt.execute("CREATE TYPE " + AbstractSQLGenerator.escapeIdentifier(tvpTypeName) + " AS TABLE (id INT)");
1139+
stmt.execute("CREATE PROCEDURE " + tvpProcName + " @tvp " + AbstractSQLGenerator.escapeIdentifier(tvpTypeName) + " READONLY, @val XML = NULL OUTPUT AS SELECT 1");
11401140
}
11411141

11421142
try (SQLServerCallableStatement cs = (SQLServerCallableStatement) connection.prepareCall("{call " + tvpProcName + " (?, ?)}")) {

0 commit comments

Comments
 (0)