ResultSet.getTimestamp() returns incorrect point in time for historical dates

[m-van-tilburg]

Driver version

12.10.1.jre11.

SQL Server version

Microsoft SQL Server 2022 (RTM-CU20-GDR) (KB5065220) - 16.0.4212.1 (X64).

Client Operating System

Windows 10 Pro.

JAVA/JVM version

21.0.2.

Table schema

CREATE TABLE [timestamp_test] (
[my_id] [BIGINT] NOT NULL,
[my_timestamp] [datetime2],
CONSTRAINT pk_timestamp_test PRIMARY KEY CLUSTERED ( [my_id] )
);

Problem description

ResultSet.getTimestamp() returns incorrect point in time for historical dates.

Expected behavior

A Timestamp that matches the datetime2 column value in the database.

Actual behavior

A Timestamp that appears to be incorrectly created using the Julian calendar instead of the (proleptic) Gregorian calendar.

Any other details that can be helpful

See attached reproduction source code:

MssqlJdbcTest.java

[m-van-tilburg]

I reported a similar issue in the PostgreSQL JDBC driver, the comments in that issue might help to get a better understanding of the problem.

[machavan]

Thanks @m-van-tilburg , we are looking into this.

[m-van-tilburg]

Is there anyway I can help with this issue? In the mean time a pull request containing a fix and related unit tests has been linked to the similar pgjdbc issue, maybe it can be used as inspiration.

[muskan124947]

Sure, we’ll review the referenced pull request and see how the approach can be leveraged here.