Stop publishing when the submission carries no pricing

Addresses Copilot review feedback on #175.

TryPreservePricing treated a missing pricing object as preservable and let it
through, but the API rejects such an update with "Pricing data was not provided
in the request.". Publish would have surfaced a raw 400 from deep inside
UpdateSubmissionAsync instead of stopping with the same actionable guidance it
already gives for a non round-trippable price id.

Missing pricing is now handled by the existing stop path, with wording specific
to that case, and --priceId still recovers it.

The fixtures were modelling something the API never returns. Every real app
submission comes back carrying a pricing object, so AddDefaultFakeSubmission now
defaults to one instead of to null, which also means the existing publish tests
exercise a realistic payload and assert the price survives. A withoutPricing
switch covers the degenerate case on purpose.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 06440e13-c898-4e58-8764-d7abf304d9d8

Author: azchohfi

MSStore.CLI.UnitTests/BaseCommandLineTest.cs

@@ -410,14 +410,17 @@ internal void AddFakeAccount(AccountEnrollment? accountEnrollment)
                 });
         }
 
-        protected void AddDefaultFakeSubmission(string listingDescription = "BaseListingDescription", Pricing? pricing = null)
+        protected void AddDefaultFakeSubmission(string listingDescription = "BaseListingDescription", Pricing? pricing = null, bool withoutPricing = false)
         {
             var fakeSubmission = new DevCenterSubmission
             {
                 Id = "123456789",
                 ApplicationCategory = DevCenterApplicationCategory.NotSet,
                 FileUploadUrl = "https://azureblob.com/fileupload",
-                Pricing = pricing,
+
+                // Every real app submission comes back carrying a pricing object, so that is what
+                // the fixtures model. 'withoutPricing' exists only to cover the degenerate case.
+                Pricing = withoutPricing ? null : pricing ?? new Pricing { PriceId = PriceIds.Free },
                 ApplicationPackages =
                     [
                         new ApplicationPackage
@@ -574,9 +577,9 @@ internal void InitDefaultFlightSubmissionStatusResponseQueue()
                 });
         }
 
-        protected void AddDefaultFakeSuccessfulSubmission(Pricing? pricing = null)
+        protected void AddDefaultFakeSuccessfulSubmission(Pricing? pricing = null, bool withoutPricing = false)
         {
-            AddDefaultFakeSubmission(pricing: pricing);
+            AddDefaultFakeSubmission(pricing: pricing, withoutPricing: withoutPricing);
             InitDefaultSubmissionStatusResponseQueue();
 
             FakeStorePackagedAPI

MSStore.CLI.UnitTests/PublishCommandPricingUnitTests.cs

@@ -37,12 +37,13 @@ public void Init()
         private async Task<((string Output, string Error) Result, DevCenterSubmission? Sent)> PublishMsixAsync(
             Pricing? pricing,
             int? expectedExitCode = 0,
+            bool withoutPricing = false,
             params string[] extraArgs)
         {
             var path = CopyFilesRecursively("MSIXProject");
             var msixPath = Path.Combine(path, "test.msix");
 
-            AddDefaultFakeSuccessfulSubmission(pricing);
+            AddDefaultFakeSuccessfulSubmission(pricing, withoutPricing);
 
             DevCenterSubmission? sent = null;
             FakeStorePackagedAPI
@@ -135,6 +136,7 @@ public async Task PublishWithPriceIdShouldRecoverAProductWhoseBasePriceIsNotRoun
             var (result, sent) = await PublishMsixAsync(
                 new Pricing { PriceId = "Base" },
                 0,
+                false,
                 "--priceId",
                 "Tier1012");
 
@@ -148,27 +150,34 @@ public async Task PublishWithPriceIdShouldOverrideAnExistingTier()
             var (_, sent) = await PublishMsixAsync(
                 new Pricing { PriceId = "Tier1012" },
                 0,
+                false,
                 "--priceId",
                 "Tier1424");
 
             sent!.Pricing!.PriceId.Should().Be("Tier1424");
         }
 
         [TestMethod]
-        public async Task PublishShouldSucceedWhenTheProductHasNoPricingAtAll()
+        public async Task PublishShouldStopWhenTheProductHasNoPricingAtAll()
         {
-            var (result, sent) = await PublishMsixAsync(null);
+            // Missing pricing is just as unsendable as a bad price id: the API answers
+            // "Pricing data was not provided in the request.". Fail fast with guidance instead
+            // of letting UpdateSubmissionAsync surface a raw 400.
+            var (result, sent) = await PublishMsixAsync(null, -1, withoutPricing: true);
 
-            result.Error.Should().Contain("Submission commit success! Here is some data:");
-            sent!.Pricing.Should().BeNull();
+            result.Error.Should().Contain("Could not preserve this product's price");
+            result.Error.Should().Contain("returned no pricing for this product");
+            result.Error.Should().Contain("--priceId");
+
+            sent.Should().BeNull();
         }
 
         [TestMethod]
         public async Task PublishWithPriceIdShouldApplyEvenWhenTheProductHasNoPricingAtAll()
         {
             // The API rejects an update that omits pricing, so an explicit price has to be
             // materialized rather than silently dropped.
-            var (result, sent) = await PublishMsixAsync(null, 0, "--priceId", "Tier1012");
+            var (result, sent) = await PublishMsixAsync(null, 0, true, "--priceId", "Tier1012");
 
             result.Error.Should().Contain("Submission commit success! Here is some data:");
             sent!.Pricing.Should().NotBeNull();

MSStore.CLI/Helpers/IStorePackagedAPIExtensions.cs

@@ -824,16 +824,21 @@ internal static bool TryPreservePricing(IAnsiConsole ansiConsole, DevCenterSubmi
                 return true;
             }
 
-            if (submission.Pricing == null || PriceIds.IsRoundTrippable(submission.Pricing.PriceId))
+            if (submission.Pricing != null && PriceIds.IsRoundTrippable(submission.Pricing.PriceId))
             {
                 return true;
             }
 
-            var priceId = submission.Pricing.PriceId;
-            logger.LogError("Cannot preserve the product's price. The API returned PriceId '{PriceId}', which it does not accept back on update.", priceId);
+            // A missing pricing object is just as unsendable as a bad price id - the API answers
+            // "Pricing data was not provided in the request." - so stop here with usable guidance
+            // rather than letting the update fail with a raw 400 further down.
+            var priceId = submission.Pricing?.PriceId;
+            logger.LogError("Cannot preserve the product's price. The submission has PriceId '{PriceId}', which the API does not accept on update.", priceId);
 
             ansiConsole.MarkupLine("[red bold]Could not preserve this product's price.[/]");
-            ansiConsole.MarkupLine($"The Store returned a base price of [yellow]'{(priceId ?? "<empty>").EscapeMarkup()}'[/], which the submission API refuses on update. This happens when the price is managed per market from Partner Center.");
+            ansiConsole.MarkupLine(submission.Pricing == null
+                ? "The Store returned no pricing for this product, and the submission API rejects an update that does not carry one."
+                : $"The Store returned a base price of [yellow]'{(priceId ?? "<empty>").EscapeMarkup()}'[/], which the submission API refuses on update. This happens when the price is managed per market from Partner Center.");
             ansiConsole.MarkupLine("Publishing would reset the product to [bold]Free[/], so it has been stopped instead.");
             ansiConsole.MarkupLine("Re-run with [green]--priceId[/] to state the base price explicitly (for example [green]--priceId Tier1012[/]), or publish this submission from Partner Center.");