Revert "Add X509CompareDateTime Function (#1355)"

This reverts commit 05c7a52.

Author: Flickdm

CryptoPkg/CryptoPkg.dec

@@ -292,7 +292,6 @@
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceEcGetPublicKeyFromX509|FALSE|BOOLEAN|0xcc
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceEcDsaSign|FALSE|BOOLEAN|0xcd
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceEcDsaVerify|FALSE|BOOLEAN|0xce
-  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509CompareDateTime|FALSE|BOOLEAN|0xcf
 # AUTOGEN ENDS
 # ****************************************************************************
 # MU_CHANGE [END]

CryptoPkg/Include/Protocol/Crypto.h

@@ -20,7 +20,7 @@
 /// the EDK II Crypto Protocol is extended, this version define must be
 /// increased.
 ///
-#define EDKII_CRYPTO_VERSION  19 // MU_CHANGE
+#define EDKII_CRYPTO_VERSION  18 // MU_CHANGE
 
 ///
 /// EDK II Crypto Protocol forward declaration
@@ -44,7 +44,7 @@ UINTN
 // AUTOGENERATED BY CryptoBinPkg\Driver\Packaging\generate_cryptodriver.py
 // AUTOGENED AS temp_Crypto.h
 // DO NOT MODIFY
-// GENERATED ON: 2025-05-08 21:32:24.776904
+// GENERATED ON: 2024-04-08 11:12:11.528450
 
 // =============================================================================
 //     HMACSHA256 functions
@@ -2295,27 +2295,6 @@ BOOLEAN
   IN OUT UINTN      *DateTimeSize
   );
 
-/**
-  Compare DateTime1 object and DateTime2 object.
-  If DateTime1 is NULL, then return -2.
-  If DateTime2 is NULL, then return -2.
-  If DateTime1 == DateTime2, then return 0
-  If DateTime1 > DateTime2, then return 1
-  If DateTime1 < DateTime2, then return -1
-  @param[in]      DateTime1         Pointer to a DateTime Ojbect
-  @param[in]      DateTime2         Pointer to a DateTime Object
-  @retval  0      If DateTime1 == DateTime2
-  @retval  1      If DateTime1 > DateTime2
-  @retval  -1     If DateTime1 < DateTime2
-**/
-// FROM BaseCryptLib.h:2817
-typedef
-INT32
-(EFIAPI *EDKII_CRYPTO_X509_COMPARE_DATE_TIME)(
-  IN  CONST  VOID  *DateTime1,
-  IN  CONST  VOID  *DateTime2
-  );
-
 /**
   Retrieve the Key Usage from one X.509 certificate.
   @param[in]      Cert             Pointer to the DER-encoded X509 certificate.
@@ -4793,7 +4772,6 @@ struct _EDKII_CRYPTO_PROTOCOL {
   EDKII_CRYPTO_EC_GET_PUBLIC_KEY_FROM_X509            EcGetPublicKeyFromX509;
   EDKII_CRYPTO_EC_DSA_SIGN                            EcDsaSign;
   EDKII_CRYPTO_EC_DSA_VERIFY                          EcDsaVerify;
-  EDKII_CRYPTO_X509_COMPARE_DATE_TIME                 X509CompareDateTime;
 };
 
 // AUTOGEN ENDS

CryptoPkg/Library/BaseCryptLibOnProtocolPpi/CryptLib.c

@@ -100,7 +100,7 @@ CryptoServiceNotAvailable (
 // AUTOGENERATED BY CryptoBinPkg\Driver\Packaging\generate_cryptodriver.py
 // AUTOGENED AS temp_CryptLib.c
 // DO NOT MODIFY
-// GENERATED ON: 2025-05-08 21:32:26.186748
+// GENERATED ON: 2024-04-08 11:12:11.608999
 
 // =============================================================================
 //     HMACSHA256 functions
@@ -5212,30 +5212,6 @@ EcDsaVerify (
   CALL_CRYPTO_SERVICE (EcDsaVerify, (EcContext, HashNid, MessageHash, HashSize, Signature, SigSize), FALSE);
 }
 
-/**
-  Compare DateTime1 object and DateTime2 object.
-  If DateTime1 is NULL, then return -2.
-  If DateTime2 is NULL, then return -2.
-  If DateTime1 == DateTime2, then return 0
-  If DateTime1 > DateTime2, then return 1
-  If DateTime1 < DateTime2, then return -1
-  @param[in]      DateTime1         Pointer to a DateTime Ojbect
-  @param[in]      DateTime2         Pointer to a DateTime Object
-  @retval  0      If DateTime1 == DateTime2
-  @retval  1      If DateTime1 > DateTime2
-  @retval  -1     If DateTime1 < DateTime2
-**/
-// See BaseCryptLib.h:2817
-INT32
-EFIAPI
-X509CompareDateTime (
-  IN  CONST  VOID  *DateTime1,
-  IN  CONST  VOID  *DateTime2
-  )
-{
-  CALL_CRYPTO_SERVICE (X509CompareDateTime, (DateTime1, DateTime2), 0);
-}
-
 // AUTOGEN ENDS
 // ****************************************************************************
 // MU_CHANGE [END]

CryptoPkg/Library/BaseCryptLibOnProtocolPpi/DxeCryptLib.inf

@@ -141,7 +141,6 @@
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509GetExtensionData # CONSUMES
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509GetValidity # CONSUMES
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509FormatDateTime # CONSUMES
-  gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509CompareDateTime # CONSUMES
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509GetKeyUsage # CONSUMES
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509GetExtendedKeyUsage # CONSUMES
   gEfiCryptoPkgTokenSpaceGuid.PcdCryptoServiceX509VerifyCertChain # CONSUMES