Skip to content

Commit 245772a

Browse files
committed
Revert "Adding support of building BaseTool for Windows ARM (#323)"
This reverts commit ba628fa.
1 parent 757745d commit 245772a

File tree

3 files changed

+5
-16
lines changed

3 files changed

+5
-16
lines changed

BaseTools/Source/C/GenFw/GenFw.c

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1141,7 +1141,7 @@ Routine Description:
11411141
UINT32 OutputFileLength;
11421142
UINT8 *InputFileBuffer;
11431143
UINT32 InputFileLength;
1144-
PD_RUNTIME_FUNCTION *RuntimeFunction; // MU_CHANGE: Resolve definition conflict for ARM
1144+
RUNTIME_FUNCTION *RuntimeFunction;
11451145
UNWIND_INFO *UnwindInfo;
11461146
STATUS Status;
11471147
BOOLEAN ReplaceFlag;
@@ -2555,10 +2555,8 @@ Routine Description:
25552555
//
25562556
memset (SectionHeader->Name, 0, sizeof (SectionHeader->Name));
25572557

2558-
// MU_CHANGE Starts: Resolve definition conflict for ARM
2559-
RuntimeFunction = (PD_RUNTIME_FUNCTION *)(FileBuffer + SectionHeader->PointerToRawData);
2560-
for (Index1 = 0; Index1 < Optional64->DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_EXCEPTION].Size / sizeof (PD_RUNTIME_FUNCTION); Index1++, RuntimeFunction++) {
2561-
// MU_CHANGE Ends
2558+
RuntimeFunction = (RUNTIME_FUNCTION *)(FileBuffer + SectionHeader->PointerToRawData);
2559+
for (Index1 = 0; Index1 < Optional64->DataDirectory[EFI_IMAGE_DIRECTORY_ENTRY_EXCEPTION].Size / sizeof (RUNTIME_FUNCTION); Index1++, RuntimeFunction++) {
25622560
SectionHeader = (EFI_IMAGE_SECTION_HEADER *) ((UINT8 *) &(PeHdr->Pe32.OptionalHeader) + PeHdr->Pe32.FileHeader.SizeOfOptionalHeader);
25632561
for (Index2 = 0; Index2 < PeHdr->Pe32.FileHeader.NumberOfSections; Index2++, SectionHeader++) {
25642562
if (RuntimeFunction->UnwindInfoAddress >= SectionHeader->VirtualAddress && RuntimeFunction->UnwindInfoAddress < (SectionHeader->VirtualAddress + SectionHeader->SizeOfRawData)) {
@@ -2570,7 +2568,7 @@ Routine Description:
25702568
break;
25712569
}
25722570
}
2573-
memset (RuntimeFunction, 0, sizeof (PD_RUNTIME_FUNCTION)); // MU_CHANGE: Resolve definition conflict for ARM
2571+
memset (RuntimeFunction, 0, sizeof (RUNTIME_FUNCTION));
25742572
}
25752573
//
25762574
// Zero Exception Table

BaseTools/Source/C/Makefiles/ms.common

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,15 +69,6 @@ SYS_LIB_PATH = $(EDK_TOOLS_PATH)\Lib\Win64
6969
# Note: These are bit-width conversion related warning suppressions.
7070
CFLAGS = $(CFLAGS) /wd4267 /wd4244 /wd4334
7171

72-
# MU_CHANGE Starts: Adding support to build base tools for ARM
73-
!ELSEIF "$(HOST_ARCH)"=="ARM"
74-
ARCH_INCLUDE = $(EDK2_PATH)\MdePkg\Include\Arm
75-
BIN_PATH = $(BASE_TOOLS_PATH)\Bin\Win32
76-
LIB_PATH = $(BASE_TOOLS_PATH)\Lib\Win32
77-
SYS_BIN_PATH = $(EDK_TOOLS_PATH)\Bin\Win32
78-
SYS_LIB_PATH = $(EDK_TOOLS_PATH)\Lib\Win32
79-
# MU_CHANGE Ends
80-
8172
!ELSE
8273
!ERROR "Bad HOST_ARCH"
8374
!ENDIF

MdePkg/Include/IndustryStandard/PeImage.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -700,7 +700,7 @@ typedef struct {
700700
UINT32 FunctionStartAddress;
701701
UINT32 FunctionEndAddress;
702702
UINT32 UnwindInfoAddress;
703-
} PD_RUNTIME_FUNCTION; // MU_CHANGE: Resolve definition conflict in winnt.h for ARM target.
703+
} RUNTIME_FUNCTION;
704704

705705
typedef struct {
706706
UINT8 Version : 3;

0 commit comments

Comments
 (0)