MdeModulePkg: Prevent memcpy intrinsics in VS22 (17.14.2)

The latest VS2022 update replaces some code patterns with struct
assignments with `memcpy`. This change convert the code to
explicitly use `CopyMem`.

Signed-off-by: Michael Kubacki <[email protected]>

Author: makubacki

MdeModulePkg/Universal/DisplayEngineDxe/InputHandler.c

@@ -229,10 +229,16 @@ ReadString (
 
       case CHAR_BACKSPACE:
         if ((StringPtr[0] != CHAR_NULL) && (CurrentCursor != 0)) {
-          for (Index = 0; Index < CurrentCursor - 1; Index++) {
-            TempString[Index] = StringPtr[Index];
+          // MU_CHANGE [BEGIN]: Fix VS22 17.14 memcpy substitution
+          // for (Index = 0; Index < CurrentCursor - 1; Index++) {
+          //   TempString[Index] = StringPtr[Index];
+          // }
+          if (CurrentCursor > 1) {
+            CopyMem (TempString, StringPtr, (CurrentCursor - 1) * sizeof (CHAR16));
           }
 
+          // MU_CHANGE [END]: Fix VS22 17.14 memcpy substitution
+
           Count = GetStringWidth (StringPtr) / 2 - 1;
           if (Count >= CurrentCursor) {
             for (Index = CurrentCursor - 1, Index2 = CurrentCursor; Index2 < Count; Index++, Index2++) {
@@ -261,9 +267,12 @@ ReadString (
           KeyPad[1] = CHAR_NULL;
           Count     = GetStringWidth (StringPtr) / 2 - 1;
           if (CurrentCursor < Count) {
-            for (Index = 0; Index < CurrentCursor; Index++) {
-              TempString[Index] = StringPtr[Index];
-            }
+            // MU_CHANGE [BEGIN]: Fix VS22 17.14 memcpy substitution
+            // for (Index = 0; Index < CurrentCursor; Index++) {
+            //   TempString[Index] = StringPtr[Index];
+            // }
+            CopyMem (TempString, StringPtr, CurrentCursor * sizeof (CHAR16));
+            // MU_CHANGE [END]: Fix VS22 17.14 memcpy substitution
 
             TempString[Index] = CHAR_NULL;
             StrCatS (TempString, MaxLen, KeyPad);

ShellPkg/Library/UefiShellDebug1CommandsLib/HexEdit/BufferImage.c

@@ -143,9 +143,9 @@ HBufferImageBackup (
   )
 {
   // MU_CHANGE [BEGIN]: Fix VS22 17.14 memcpy substitution
-  HBufferImageBackupVar.MousePosition = HBufferImage.MousePosition;
+  // HBufferImageBackupVar.MousePosition = HBufferImage.MousePosition;
 
-  HBufferImageBackupVar.BufferPosition = HBufferImage.BufferPosition;
+  // HBufferImageBackupVar.BufferPosition = HBufferImage.BufferPosition;
   CopyMem (&HBufferImageBackupVar.MousePosition, &HBufferImage.MousePosition, sizeof (HBufferImage.MousePosition));
   CopyMem (&HBufferImageBackupVar.BufferPosition, &HBufferImage.BufferPosition, sizeof (HBufferImage.BufferPosition));
   // MU_CHANGE [END]: Fix VS22 17.14 memcpy substitution