Skip to content
This repository was archived by the owner on Sep 18, 2024. It is now read-only.

Commit 4e33e43

Browse files
authored
Manually cherry-pick bug fix PRs (#4532)
1 parent 0d3802a commit 4e33e43

12 files changed

+13
-21
lines changed

dependencies/required.txt

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ json_tricks >= 3.15.5
44
psutil
55
pyyaml >= 5.4
66
requests
7-
responses
7+
responses ; python_version >= "3.7"
8+
responses < 0.18 ; python_version < "3.7"
89
schema
910
typeguard
1011
PythonWebHDFS

dependencies/required_extra.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ ConfigSpaceNNI
66
smac4nni
77

88
# BOHB
9-
ConfigSpace==0.4.11
10-
statsmodels==0.12.0
9+
ConfigSpace>=0.4.11
10+
statsmodels>=0.12.0
1111

1212
# PPOTuner
1313
gym

nni/algorithms/hpo/tpe_tuner.py

+6-3
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222

2323
from nni.tuner import Tuner
2424
from nni.common.hpo_utils import OptimizeMode, format_search_space, deformat_parameters, format_parameters
25+
from nni.utils import extract_scalar_reward
2526
from . import random_tuner
2627

2728
_logger = logging.getLogger('nni.tuner.tpe')
@@ -126,9 +127,11 @@ def generate_parameters(self, parameter_id, **kwargs):
126127
self._running_params[parameter_id] = params
127128
return deformat_parameters(params, self.space)
128129

129-
def receive_trial_result(self, parameter_id, _parameters, loss, **kwargs):
130-
if self.optimize_mode is OptimizeMode.Maximize:
131-
loss = -loss
130+
def receive_trial_result(self, parameter_id, _parameters, value, **kwargs):
131+
if self.optimize_mode is OptimizeMode.Minimize:
132+
loss = extract_scalar_reward(value)
133+
else:
134+
loss = -extract_scalar_reward(value)
132135
if self.liar:
133136
self.liar.update(loss)
134137
params = self._running_params.pop(parameter_id)

nni/tools/nnictl/ts_management.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
'remote',
1010
'openpai', 'pai',
1111
'aml',
12-
'dlc'
12+
'dlc',
1313
'kubeflow',
1414
'frameworkcontroller',
1515
'adl',

pipelines/integration-test-aml.yml

-2
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ jobs:
1919
echo "Working directory: ${PWD}"
2020
echo "NNI version: ${NNI_RELEASE}"
2121
echo "Build docker image: $(build_docker_image)"
22-
23-
python3 -m pip install --upgrade pip setuptools
2422
displayName: Prepare
2523
2624
- script: |

pipelines/integration-test-hybrid.yml

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ jobs:
1818
1919
echo "Working directory: ${PWD}"
2020
echo "NNI version: ${NNI_RELEASE}"
21-
22-
python3 -m pip install --upgrade pip setuptools
2321
displayName: Prepare
2422
2523
- script: |

pipelines/integration-test-kubeflow.yml

-2
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ jobs:
2222
2323
echo "Working directory: ${PWD}"
2424
echo "NNI version: ${NNI_RELEASE}"
25-
26-
python3 -m pip install --upgrade pip setuptools
2725
displayName: Prepare
2826
2927
- script: |

pipelines/integration-test-openpai-linux.yml

-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ jobs:
2525
echo "Working directory: ${PWD}"
2626
echo "NNI version: ${NNI_RELEASE}"
2727
echo "Build docker image: $(build_docker_image)"
28-
29-
python3 -m pip install --upgrade pip setuptools
3028
displayName: Prepare
3129
3230
- script: |

pipelines/integration-test-remote-l2l.yml

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ jobs:
2323
2424
echo "Working directory: ${PWD}"
2525
echo "NNI version: ${NNI_RELEASE}"
26-
27-
python3 -m pip install --upgrade pip setuptools
2826
displayName: Prepare
2927
3028
- script: |

pipelines/integration-test-remote-l2w.yml

-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ jobs:
2727
echo "Working directory: ${PWD}"
2828
echo "NNI version: ${NNI_RELEASE}"
2929
echo "Build ID: $(Build.BuildId)"
30-
python3 -m pip install --upgrade pip setuptools
3130
python3 setup.py clean --all
3231
displayName: Prepare on Linux manager
3332
@@ -44,7 +43,6 @@ jobs:
4443
sshEndpoint: $(worker)
4544
runOptions: commands
4645
commands: |
47-
conda activate l2w & python -m pip install --upgrade pip setuptools
4846
conda activate l2w & python /tmp/nnitest/$(Build.BuildId)/test/vso_tools/install_nni.py $(NNI_RELEASE)
4947
failOnStdErr: false
5048
displayName: Install NNI on Windows worker

pipelines/integration-test-trt.yml

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ jobs:
1818
1919
echo "Working directory: ${PWD}"
2020
echo "NNI version: ${NNI_RELEASE}"
21-
22-
python3 -m pip install --upgrade pip setuptools
2321
displayName: Prepare
2422
2523
- script: |

test/ut/sdk/test_builtin_tuners.py

+2
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,8 @@ def receive(*args):
5858
return receive
5959

6060
def send_trial_result(self, tuner, parameter_id, parameters, metrics):
61+
if parameter_id % 2 == 1:
62+
metrics = {'default': metrics, 'extra': 'hello'}
6163
tuner.receive_trial_result(parameter_id, parameters, metrics)
6264
tuner.trial_end(parameter_id, True)
6365

0 commit comments

Comments
 (0)