fix GCC 14 compatibility issues

Author: Sayan Shaw

cmake/externals/triton.cmake

@@ -77,22 +77,24 @@ if (WIN32)
   set(triton_patch_exe ${PROJECT_SOURCE_DIR}/cmake/externals/git.Win32.2.41.03.patch/patch.exe)
   set(triton_dependencies ${VCPKG_DEPENDENCIES})
 else()
-  # RapidJSON 1.1.0 (released in 2016) is compatible with the triton build. Later code is not compatible without
-  # patching due to the change in variable name for the include dir from RAPIDJSON_INCLUDE_DIRS to
-  # RapidJSON_INCLUDE_DIRS in the generated cmake file used by find_package:
-  #   https://github.com/Tencent/rapidjson/commit/b91c515afea9f0ba6a81fc670889549d77c83db3
-  # The triton code here https://github.com/triton-inference-server/common/blob/main/CMakeLists.txt is using
-  # RAPIDJSON_INCLUDE_DIRS so the build fails if a newer RapidJSON version is used. It will find the package but the
-  # include path will be wrong so the build error is delayed/misleading and non-trivial to understand/resolve.
+  # RapidJSON 1.1.0 (released in 2016) has C++ compatibility issues with GCC 14 (deprecated std::iterator,
+  # const member assignment). Use a more recent commit that includes these fixes.
   #
-  # Patch RapidJSON to update cmake_minimum_required from 2.8 to 3.5 to fix build with newer CMake versions.
+  # Note: Commit f54b0e47a08782a6131cc3d60f94d038fa6e0a51 is the last commit that uses RAPIDJSON_INCLUDE_DIRS
+  # in RapidJSONConfig.cmake.in. Later commits changed this to RapidJSON_INCLUDE_DIRS which would break the
+  # triton build (see https://github.com/Tencent/rapidjson/commit/b91c515afea9f0ba6a81fc670889549d77c83db3).
+  # The triton code expects RAPIDJSON_INCLUDE_DIRS: https://github.com/triton-inference-server/common/blob/main/CMakeLists.txt
+  #
+  # We also patch cmake_minimum_required to 3.5 to fix build with newer CMake versions (CMake 4.x removed
+  # support for cmake_minimum_required < 3.5).
   set(RapidJSON_PREFIX ${CMAKE_CURRENT_BINARY_DIR}/_deps/rapidjson)
   set(RapidJSON_INSTALL_DIR ${RapidJSON_PREFIX}/install)
   set(rapidjson_patch_command patch --verbose -p1 -i ${PROJECT_SOURCE_DIR}/cmake/externals/rapidjson_cmake.patch)
   ExternalProject_Add(RapidJSON
                       PREFIX ${RapidJSON_PREFIX}
-                      URL https://github.com/Tencent/rapidjson/archive/refs/tags/v1.1.0.zip
-                      URL_HASH SHA1=0fe7b4f7b83df4b3d517f4a202f3a383af7a0818
+                      GIT_REPOSITORY https://github.com/Tencent/rapidjson.git
+                      GIT_TAG f54b0e47a08782a6131cc3d60f94d038fa6e0a51
+                      GIT_SHALLOW TRUE
                       PATCH_COMMAND ${rapidjson_patch_command}
                       CMAKE_ARGS -DRAPIDJSON_BUILD_DOC=OFF
                                  -DRAPIDJSON_BUILD_EXAMPLES=OFF