more refinement

Author: wenbingl

.pipelines/ci.yml

@@ -748,6 +748,7 @@ stages:
     - script: |
         bash ./build.sh \
         -DCMAKE_TOOLCHAIN_FILE=$(Build.BinariesDirectory)/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake \
+        -DOCOS_ENABLE_STATIC_LIB=OFF   \
         -DOCOS_ENABLE_SPM_TOKENIZER=ON \
         -DOCOS_BUILD_PYTHON=OFF  \
         -DOCOS_ENABLE_VISION=OFF \
@@ -758,12 +759,12 @@ stages:
     - script: |
         bash ./build.sh \
         -DCMAKE_TOOLCHAIN_FILE=$(Build.BinariesDirectory)/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake \
+        -DOCOS_ENABLE_STATIC_LIB=ON    \
         -DOCOS_ENABLE_SPM_TOKENIZER=ON \
         -DOCOS_BUILD_PYTHON=OFF  \
         -DOCOS_ENABLE_VISION=OFF \
         -DOCOS_ENABLE_CTEST=OFF  \
-        -DOCOS_ENABLE_C_API=ON   \
-        -DOCOS_ENABLE_STATIC_LIB=ON
+        -DOCOS_ENABLE_C_API=ON
       displayName: build ort-extensions as a static library
 
 - stage: AndroidBuilds

CMakeLists.txt

@@ -54,7 +54,12 @@ include(CMakeDependentOption)
 
 set(_ORTX_STANDALONE_PROJECT OFF)
 if (CMAKE_CURRENT_SOURCE_DIR STREQUAL CMAKE_SOURCE_DIR)
-    set(_ORTX_STANDALONE_PROJECT ON)
+  set(_ORTX_STANDALONE_PROJECT ON)
+endif()
+
+set(_ORTX_SHARED_BUILD_SUPPORTED ON)
+if(CMAKE_SYSTEM_NAME STREQUAL "Emscripten")
+  set(_ORTX_SHARED_BUILD_SUPPORTED OFF)
 endif()
 
 option(CC_OPTIMIZE "Allow compiler optimizations, Set to OFF to disable" ON)
@@ -82,7 +87,7 @@ option(OCOS_ENABLE_STATIC_LIB "Enable generating static library" OFF) # only for
 option(OCOS_ENABLE_SELECTED_OPLIST "Enable including the selected_ops tool file" OFF)
 option(OCOS_ENABLE_C_API "Enable building the C API" OFF)
 
-option(OCOS_BUILD_SHARED_LIB "Enable building the dynamic library" ON)
+option(OCOS_BUILD_SHARED_LIB "Enable building the dynamic library" ${_ORTX_SHARED_BUILD_SUPPORTED})
 option(OCOS_BUILD_PYTHON "Enable building the Python package" OFF)
 option(OCOS_BUILD_JAVA "Enable building the Java package" OFF)
 option(OCOS_BUILD_ANDROID "Enable building the Android package" OFF)

cmake/ext_wasm.cmake

@@ -9,9 +9,6 @@ if(OCOS_ENABLE_STATIC_LIB)
   add_library(onnxruntime_extensions ALIAS ortcustomops)
   standardize_output_folder(ortcustomops)
 else()
-  # Emscripten does not support building a shared library with custom ops.
-  # and backward compatible with the previous version, we silently turn off the shared library build.
-  set(OCOS_BUILD_SHARED_LIB OFF CACHE INTERNAL "" FORCE)
   add_executable(ortcustomops ${_TARGET_LIB_SRC})
   set_target_properties(ortcustomops PROPERTIES LINK_FLAGS "                                  \
                       -s WASM=1                                                               \