Fix crash at process exit on macOS

Author: fs-eire

js/node/src/ort_instance_data.cc

@@ -8,8 +8,8 @@
 #include "ort_instance_data.h"
 #include "onnxruntime_cxx_api.h"
 
-std::unique_ptr<Ort::Env> OrtInstanceData::ortEnv;
-std::unique_ptr<Ort::RunOptions> OrtInstanceData::ortDefaultRunOptions;
+Ort::Env* OrtInstanceData::ortEnv;
+Ort::RunOptions* OrtInstanceData::ortDefaultRunOptions;
 std::mutex OrtInstanceData::ortEnvMutex;
 std::atomic<uint64_t> OrtInstanceData::ortEnvRefCount;
 std::atomic<bool> OrtInstanceData::ortEnvDestroyed;
@@ -20,10 +20,29 @@ OrtInstanceData::OrtInstanceData() {
 
 OrtInstanceData::~OrtInstanceData() {
   if (--ortEnvRefCount == 0) {
+    // OrtInstanceData is the "instance data" for Napi::Env, so when the last Napi::Env using ORT is destroyed, we
+    // clean up the global ORT env here.
+    //
+    // Note:
+    // - The current function is not guaranteed to be called. In Node.js, the finalizer of the instance data may not be
+    //   called at certain scenarios, including but not limited to:
+    //   - Uncaught exceptions causing process termination.
+    //   - Process exit via process.exit().
+    //
+    //   In those scenarios, the destructor won't be called, and the OS will reclaim all memory used by the process.
+    //   This helps avoid unexpected crashes during process shutdown due to the order of static destruction across
+    //   different translation units.
+    //
+    //   For more details, see:
+    //   - https://github.com/microsoft/onnxruntime/issues/24579
+    //   - https://github.com/nodejs/node/issues/58341
+    //
     std::lock_guard<std::mutex> lock(ortEnvMutex);
     if (ortEnv) {
-      ortDefaultRunOptions.reset(nullptr);
-      ortEnv.reset();
+      delete ortDefaultRunOptions;
+      ortDefaultRunOptions = nullptr;
+      delete ortEnv;
+      ortEnv = nullptr;
       ortEnvDestroyed = true;
     }
   }
@@ -46,8 +65,8 @@ void OrtInstanceData::InitOrt(Napi::Env env, int log_level, Napi::Function tenso
     std::lock_guard<std::mutex> lock(ortEnvMutex);
     if (!ortEnv) {
       ORT_NAPI_THROW_ERROR_IF(ortEnvDestroyed, env, "OrtEnv already destroyed.");
-      ortEnv.reset(new Ort::Env{OrtLoggingLevel(log_level), "onnxruntime-node"});
-      ortDefaultRunOptions.reset(new Ort::RunOptions{});
+      ortEnv = new Ort::Env{OrtLoggingLevel(log_level), "onnxruntime-node"};
+      ortDefaultRunOptions = new Ort::RunOptions{};
     }
   }
 }

js/node/src/ort_instance_data.h

@@ -28,9 +28,9 @@ struct OrtInstanceData {
   // Get the Tensor constructor reference for the Napi::Env
   static const Napi::FunctionReference& TensorConstructor(Napi::Env env);
   // Get the global Ort::Env
-  static const Ort::Env* OrtEnv() { return ortEnv.get(); }
+  static const Ort::Env* OrtEnv() { return ortEnv; }
   // Get the default Ort::RunOptions
-  static Ort::RunOptions* OrtDefaultRunOptions() { return ortDefaultRunOptions.get(); }
+  static const Ort::RunOptions* OrtDefaultRunOptions() { return ortDefaultRunOptions; }
 
   ~OrtInstanceData();
 
@@ -42,8 +42,8 @@ struct OrtInstanceData {
   Napi::FunctionReference ortTensorConstructor;
 
   // ORT env (global singleton)
-  static std::unique_ptr<Ort::Env> ortEnv;
-  static std::unique_ptr<Ort::RunOptions> ortDefaultRunOptions;
+  static Ort::Env* ortEnv;
+  static Ort::RunOptions* ortDefaultRunOptions;
   static std::mutex ortEnvMutex;
   static std::atomic<uint64_t> ortEnvRefCount;
   static std::atomic<bool> ortEnvDestroyed;