Skip to content

Commit 2e40cba

Browse files
Changming Sunashrit-ms
authored andcommitted
Update android_min_sdk_version/android_target_sdk_version (#23369)
Update android_min_sdk_version to 24 and android_target_sdk_version to 34. Previously Jian already updated the values for some pipelines. This PR updates the other occurrences to make things consistent Why android_min_sdk_version is set to 24: Because React Native requires so: react-native-community/discussions-and-proposals#802 Why android_target_sdk_version is set to 34: Because according to Google Play's policy, new apps and app updates must target Android 14 (API level 34) to be submitted to Google Play. https://support.google.com/googleplay/android-developer/answer/11926878?hl=en
1 parent b92115a commit 2e40cba

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

js/react_native/android/gradle.properties

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ org.gradle.jvmargs=-Xmx4096m -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF
1414
android.enableJetifier=true
1515
android.useAndroidX=true
1616
OnnxruntimeModule_buildToolsVersion=29.0.2
17-
OnnxruntimeModule_compileSdkVersion=31
18-
OnnxruntimeModule_minSdkVersion=21
19-
OnnxruntimeModule_targetSdkVersion=31
17+
OnnxruntimeModule_compileSdkVersion=34
18+
OnnxruntimeModule_minSdkVersion=24
19+
OnnxruntimeModule_targetSdkVersion=34

js/react_native/e2e/android/build.gradle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
buildscript {
44
ext {
55
buildToolsVersion = "29.0.2"
6-
minSdkVersion = 21
7-
compileSdkVersion = 31
8-
targetSdkVersion = 31
6+
minSdkVersion = 24
7+
compileSdkVersion = 34
8+
targetSdkVersion = 34
99
kotlinVersion = "1.5.30"
1010
}
1111
repositories {

tools/ci_build/github/android/default_qnn_aar_build_settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"build_abis": [
33
"arm64-v8a"
44
],
5-
"android_min_sdk_version": 21,
6-
"android_target_sdk_version": 24,
5+
"android_min_sdk_version": 24,
6+
"android_target_sdk_version": 34,
77
"build_params": [
88
"--enable_lto",
99
"--android",

tools/ci_build/github/android/training_full_aar_build_settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"x86",
66
"x86_64"
77
],
8-
"android_min_sdk_version": 21,
9-
"android_target_sdk_version": 24,
8+
"android_min_sdk_version": 24,
9+
"android_target_sdk_version": 34,
1010
"build_params": [
1111
"--enable_lto",
1212
"--android",

tools/ci_build/github/js/react_native_e2e_full_aar_build_settings.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
"build_abis": [
33
"x86_64"
44
],
5-
"android_min_sdk_version": 21,
6-
"android_target_sdk_version": 24,
5+
"android_min_sdk_version": 24,
6+
"android_target_sdk_version": 34,
77
"build_params": [
88
"--android",
99
"--parallel",

0 commit comments

Comments
 (0)